CheckoutStep_ShippingMethod

Complexity

Total Complexity

7

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	shippingmethod()	0	11	2
B	ShippingMethodForm()	0	32	2
A	setShippingMethod()	0	14	3

<?php
/**
 * Gives methods to ship by, based on previously given address and order items.
 *
 * @package silvershop-shipping
 */
class CheckoutStep_ShippingMethod extends CheckoutStep
{
    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

        'shippingmethod',
        'ShippingMethodForm'
    );

    public function shippingmethod()
    {
        $form = $this->ShippingMethodForm();
        $cart = ShoppingCart::singleton()->current();
        if ($cart->ShippingMethodID) {
            $form->loadDataFrom($cart);
        }
        return array(
            'OrderForm' => $form
        );
    }

    public function ShippingMethodForm()
    {
        $order = $this->owner->Cart();
        $estimates = $order->getShippingEstimates();
        $fields = new FieldList();
        if ($estimates->exists()) {
            $fields->push(
                OptionsetField::create(
                    "ShippingMethodID",
                    _t('CheckoutStep_ShippingMethod.ShippingOptions', 'Shipping Options'),
                    $estimates->map(),
                    $estimates->First()->ID
                )
            );
        } else {
            $fields->push(
                LiteralField::create(
                    "NoShippingMethods",
                    _t('CheckoutStep_ShippingMethod.NoShippingMethods',
                        '<p class=\"message warning\">There are no shipping methods available</p>'
                    )
                )
            );
        }
        $actions = new FieldList(
            
            new FormAction("setShippingMethod", _t('CheckoutStep.Continue', 'Continue'))
        );
        $form = new Form($this->owner, "ShippingMethodForm", $fields, $actions);
        $this->owner->extend('updateShippingMethodForm', $form);
        return $form;
    }

    public function setShippingMethod($data, $form)

The parameter $form is not used and could be removed.

    {
        $order = $this->owner->Cart();
        $option = null;
        if (isset($data['ShippingMethodID'])) {
            $option = ShippingMethod::get()
                        ->byID((int)$data['ShippingMethodID']);
        }
        //assign option to order / modifier
        if ($option) {
            $order->setShippingMethod($option);
        }
        $this->owner->redirect($this->NextStepLink());
    }
}