MembershipCheckoutComponent

Complexity

Total Complexity

31

Size/Duplication

Total Lines	149
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	15

Test Coverage

Coverage

58.16%

Importance

Changes	5
Bugs	1	Features	2

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	15	3
B	getFormFields()	0	14	5
A	getRequiredFields()	0	10	3
A	getPasswordField()	0	9	2
A	getData()	0	10	2
C	setData()	0	30	7
A	setConfirmed()	0	6	1
C	validateData()	0	34	8

<?php

/**
 * Provides:
 *    - member identifier, and password fields.
 *    - required membership fields
 *    - validating data
 *
 */
class MembershipCheckoutComponent extends CheckoutComponent
{
    protected $confirmed;

    protected $passwordvalidator;

    protected $dependson = array(
        'CustomerDetailsCheckoutComponent',
    );

    public function __construct($confirmed = true, $validator = null)
    {
        $this->confirmed = $confirmed;
        if (!$validator) {
            $this->passwordvalidator = Member::password_validator();
            if (!$this->passwordvalidator) {
                $this->passwordvalidator = PasswordValidator::create();
                $this->passwordvalidator->minLength(5);
                $this->passwordvalidator->characterStrength(
                    2,
                    array("lowercase", "uppercase", "digits", "punctuation")
                );
            }
        }
    }

    public function getFormFields(Order $order, Form $form = null)
    {
        $fields = FieldList::create();
        if (Member::currentUserID()) {
            return $fields;
        }
        $idfield = Member::config()->unique_identifier_field;
        if (!$order->{$idfield} && ($form && !$form->Fields()->fieldByName($idfield))) {
            //TODO: scaffold the correct id field type
            $fields->push(TextField::create($idfield, $idfield));
        }
        $fields->push($this->getPasswordField());
        return $fields;
    }

    public function getRequiredFields(Order $order)
    {
        if (Member::currentUserID() || !Checkout::membership_required()) {
            return array();
        }
        return array(
            Member::config()->unique_identifier_field,
            'Password',
        );
    }

    public function getPasswordField()
    {
        if ($this->confirmed) {
            //relies on fix: https://github.com/silverstripe/silverstripe-framework/pull/2757
            return ConfirmedPasswordField::create('Password', _t('CheckoutField.Password', 'Password'))
                ->setCanBeEmpty(!Checkout::membership_required());
        }
        return PasswordField::create('Password', _t('CheckoutField.Password', 'Password'));
    }

    public function validateData(Order $order, array $data)
    {
        if (Member::currentUserID()) {
            return;
        }
        $result = ValidationResult::create();
        if (Checkout::membership_required() || !empty($data['Password'])) {
            $member = Member::create($data);
            $idfield = Member::config()->unique_identifier_field;
            $idval = $data[$idfield];
            if (ShopMember::get_by_identifier($idval)) {
                // get localized field labels
                $fieldLabels = $member->fieldLabels(false);
                // if a localized value exists, use this for our error-message
                $fieldLabel = isset($fieldLabels[$idfield]) ? $fieldLabels[$idfield] : $idfield;
                $result->error(
                    _t(
                        'Checkout.MemberExists',
                        'A member already exists with the {Field} {Identifier}',
                        '',
                        array('Field' => $fieldLabel, 'Identifier' => $idval)

array('Field' => $fieldLabel, 'Identifier' => $idval) is of type array<string,?,{"Field":"?","Identifier":"?"}>, but the function expects a string.

                    ),
                    $idfield
                );
            }
            $passwordresult = $this->passwordvalidator->validate($data['Password'], $member);
            if (!$passwordresult->valid()) {
                $result->error($passwordresult->message(), "Password");
            }
        }
        if (!$result->valid()) {
            throw new ValidationException($result);
        }
    }

    public function getData(Order $order)
    {
        $data = array();

        if ($member = Member::currentUser()) {
            $idf = Member::config()->unique_identifier_field;
            $data[$idf] = $member->{$idf};
        }
        return $data;
    }

    /**
     * @throws ValidationException
     */
    public function setData(Order $order, array $data)
    {
        if (Member::currentUserID()) {
            return;
        }
        if (!Checkout::membership_required() && empty($data['Password'])) {
            return;
        }

        $factory = new ShopMemberFactory();
        $member = $factory->create($data);
        $member->write();
        $member->logIn();

        if ($order->BillingAddressID) {
            $address = $order->getBillingAddress();
            $address->MemberID = $member->ID;

The property MemberID does not exist on object<Address>. Since you implemented __set, maybe consider adding a @property annotation.

            $address->write();
            $member->DefaultBillingAddressID = $order->BillingAddressID;
        }
        if ($order->ShippingAddressID) {
            $address = $order->getShippingAddress();
            $address->MemberID = $member->ID;

The property MemberID does not exist on object<Address>. Since you implemented __set, maybe consider adding a @property annotation.

            $address->write();
            $member->DefaultShippingAddressID = $order->ShippingAddressID;

The property DefaultShippingAddressID does not seem to exist. Did you mean defaults?

        }
        if ($member->isChanged()) {
            $member->write();
        }
    }

    public function setConfirmed($confirmed)
    {
        $this->confirmed = $confirmed;

        return $this;
    }
}