SilverShop\Model\Variation\OrderItem

Complexity

Total Complexity

25

Size/Duplication

Total Lines	90
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	ProductVariation()	0	14	6
A	Depth()	0	6	3
A	onPlacement()	0	5	2
A	Height()	0	6	3
A	Width()	0	6	3
A	SubTitle()	0	6	2
A	Image()	0	6	3
A	Weight()	0	6	3

<?php

namespace SilverShop\Model\Variation;

use SilverStripe\Versioned\Versioned;

/**
 * Product Variation - Order Item
 * Connects a variation to an order, as a line in the order specifying the particular variation.
 *
 * @property int $ProductVariationVersion
 * @property int $ProductVariationID
 */
class OrderItem extends \SilverShop\Model\Product\OrderItem
{
    private static $db = [

The private property $db is not used, and could be removed.

        'ProductVariationVersion' => 'Int',
    ];

    private static $has_one = [

The private property $has_one is not used, and could be removed.

        'ProductVariation' => Variation::class
    ];

    private static $buyable_relationship = 'ProductVariation';

The private property $buyable_relationship is not used, and could be removed.

    private static $table_name = 'SilverShop_Variation_OrderItem';

The private property $table_name is not used, and could be removed.

    /**
     * Overloaded relationship, for getting versioned variations
     *
     * @param  boolean $current
     * @return Variation
     */
    public function ProductVariation($forcecurrent = false)
    {
        if ($this->ProductVariationID && $this->ProductVariationVersion && !$forcecurrent) {
            return Versioned::get_version(
                Variation::class,
                $this->ProductVariationID,
                $this->ProductVariationVersion
            );
        } elseif ($this->ProductVariationID
            && $product = Variation::get()->byID($this->ProductVariationID)
        ) {
            return $product;
        }
        return null;
    }
    
    public function onPlacement()
    {
        parent::onPlacement();
        if ($productVariation = $this->ProductVariation(true)) {
            $this->ProductVariationVersion = $productVariation->Version;

The property Version does not exist on SilverShop\Model\Variation\Variation. Since you implemented __get, consider adding a @property annotation.

        }
    }

    public function SubTitle()
    {
        if ($this->ProductVariation()) {
            return $this->ProductVariation()->getTitle();
        }
        return false;
    }

    public function Image()
    {
        if (($variation = $this->ProductVariation()) && $variation->Image()->exists()) {
            return $variation->Image();
        }
        return $this->Product()->Image();
    }

    public function Width()
    {
        if (($variation = $this->ProductVariation()) && $variation->Width) {
            return $variation->Width;
        }
        return $this->Product()->Width;
    }

    public function Height()
    {
        if (($variation = $this->ProductVariation()) && $variation->Height) {
            return $variation->Height;
        }
        return $this->Product()->Height;
    }

    public function Depth()
    {
        if (($variation = $this->ProductVariation()) && $variation->Depth) {
            return $variation->Depth;
        }
        return $this->Product()->Depth;
    }

    public function Weight()
    {
        if (($variation = $this->ProductVariation()) && $variation->Weight) {
            return $variation->Weight;
        }
        return $this->Product()->Weight;
    }
}