SteppedCheckoutTest::setUpOnce() - Code Metrics - Inspection of "Clear the cart/session for every test-suite that u..." - silvershop/silvershop-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 2.0 (#461)

by Roman

created 2016-03-18 18:03 UTC

SteppedCheckoutTest::setUpOnce() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	0

<?php

class SteppedCheckoutTest extends FunctionalTest
{
    protected static $fixture_file = array(
        'silvershop/tests/fixtures/Pages.yml',
        'silvershop/tests/fixtures/shop.yml',
    );
    protected static $use_draft_site = true; //so we don't need to publish
    protected $autoFollowRedirection = false;
    /** @var CheckoutPage_Controller */
    protected $checkout;
    /** @var Product */
    protected $socks;

    public function setUpOnce()
    {
        parent::setUpOnce();
        // clear session
        ShoppingCart::singleton()->clear();
    }

    public function setUp()
    {
        parent::setUp();
        ShopTest::setConfiguration();
        //set up steps
        SteppedCheckout::setupSteps(); //use default steps

        $this->socks = $this->objFromFixture("Product", "socks");
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->socks->publish('Stage', 'Live');

        $checkoutpage = $this->objFromFixture("CheckoutPage", "checkout");
        $checkoutpage->publish('Stage', 'Live');
        $this->checkout = new CheckoutPage_Controller();
        $this->checkout->handleRequest(new SS_HTTPRequest("GET", "checkout"), DataModel::inst());

        $this->cart = $this->objFromFixture("Order", "cart");
class MyClass { }

$x = new MyClass();
$x->foo = true;
        ShoppingCart::singleton()->setCurrent($this->cart);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testTemplateFunctionsForFirstStep()
    {
        //put us at the first step index == membership
        $indexRequest = new SS_HTTPRequest('GET', "");
        $this->checkout = new CheckoutPage_Controller(); // from 3.3 on it's necessary to have a clean controller here
        $this->checkout->handleRequest($indexRequest, DataModel::inst());
        $this->assertTrue($this->checkout->StepExists('membership'));

        $this->assertFalse($this->checkout->IsPastStep('membership'));

        $this->assertTrue($this->checkout->IsCurrentStep('membership'));

        $this->assertFalse($this->checkout->IsFutureStep('membership'));


        $this->checkout->NextStepLink();

        $this->assertTrue($this->checkout->StepExists('contactdetails'));

        $this->assertFalse($this->checkout->IsPastStep('contactdetails'));

        $this->assertFalse($this->checkout->IsCurrentStep('contactdetails'));

        $this->assertTrue($this->checkout->IsFutureStep('contactdetails'));

    }

    public function testTemplateFunctionsForOtherSteps()
    {
        $summaryRequest = new SS_HTTPRequest('GET', "summary");
        $this->checkout = new CheckoutPage_Controller();
        $this->checkout->handleRequest($summaryRequest, DataModel::inst()); //change to summary step
        $this->assertTrue($this->checkout->StepExists('summary'));

        $this->assertFalse($this->checkout->IsPastStep('summary'));

        $this->assertTrue($this->checkout->IsCurrentStep('summary'));

        $this->assertFalse($this->checkout->IsFutureStep('summary'));


        $this->assertFalse($this->checkout->StepExists('nosuchstep'));

    }

    public function testMembershipStep()
    {
        //this should still work if there is no cart
        ShoppingCart::singleton()->clear();

        $this->checkout->index();
        $this->checkout->membership();
        $this->post('/checkout/guestcontinue', array()); //redirect to next step
        $this->checkout->createaccount(new SS_HTTPRequest('GET', "/checkout/createaccount"));

        $form = $this->checkout->MembershipForm();
        $data = array();
        $form->loadDataFrom($data);

        $data = array(
            'FirstName'              => 'Michael',
            'Surname'                => 'Black',
            'Email'                  => '[email protected]',
            'Password'               => array(
                '_Password'        => 'pass1234',
                '_ConfirmPassword' => 'pass1234',
            ),
            'action_docreateaccount' => 'Create New Account',
        );
        $response = $this->post('/checkout/CreateAccountForm', $data); //redirect to next step
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $member = ShopMember::get_by_identifier("[email protected]");
        $this->assertTrue((boolean)$member, "Check new account was created");

        $this->assertEquals('Michael', $member->FirstName);

        $this->assertEquals('Black', $member->Surname);

    }

    public function testContactDetails()
    {
        $this->objFromFixture("Member", "joebloggs")->logIn();
        $this->checkout->contactdetails();
        $data = array(
            'FirstName'                => 'Pauline',
            'Surname'                  => 'Richardson',
            'Email'                    => '[email protected]',
            'action_setcontactdetails' => 1,
        );
        $response = $this->post('/checkout/ContactDetailsForm', $data);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $this->markTestIncomplete('check order has been updated');

    }

    public function testShippingAddress()
    {
        $this->objFromFixture("Member", "joebloggs")->logIn();
        $this->checkout->shippingaddress();
        $data = array(
            'Address'           => '2b Baba place',
            'AddressLine2'      => 'Level 2',
            'City'              => 'Newton',
            'State'             => 'Wellington',
            'Country'           => 'NZ',
            'action_setaddress' => 1,
        );
        $response = $this->post('/checkout/AddressForm', $data);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $this->markTestIncomplete('assertions!');

    }

    public function testBillingAddress()
    {
        $this->objFromFixture("Member", "joebloggs")->logIn();
        $this->checkout->billingaddress();
        $data = array(
            'Address'                  => '3 Art Cresent',
            'AddressLine2'             => '',
            'City'                     => 'Walkworth',
            'State'                    => 'New Caliphoneya',
            'Country'                  => 'ZA',
            'action_setbillingaddress' => 1,
        );
        $response = $this->post('/checkout/AddressForm', $data);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $this->markTestIncomplete('assertions!');

    }

    public function testPaymentMethod()
    {
        $data = array(
            'PaymentMethod'           => 'Dummy',
            'action_setpaymentmethod' => 1,
        );
        $response = $this->post('/checkout/PaymentMethodForm', $data);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $this->assertEquals('Dummy', Checkout::get($this->cart)->getSelectedPaymentMethod());

    }

    public function testSummary()
    {
        $this->checkout->summary();
        $form = $this->checkout->ConfirmationForm();
        $data = array(
            'Notes'                  => 'Leave it around the back',
            'ReadTermsAndConditions' => 1,
        );
        $member = $this->objFromFixture("Member", "joebloggs");
        $member->logIn(); //log in member before processing

        Checkout::get($this->cart)->setPaymentMethod("Dummy"); //a selected payment method is required
        $form->loadDataFrom($data);
        $this->assertTrue($form->validate(), "Checkout data is valid");

        $response = $this->post('/checkout/ConfirmationForm', $data);
        $this->assertEquals('Cart', $this->cart->Status, "Order is still in cart");


        $order = Order::get()->byID($this->cart->ID);

        $this->assertEquals("Leave it around the back", $order->Notes);


        //redirect to make payment
        $this->assertEquals(302, $response->getStatusCode());

        $this->assertEquals(

            Director::baseURL() . "checkout/payment",
            $response->getHeader('Location')
        );
    }
}


1			<?php
2
3			class SteppedCheckoutTest extends FunctionalTest
4			{
5			protected static $fixture_file = array(
6			'silvershop/tests/fixtures/Pages.yml',
7			'silvershop/tests/fixtures/shop.yml',
8			);
9			protected static $use_draft_site = true; //so we don't need to publish
10			protected $autoFollowRedirection = false;
11			/** @var CheckoutPage_Controller */
12			protected $checkout;
13			/** @var Product */
14			protected $socks;
15
16			public function setUpOnce()
17			{
18			parent::setUpOnce();
19			// clear session
20			ShoppingCart::singleton()->clear();
21			}
22
23			public function setUp()
24			{
25			parent::setUp();
26			ShopTest::setConfiguration();
27			//set up steps
28			SteppedCheckout::setupSteps(); //use default steps
29
30			$this->socks = $this->objFromFixture("Product", "socks");
			0 ignored issues – show Documentation Bug introduced 2016-02-23 23:20 UTC by Report Bug Copy Issue Report It seems like `$this->objFromFixture('Product', 'socks')` can also be of type `object<DataObject>`. However, the property `$socks` is declared as type `object<Product>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
31			$this->socks->publish('Stage', 'Live');
32
33			$checkoutpage = $this->objFromFixture("CheckoutPage", "checkout");
34			$checkoutpage->publish('Stage', 'Live');
35			$this->checkout = new CheckoutPage_Controller();
36			$this->checkout->handleRequest(new SS_HTTPRequest("GET", "checkout"), DataModel::inst());
37
38			$this->cart = $this->objFromFixture("Order", "cart");
			0 ignored issues – show Bug introduced 2016-02-23 23:20 UTC by Report Bug Copy Issue Report The property `cart` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...

silvershop / silvershop-core

Pull Request — 2.0 (#461)

SteppedCheckoutTest::setUpOnce() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like