ShoppingCartControllerTest::testSecurityToken() - Code Metrics - Inspection of "Added config setting to disable security-tokens fo..." - silvershop/silvershop-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#482)

by Roman

created 2016-04-20 18:31 UTC

ShoppingCartControllerTest::testSecurityToken() B

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	45
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	45
rs	8.8571
cc	2
eloc	24
nc	2
nop	0

<?php

/**
 * @link ShoppingCart_Controller
 *
 * Test manipulating via urls.
 */
class ShoppingCartControllerTest extends FunctionalTest
{
    public static $fixture_file   = 'silvershop/tests/fixtures/shop.yml';
    public static $disable_theme  = true;
    public static $use_draft_site = false;
    protected $autoFollowRedirection = false;

    public function setUp()
    {
        parent::setUp();

        ShopTest::setConfiguration(); //reset config

        $this->mp3player = $this->objFromFixture('Product', 'mp3player');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->socks = $this->objFromFixture('Product', 'socks');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        //products that can't be purchased
        $this->noPurchaseProduct = $this->objFromFixture('Product', 'beachball');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->draftProduct = $this->objFromFixture('Product', 'tshirt');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->noPriceProduct = $this->objFromFixture('Product', 'hdtv');
class MyClass { }

$x = new MyClass();
$x->foo = true;

        //publish some products
        $this->mp3player->publish('Stage', 'Live');
        $this->socks->publish('Stage', 'Live');
        $this->noPurchaseProduct->publish('Stage', 'Live');
        $this->noPriceProduct->publish('Stage', 'Live');
        //note that we don't publish 'tshirt'... we want it to remain in draft form.

        $this->cart = ShoppingCart::singleton();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function testAddToCart()
    {
        // add 2 of the same items via url
        $this->get(ShoppingCart_Controller::add_item_link($this->mp3player)); //add item via url

        $this->get(ShoppingCart_Controller::add_item_link($this->mp3player)); //add another

        $this->get(ShoppingCart_Controller::add_item_link($this->socks)); //add a different product

        $this->get(
            ShoppingCart_Controller::add_item_link($this->noPurchaseProduct)

        );  //add a product that you can't add
        $this->get(ShoppingCart_Controller::add_item_link($this->draftProduct));  //add a product that is draft

        $this->get(ShoppingCart_Controller::add_item_link($this->noPriceProduct));  //add a product that has no price


        // See what's in the cart
        $items = ShoppingCart::curr()->Items();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->assertNotNull($items);


        $this->assertEquals($items->Count(), 2, 'There are 2 items in the cart');

        //join needed to provide ProductID
        $mp3playeritem =
            $items->innerJoin("Product_OrderItem", "\"OrderItem\".\"ID\" = \"Product_OrderItem\".\"ID\"")->find(
                'ProductID',
                $this->mp3player->ID
            );    //join needed to provide ProductID
        $this->assertNotNull($mp3playeritem, "Mp3 player is in cart");


        // We have the product that we asserted in our fixture file, with a quantity of 2 in the cart
        $this->assertEquals(

            $mp3playeritem->ProductID,
            $this->mp3player->ID,
            'We have the correct Product ID in the cart.'
        );
        $this->assertEquals($mp3playeritem->Quantity, 2, 'We have 2 of this product in the cart.');


        // set item quantiy
        $this->get(
            ShoppingCart_Controller::set_quantity_item_link($this->mp3player, array('quantity' => 5))

        ); //add item via url
        $items = ShoppingCart::curr()->Items();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $mp3playeritem =
            $items->innerJoin("Product_OrderItem", "\"OrderItem\".\"ID\" = \"Product_OrderItem\".\"ID\"")->find(
                'ProductID',
                $this->mp3player->ID
            ); //join needed to provide ProductID
        $this->assertEquals($mp3playeritem->Quantity, 5, 'We have 5 of this product in the cart.');


        // non purchasable product checks
        $this->assertEquals(

            $this->noPurchaseProduct->canPurchase(),
            false,
            'non-purcahseable product is not purchaseable'
        );
        $this->assertArrayNotHasKey(

            $this->noPurchaseProduct->ID,
            $items->map('ProductID')->toArray(),
            'non-purcahable product is not in cart'
        );
        $this->assertEquals($this->draftProduct->canPurchase(), true, 'draft products can be purchased');

        $this->assertArrayNotHasKey(

            $this->draftProduct->ID,
            $items->map('ProductID')->toArray(),
            'draft product is not in cart'
        );
        $this->assertEquals($this->noPriceProduct->canPurchase(), false, 'product without price is not purchaseable');

        $this->assertArrayNotHasKey(

            $this->noPriceProduct->ID,
            $items->map('ProductID')->toArray(),
            'product without price is not in cart'
        );

        $this->cart->clear();
    }

    public function testRemoveFromCart()
    {

        // add items via url
        $this->get(ShoppingCart_Controller::set_quantity_item_link($this->mp3player, array('quantity' => 5)));

        $this->assertTrue($this->cart->get($this->mp3player) !== false, "mp3player item now exists in cart");

        $this->get(ShoppingCart_Controller::add_item_link($this->socks));

        $this->assertTrue($this->cart->get($this->socks) !== false, "socks item now exists in cart");


        // remove items via url
        $this->get(ShoppingCart_Controller::remove_item_link($this->socks)); //remove one different = remove completely

        $this->assertFalse($this->cart->get($this->socks));


        $this->get(ShoppingCart_Controller::remove_item_link($this->mp3player)); //remove one product = 4 left


        $mp3playeritem = $this->cart->get($this->mp3player);
        $this->assertTrue($mp3playeritem !== false, "product still exists");

        $this->assertEquals($mp3playeritem->Quantity, 4, "only 4 of item left");


        $items = ShoppingCart::curr()->Items();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->assertNotNull($items, "Cart is not empty");


        $this->cart->clear(); //test clearing cart
        $this->assertEquals(

            ShoppingCart::curr(),
            null,
            'Cart is clear'
        ); //items is a databoject set, and will therefore be null when cart is empty.
    }

    public function testVariations()
    {
        $this->loadFixture('silvershop/tests/fixtures/variations.yml');
        $ballRoot = $this->objFromFixture('Product', 'ball');
        $ballRoot->publish('Stage', 'Live');
        $ball1 = $this->objFromFixture('ProductVariation', 'redlarge');
        $ball2 = $this->objFromFixture('ProductVariation', 'redsmall');

        // Add the two variation items
        $this->get(ShoppingCart_Controller::add_item_link($ball1));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->get(ShoppingCart_Controller::add_item_link($ball2));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $items = ShoppingCart::curr()->Items();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->assertNotNull($items);

        $this->assertEquals($items->Count(), 2, 'There are 2 items in the cart');


        // Remove one and see what happens
        $this->get(ShoppingCart_Controller::remove_all_item_link($ball1));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertEquals($items->Count(), 1, 'There is 1 item in the cart');

        $this->assertFalse($this->cart->get($ball1), "first item not in cart");

        $this->assertNotNull($this->cart->get($ball1), "second item is in cart");

    }

    public function testSecurityToken()
    {
        $enabled = SecurityToken::is_enabled();
        // enable security tokens
        SecurityToken::enable();

        $productId = $this->mp3player->ID;
        // link should contain the security-token
        $link = ShoppingCart_Controller::add_item_link($this->mp3player);
        $this->assertRegExp('{^shoppingcart/add/Product/'.$productId.'\?SecurityID=[a-f0-9]+$}', $link);


        // should redirect back to the shop
        $response = $this->get($link);
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
        $this->assertEquals($response->getStatusCode(), 302);


        // disable security token for cart-links
        Config::inst()->update('ShoppingCart_Controller', 'disable_security_token', true);

        $link = ShoppingCart_Controller::add_item_link($this->mp3player);
        $this->assertEquals('shoppingcart/add/Product/'.$productId, $link);


        // should redirect back to the shop
        $response = $this->get($link);
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
        $this->assertEquals($response->getStatusCode(), 302);


        SecurityToken::disable();

        Config::inst()->update('ShoppingCart_Controller', 'disable_security_token', false);
        $link = ShoppingCart_Controller::add_item_link($this->mp3player);
        $this->assertEquals('shoppingcart/add/Product/'.$productId , $link);


        // should redirect back to the shop
        $response = $this->get($link);
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
        $this->assertEquals($response->getStatusCode(), 302);


        SecurityToken::enable();
        // should now return a 400 status
        $response = $this->get($link);
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
        $this->assertEquals($response->getStatusCode(), 400);


        // restore previous setting
        if(!$enabled){
            SecurityToken::disable();
        }
    }
}


1			<?php
2
3			/**
4			* @link ShoppingCart_Controller
5			*
6			* Test manipulating via urls.
7			*/
8			class ShoppingCartControllerTest extends FunctionalTest
9			{
10			public static $fixture_file = 'silvershop/tests/fixtures/shop.yml';
11			public static $disable_theme = true;
12			public static $use_draft_site = false;
13			protected $autoFollowRedirection = false;
14
15			public function setUp()
16			{
17			parent::setUp();
18
19			ShopTest::setConfiguration(); //reset config
20
21			$this->mp3player = $this->objFromFixture('Product', 'mp3player');
			0 ignored issues – show Bug introduced 2016-02-23 23:20 UTC by Report Bug Copy Issue Report The property `mp3player` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
22			$this->socks = $this->objFromFixture('Product', 'socks');
			0 ignored issues – show Bug introduced 2016-02-23 23:20 UTC by Report Bug Copy Issue Report The property `socks` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
23			//products that can't be purchased
24			$this->noPurchaseProduct = $this->objFromFixture('Product', 'beachball');
			0 ignored issues – show Bug introduced 2016-02-23 23:20 UTC by Report Bug Copy Issue Report The property `noPurchaseProduct` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25			$this->draftProduct = $this->objFromFixture('Product', 'tshirt');
			0 ignored issues – show Bug introduced 2016-02-23 23:20 UTC by Report Bug Copy Issue Report The property `draftProduct` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26			$this->noPriceProduct = $this->objFromFixture('Product', 'hdtv');
			0 ignored issues – show Bug introduced 2016-02-23 23:20 UTC by Report Bug Copy Issue Report The property `noPriceProduct` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
27
28			//publish some products
29			$this->mp3player->publish('Stage', 'Live');
30			$this->socks->publish('Stage', 'Live');
31			$this->noPurchaseProduct->publish('Stage', 'Live');
32			$this->noPriceProduct->publish('Stage', 'Live');
33			//note that we don't publish 'tshirt'... we want it to remain in draft form.
34
35			$this->cart = ShoppingCart::singleton();

silvershop / silvershop-core

Pull Request — master (#482)

ShoppingCartControllerTest::testSecurityToken() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like