ShoppingCartTest::testErrorInCartHooks() - Code Metrics - Inspection of "Wrap all order extension hooks in try/catch blocks..." - silvershop/silvershop-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#557)

by Roman

created 2016-10-11 11:26 UTC

ShoppingCartTest::testErrorInCartHooks() A

↳ Parent: ShoppingCartTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	23
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	23
rs	9.0856
c	0
b	0
f	0
cc	1
eloc	16
nc	1
nop	0

<?php

class ShoppingCartTest extends SapphireTest
{
    public static $fixture_file   = 'silvershop/tests/fixtures/shop.yml';
    public static $disable_theme  = true;
    public static $use_draft_site = false;

    public function setUp()
    {
        parent::setUp();
        ShopTest::setConfiguration(); //reset config
        Config::inst()->update('Order', 'extensions', ['ShoppingCartTest_TestShoppingCartHooksExtension']);

        ShoppingCart::singleton()->clear();
        ShoppingCartTest_TestShoppingCartHooksExtension::reset();
        $this->cart = ShoppingCart::singleton();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->product = $this->objFromFixture('Product', 'mp3player');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->product->publish('Stage', 'Live');
    }

    public function testAddToCart()
    {
        $this->assertTrue((boolean)$this->cart->add($this->product), "add one item");

        $this->assertEquals(

            ['onStartOrder', 'beforeAdd', 'afterAdd'],
            ShoppingCartTest_TestShoppingCartHooksExtension::$stack
        );

        $this->assertTrue((boolean)$this->cart->add($this->product), "add another item");

        $this->assertEquals(

            ['onStartOrder', 'beforeAdd', 'afterAdd', 'beforeAdd', 'afterAdd'],
            ShoppingCartTest_TestShoppingCartHooksExtension::$stack
        );

        $item = $this->cart->get($this->product);
        $this->assertEquals($item->Quantity, 2, "quantity is 2");

    }

    public function testRemoveFromCart()
    {
        $this->assertTrue((boolean)$this->cart->add($this->product), "add item");

        $this->assertEquals(

            ['onStartOrder', 'beforeAdd', 'afterAdd'],
            ShoppingCartTest_TestShoppingCartHooksExtension::$stack
        );

        $this->assertTrue($this->cart->remove($this->product), "item was removed");

        $this->assertEquals(

            ['onStartOrder', 'beforeAdd', 'afterAdd', 'beforeRemove', 'afterRemove'],
            ShoppingCartTest_TestShoppingCartHooksExtension::$stack
        );
        $item = $this->cart->get($this->product);
        $this->assertFalse($item, "item not in cart");

        $this->assertFalse($this->cart->remove($this->product), "try remove non-existent item");

    }

    public function testSetQuantity()
    {
        $this->assertTrue((boolean)$this->cart->setQuantity($this->product, 25), "quantity set");


        $this->assertEquals(

            ['onStartOrder', 'beforeSetQuantity', 'afterSetQuantity'],
            ShoppingCartTest_TestShoppingCartHooksExtension::$stack
        );

        $item = $this->cart->get($this->product);
        $this->assertEquals($item->Quantity, 25, "quantity is 25");


    }

    public function testClear()
    {
        //$this->assertFalse($this->cart->current(),"there is no cart initally");
        $this->assertTrue((boolean)$this->cart->add($this->product), "add one item");

        $this->assertTrue((boolean)$this->cart->add($this->product), "add another item");

        $this->assertEquals($this->cart->current()->class, "Order", "there a cart");

        $this->assertTrue($this->cart->clear(), "clear the cart");

        $this->assertFalse($this->cart->current(), "there is no cart");

    }

    public function testProductVariations()
    {
        $this->loadFixture('silvershop/tests/fixtures/variations.yml');
        $ball1 = $this->objFromFixture('ProductVariation', 'redlarge');
        $ball2 = $this->objFromFixture('ProductVariation', 'redsmall');

        $this->assertTrue((boolean)$this->cart->add($ball1), "add one item");


        $this->assertEquals(

            ['onStartOrder', 'beforeAdd', 'afterAdd'],
            ShoppingCartTest_TestShoppingCartHooksExtension::$stack
        );

        $this->assertTrue((boolean)$this->cart->add($ball2), "add another item");

        $this->assertTrue($this->cart->remove($ball1), "remove first item");


        $this->assertEquals(

            ['onStartOrder', 'beforeAdd', 'afterAdd', 'beforeAdd', 'afterAdd', 'beforeRemove', 'afterRemove'],
            ShoppingCartTest_TestShoppingCartHooksExtension::$stack
        );

        $this->assertFalse($this->cart->get($ball1), "first item not in cart");

        $this->assertNotNull($this->cart->get($ball1), "second item is in cart");

    }

    public function testCartSingleton()
    {
        $this->assertTrue((boolean)$this->cart->add($this->product), "add one item");

        $order = $this->cart->current();

        $this->assertEquals($order->ID, ShoppingCart::curr()->ID, "if singleton order ids will match");

    }

    public function testAddProductWithVariations()
    {
        $this->loadFixture('silvershop/tests/fixtures/variations.yml');
        $ball = $this->objFromFixture('Product', 'ball');
        $redlarge = $this->objFromFixture('ProductVariation', 'redlarge');
        // setting price of variation to zero, so it can't be added to cart.
        $redlarge->Price = 0;
        $redlarge->write();

        $ball->BasePrice = 0;
        $ball->write();

        $item = $this->cart->add($ball);
        $this->assertNotNull($item, "Product with variations can be added to cart");

        $this->assertInstanceOf('ProductVariation_OrderItem', $item, 'A variation should be added to cart.');

        $this->assertEquals(20, $item->Buyable()->Price, 'The buyable variation was added');

    }

    public function testErrorInCartHooks()
    {
        Config::inst()->update('Order', 'extensions', ['ShoppingCartTest_TestShoppingCartErroringHooksExtension']);

        ShoppingCart::singleton()->clear();
        $cart = ShoppingCart::singleton();

        $this->assertTrue((boolean)$this->cart->add($this->product, 1), "add one item");

        $item = $cart->get($this->product);
        $this->assertFalse(

            (boolean)$this->cart->add($this->product, 1),
            "Cannot add more than one item, extension will error"
        );
        $this->assertEquals($item->Quantity, 1, "quantity is 1");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $this->assertTrue((boolean)$cart->setQuantity($this->product, 10), "quantity set");

        $item = $cart->get($this->product);
        $this->assertEquals($item->Quantity, 10, "quantity is 10");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $this->assertFalse((boolean)$cart->setQuantity($this->product, 11), "Cannot set quantity to more than 10 items");

        $item = $cart->get($this->product);
        $this->assertEquals($item->Quantity, 10, "quantity is 10");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}

class ShoppingCartTest_TestShoppingCartHooksExtension extends Extension implements TestOnly
{
    public static $stack = [];

    public static function reset()
    {
        self::$stack = [];
    }

    public function onStartOrder()
    {
        self::$stack[] = 'onStartOrder';
    }

    public function beforeAdd($buyable, $quantity, $filter)

    {
        self::$stack[] = 'beforeAdd';
    }

    public function afterAdd($item, $buyable, $quantity, $filter)

    {
        self::$stack[] = 'afterAdd';
    }

    public function beforeRemove($buyable, $quantity, $filter)

    {
        self::$stack[] = 'beforeRemove';
    }

    public function afterRemove($buyable, $quantity, $filter)

    {
        self::$stack[] = 'afterRemove';
    }

    public function beforeSetQuantity($buyable, $quantity, $filter)

    {
        self::$stack[] = 'beforeSetQuantity';
    }

    public function afterSetQuantity($item, $buyable, $quantity, $filter)

    {
        self::$stack[] = 'afterSetQuantity';
    }
}

class ShoppingCartTest_TestShoppingCartErroringHooksExtension extends Extension implements TestOnly
{
    public function beforeSetQuantity($buyable, $quantity, $filter)

    {
        if($quantity > 10) {
            throw new Exception('Invalid quantity');
        }
    }

    public function afterAdd($item, $buyable, $quantity, $filter)

    {
        if($item->Quantity > 1) {
            throw new Exception('Invalid quantity');
        }
    }
}



1			<?php
2
3			class ShoppingCartTest extends SapphireTest
4			{
5			public static $fixture_file = 'silvershop/tests/fixtures/shop.yml';
6			public static $disable_theme = true;
7			public static $use_draft_site = false;
8
9			public function setUp()
10			{
11			parent::setUp();
12			ShopTest::setConfiguration(); //reset config
13			Config::inst()->update('Order', 'extensions', ['ShoppingCartTest_TestShoppingCartHooksExtension']);
14
15			ShoppingCart::singleton()->clear();
16			ShoppingCartTest_TestShoppingCartHooksExtension::reset();
17			$this->cart = ShoppingCart::singleton();
			0 ignored issues – show Bug introduced 2016-02-23 23:20 UTC by Report Bug Copy Issue Report The property `cart` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
18			$this->product = $this->objFromFixture('Product', 'mp3player');
			0 ignored issues – show Bug introduced 2016-02-23 23:20 UTC by Report Bug Copy Issue Report The property `product` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19			$this->product->publish('Stage', 'Live');
20			}
21
22			public function testAddToCart()
23			{
24			$this->assertTrue((boolean)$this->cart->add($this->product), "add one item");
			0 ignored issues – show Bug introduced 2016-02-23 23:20 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<ShoppingCartTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
25			$this->assertEquals(
			0 ignored issues – show Bug introduced 2016-10-11 12:06 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<ShoppingCartTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
26			['onStartOrder', 'beforeAdd', 'afterAdd'],
27			ShoppingCartTest_TestShoppingCartHooksExtension::$stack
28			);
29
30			$this->assertTrue((boolean)$this->cart->add($this->product), "add another item");
			0 ignored issues – show Bug introduced 2016-02-23 23:20 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<ShoppingCartTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
31			$this->assertEquals(
			0 ignored issues – show Bug introduced 2016-10-11 12:06 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<ShoppingCartTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
32			['onStartOrder', 'beforeAdd', 'afterAdd', 'beforeAdd', 'afterAdd'],
33			ShoppingCartTest_TestShoppingCartHooksExtension::$stack
34			);

silvershop / silvershop-core

Pull Request — master (#557)

ShoppingCartTest::testErrorInCartHooks() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like