OrderStatusLogTest::testOrderStatusLogItemsWithMember() - Code Metrics - Inspection of "Only create an OrderStatusLog entry when the statu..." - silvershop/silvershop-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#545)

by Roman

created 2016-09-13 11:33 UTC

testOrderStatusLogItemsWithMember() B

↳ Parent: OrderStatusLogTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	173
Code Lines	129

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	173
rs	8.2857
c	0
b	0
f	0
cc	1
eloc	129
nc	1
nop	0

How to fix Long Method

<?php
/**
 * @link OrderStatusLog
 * @package shop_statuschangeemail
 * @subpackage tests
 */
class OrderStatusLogTest extends SapphireTest
{
    protected static $fixture_file = array(
        'silvershop/tests/fixtures/Orders.yml',
        'silvershop/tests/fixtures/ShopMembers.yml',
        'silvershop/tests/fixtures/Pages.yml'
    );

    public function setUp()
    {
        parent::setUp();
        ShopTest::setConfiguration();
        Config::inst()->update('Order', 'log_status', array('Processing', 'Sent', 'AdminCancelled', 'MemberCancelled'));
    }

    public function testOrderStatusLogItemsWithMember()
    {
        // start a new order
        $order = $this->objFromFixture("Order", "cart1");
        $member = $this->objFromFixture('Member', 'jeremyperemy');
        $order->MemberID = $member->ID;

        $no_log_generated_with_order_status_cart = OrderStatusLog::get()->sort('ID')->last();
        $this->assertNull(

            $no_log_generated_with_order_status_cart,
            "no log generated with Status of 'Cart'"
        );

        $order->Status = "Unpaid";
        $order->write();

        $no_log_generated_with_order_status_unpaid = OrderStatusLog::get()->sort('ID')->last();
        $this->assertNull(

            $no_log_generated_with_order_status_unpaid,
            "no log generated with Status of 'Unpaid'"
        );

        $processor = OrderProcessor::create($order);

        $response = $processor->makePayment("Manual", array());
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $order->Status = "Paid";
        $order->write();

        $log_order_status_paid = OrderStatusLog::get()->sort('ID')->last();
        $this->assertNull(

            $log_order_status_paid,
            "no log generated with Status of 'Unpaid'"
        );

        $order->Status = "Processing";
        $order->write();

        $log_order_status_processing = OrderStatusLog::get()->sort('ID')->last();
        $this->assertEquals(OrderStatusLog::get()->count(), '1', "One items in the OrderStatusLog");

        $this->assertNotNull(

            $log_order_status_processing,
            "a log when changing to 'Processing' status (and PaymentMethod is 'Manual')"
        );
        $this->assertSame(

            $log_order_status_processing->Order()->ID,
            $order->ID,
            "Log conatins an Order"
        );

        $this->assertContains(
            "Processing",
            $log_order_status_processing->Note,
            "Processing note is recorded"
        );
        $this->assertContains(
            'changed to "Processing"',
            $log_order_status_processing->Title,
            'Processing title is recorded'
        );
        $this->assertEmailSent(
            '[email protected]',
            '[email protected]',
            _t('ShopEmail.StatusChangeSubject') . $log_order_status_processing->Title
        );
        $order->Status = "Sent";
        $order->write();

        $log_order_status_sent = OrderStatusLog::get()->sort('ID')->last();
        $this->assertEquals(

            OrderStatusLog::get()->count(),
            '2',
            "Three items in the OrderStatusLog"
        );
        $this->assertNotNull(

            $log_order_status_sent,
            "an log should be recorded when an order's status is changed to 'Sent' (and PaymentMethod is 'Manual')"
        );
        $this->assertSame(

            $log_order_status_sent->Order()->ID,
            $order->ID,
            "Log conatins an Order"
        );
        $this->assertContains(
            "sent",
            $log_order_status_sent->Note,
            "Sent note is recorded"
        );
        $this->assertContains(
            'changed to "Sent"',
            $log_order_status_sent->Title,
            "Sent title is recorded"
        );

        $this->assertEmailSent(
            "[email protected]",
            "[email protected]",
            _t('ShopEmail.StatusChangeSubject') . $log_order_status_sent->Title
        );

        $order->Status = "Complete";
        $order->write();
        $this->assertEquals(

            OrderStatusLog::get()->count(),
            '2',
            "Additional item in the OrderStatusLog has not been created"
        );

        $order->Status = "AdminCancelled";
        $order->write();

        $log_order_status_admin_cancelled = OrderStatusLog::get()->sort('ID')->last();
        $this->assertEquals(

            OrderStatusLog::get()->count(),
            '3',
            "Three items in the OrderStatusLog"
        );
        $this->assertNotNull(

            $log_order_status_admin_cancelled,
            "a log should be recorded with change to 'Admin Cancelled' status (and PaymentMethod is 'Manual')"
        );
        $this->assertSame(

            $log_order_status_admin_cancelled->Order()->ID,
            $order->ID,
            "Log conatins an Order"
        );
        $this->assertContains(
            "cancelled",
            $log_order_status_admin_cancelled->Note,
            "Admin Cancelled note is recorded"
        );
        $this->assertContains(
            'changed to "Cancelled by admin"',
            $log_order_status_admin_cancelled->Title,
            "Admin Cancelled title is recorded"
        );
        $this->assertEmailSent(
            "[email protected]",
            "[email protected]",
            _t('ShopEmail.StatusChangeSubject') . $log_order_status_admin_cancelled->Title
        );

        $order->Status = "MemberCancelled";
        $order->write();
        $log_order_status_member_cancelled = OrderStatusLog::get()->sort('ID')->last();
        $this->assertEquals(

            OrderStatusLog::get()->count(),
            '4',
            "Four items in the OrderStatusLog"
        );
        $this->assertNotNull(

            $log_order_status_member_cancelled,
            "a log should be recorded for change to 'Member Cancelled' status (and PaymentMethod is 'Manual')"
        );
        $this->assertSame(

            $log_order_status_member_cancelled->Order()->ID,
            $order->ID,
            "Log conatins an Order"
        );
        $this->assertSame(

            "Your cancellation of the order has been noted.  Please contact us if you have any questions.",
            $log_order_status_member_cancelled->Note,
            "Member Cancelled note is recorded"
        );
        $this->assertContains(
            ' changed to "Cancelled by member"',
            $log_order_status_member_cancelled->Title,
            "Member Cancelled title is recorded"
        );
        $this->assertEmailSent(
            '[email protected]',
            '[email protected]',
            _t('ShopEmail.StatusChangeSubject') . $log_order_status_member_cancelled->Title
        );
    }

    public function testEmailSentOnce()
    {
        $order = $this->objFromFixture("Order", "cart1");
        $member = $this->objFromFixture('Member', 'jeremyperemy');
        $order->MemberID = $member->ID;

        $order->Status = 'Processing';
        $order->write();

        $logEntry = OrderStatusLog::get()->sort('ID')->last();

        $this->assertEquals(

            OrderStatusLog::get()->count(),
            1,
            "An item has been added to the status-log"
        );

        $this->assertEmailSent(
            '[email protected]',
            '[email protected]',
            _t('ShopEmail.StatusChangeSubject') . $logEntry->Title
        );

        // clear sent emails
        $this->mailer->clearEmails();

        // force another write on the order
        $order->Notes = 'Random Test Notes';
        $order->write();

        // Status hasn't changed, so there should be just one log entry still
        $this->assertEquals(

            OrderStatusLog::get()->count(),
            1,
            "An item has been added to the status-log"
        );

        $this->assertFalse(

            (bool)$this->findEmail('[email protected]', '[email protected]'),
            'No additional email should be sent'
        );

        // Try re-writing the Log entry
        $logEntry->Note = 'Some random notes';
        $logEntry->write();

        $this->assertFalse(

            (bool)$this->findEmail('[email protected]', '[email protected]'),
            'No additional email should be sent'
        );
    }

    public function testOrderPlacedByGuest()
    {
        // start a new order
        $order = $this->objFromFixture("Order", "cart1");
        $order->FirstName = "Edmund";
        $order->Surname = "Hillary";
        $order->Email = "[email protected]";
        $order->Status = "Unpaid";
        $order->write();

        $no_log_generated_with_order_status_unpaid = OrderStatusLog::get()->sort('ID')->last();
        $this->assertNull(

            $no_log_generated_with_order_status_unpaid,
            "no log generated with Status of 'Unpaid'"
        );

        $processor_guest = OrderProcessor::create($order);

        $response = $processor_guest->makePayment("Manual", array());
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $order->Status = "Paid";
        $order->write();

        $log_order_status_paid = OrderStatusLog::get()->sort('ID')->last();
        $this->assertNull(

            $log_order_status_paid,
            "no log generated with Status of 'Unpaid'"
        );

        $order->Status = "Processing";
        $order->write();

        $log_order_status_processing = OrderStatusLog::get()->sort('ID')->last();
        $this->assertEquals(OrderStatusLog::get()->count(), '1', "One items in the OrderStatusLog");

        $this->assertNotNull(

            $log_order_status_processing,
            "a log when changing to 'Processing' status (and PaymentMethod is 'Manual')"
        );
        $this->assertSame(

            $log_order_status_processing->Order()->ID,
            $order->ID,
            "Log conatins an Order"
        );

        $this->assertContains(
            "Processing",
            $log_order_status_processing->Note,
            "Processing note is recorded"
        );
        $this->assertContains(
            ' changed to "Processing"',
            $log_order_status_processing->Title,
            "Processing title is recorded"
        );
        $this->assertEmailSent(
            "[email protected]",
            "[email protected]",
            _t('ShopEmail.StatusChangeSubject') . $log_order_status_processing->Title
        );
    }
}


1			<?php
2			/**
3			* @link OrderStatusLog
4			* @package shop_statuschangeemail
5			* @subpackage tests
6			*/
7			class OrderStatusLogTest extends SapphireTest
8			{
9			protected static $fixture_file = array(
10			'silvershop/tests/fixtures/Orders.yml',
11			'silvershop/tests/fixtures/ShopMembers.yml',
12			'silvershop/tests/fixtures/Pages.yml'
13			);
14
15			public function setUp()
16			{
17			parent::setUp();
18			ShopTest::setConfiguration();
19			Config::inst()->update('Order', 'log_status', array('Processing', 'Sent', 'AdminCancelled', 'MemberCancelled'));
20			}
21
22			public function testOrderStatusLogItemsWithMember()
23			{
24			// start a new order
25			$order = $this->objFromFixture("Order", "cart1");
26			$member = $this->objFromFixture('Member', 'jeremyperemy');
27			$order->MemberID = $member->ID;
28
29			$no_log_generated_with_order_status_cart = OrderStatusLog::get()->sort('ID')->last();
30			$this->assertNull(
			0 ignored issues – show Bug introduced 2016-08-04 07:10 UTC by Report Bug Copy Issue Report The method `assertNull()` does not seem to exist on `object<OrderStatusLogTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
31			$no_log_generated_with_order_status_cart,
32			"no log generated with Status of 'Cart'"
33			);
34
35			$order->Status = "Unpaid";
36			$order->write();
37
38			$no_log_generated_with_order_status_unpaid = OrderStatusLog::get()->sort('ID')->last();
39			$this->assertNull(

silvershop / silvershop-core

Pull Request — master (#545)

testOrderStatusLogItemsWithMember() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like