silvershop / silvershop-core

tests/php/Admin/ProductBulkLoaderTest.php

<?php

namespace SilverShop\Tests\Admin;

use SilverShop\Admin\ProductBulkLoader;
use SilverShop\Page\Product;
use SilverStripe\Dev\FunctionalTest;

class ProductBulkLoaderTest extends FunctionalTest
{
    public static $fixture_file   = __DIR__ . '/../Fixtures/shop.yml';
    public static $disable_theme  = true;
    protected static $use_draft_site = true;

    public function testLoad()
    {
        $loader = new ProductBulkLoader(Product::class);

        $ds = DIRECTORY_SEPARATOR;
        $filepath = realpath(__DIR__ . $ds . 'test_products.csv');
        $file = fopen($filepath, 'r');

        fgetcsv($file); // pop header row

It seems like $file can also be of type false; however, parameter $handle of fgetcsv() does only seem to accept resource, maybe add an additional type check?

        $compareRow = fgetcsv($file);

The assignment to $compareRow is dead and can be removed.

        $results = $loader->load($filepath);

The assignment to $results is dead and can be removed.

        // Test that right amount of columns was imported
        //$this->assertEquals(4, $results->Count(), 'Test correct count of imported data');

        // Test that columns were correctly imported
        $obj = Product::get()->filter('Title', 'Socks')->first();
        $this->assertNotNull($obj, "New product exists");
        $this->assertEquals("<p>The comfiest pair of socks you'll ever own.</p>", $obj->Content, "Content matches");
        $this->assertEquals(12, $obj->BasePrice, "Checking price matches.");
        //$this->assertEquals(124, $obj->ID,"Checking ID matches");

        fclose($file);

It seems like $file can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

        $this->markTestIncomplete('Incomplete');
    }
}