OrderModifierTest::testModifierFailure() - Code Metrics - Inspection of "Merge pull request #729 from shoosah/bugfix/config..." - silvershop/silvershop-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3c661d...2a57f9 )

by Will

created 2019-11-22 02:31 UTC

OrderModifierTest::testModifierFailure() A

↳ Parent: OrderModifierTest

Complexity

Conditions	5
Paths	16

Size

Total Lines	54
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	5
eloc	29
c	2
b	0
f	0
nc	16
nop	0
dl	0
loc	54
rs	9.1448

How to fix Long Method

<?php

namespace SilverShop\Tests\Model\Modifiers;

use Exception;
use SilverShop\Model\Modifiers\Tax\FlatTax;
use SilverShop\Model\Order;
use SilverShop\Model\OrderModifier;
filter:
    dependency_paths: ["lib/*"]
use SilverShop\Page\Product;
use SilverShop\Tests\Model\Product\CustomProduct_OrderItem;
use SilverShop\Tests\ShopTest;
use SilverStripe\Core\Config\Config;
use SilverStripe\Dev\FunctionalTest;
use SilverStripe\ORM\DB;

/**
 * @package    shop
 * @subpackage tests
 */
class OrderModifierTest extends FunctionalTest
{
    public static $fixture_file = __DIR__ . '/../../Fixtures/shop.yml';
    public static $disable_theme = true;
    protected static $use_draft_site = true;

    /**
     * @var Product
     */
    protected $mp3player;

    /**
     * @var Product
     */
    protected $socks;

    protected static $extra_dataobjects = [
        CustomProduct_OrderItem::class,
        OrderModifierTest_TestModifier::class
    ];

    public function setUp()
    {
        parent::setUp();
        ShopTest::setConfiguration();

        Config::modify()
            ->set(
                Order::class,
                'modifiers',
                [
                    FlatTax::class
                ]
            )
            ->set(FlatTax::class, 'rate', 0.25)
            ->set(FlatTax::class, 'name', 'GST');


        $this->logInWithPermission('ADMIN');
        $this->mp3player = $this->objFromFixture(Product::class, 'mp3player');

        $this->socks = $this->objFromFixture(Product::class, 'socks');

        $this->mp3player->publishSingle();
        $this->socks->publishSingle();
    }

    public function testModifierCalculation()
    {
        $order = $this->createOrder();
        $this->assertEquals(510, $order->calculate(), "Total with 25% tax");

        //remove modifiers
        Order::config()->modifiers = null;
        $order->calculate();
        $this->assertEquals(408, $order->calculate(), "Total with no modification");
    }

    public function testModifierFailure()
    {
        if (!DB::get_conn()->supportsTransactions()) {
            $this->markTestSkipped(
                'The Database doesn\'t support transactions.'
            );
        }

        Config::modify()->set(
            Order::class,
            'modifiers',
            [
                OrderModifierTest_TestModifier::class,
                FlatTax::class
            ]
        );

        $order = $this->createOrder();
        $order->calculate();
        $order->write();

        // 408 from items + 10 from modifier + 25% from tax
        $this->assertEquals('522.5', $order->Total);

        $amounts = array();
        foreach ($order->Modifiers()->sort('Sort') as $modifier) {
            $amounts[] = (string)$modifier->Amount;
        }

        $this->assertEquals(array('10', '104.5'), $amounts);

        OrderModifierTest_TestModifier::$value = 42;

        try {
            // Calculate will now fail!
            $order->calculate();
        } catch (Exception $e) {

        }

        // reload order from DB
        $order = Order::get()->byID($order->ID);

        // Order Total should not have changed
        $this->assertEquals('522.5', $order->Total);

        $amounts = array();
        foreach ($order->Modifiers()->sort('Sort') as $modifier) {
            $amounts[] = (string)$modifier->Amount;
        }

        $this->assertEquals(
            array('10', '104.5'),
            $amounts,
            'Modifiers aren\'t allowed to change upon failure'
        );
    }

    public function createOrder()
    {
        $order = new Order();
        $order->write();
        $item1a = $this->mp3player->createItem(2);
        $item1a->write();
        $order->Items()->add($item1a);
        $item1b = $this->socks->createItem();
        $item1b->write();
        $order->Items()->add($item1b);
        return $order;
    }
}


1			<?php
2
3			namespace SilverShop\Tests\Model\Modifiers;
4
5			use Exception;
6			use SilverShop\Model\Modifiers\Tax\FlatTax;
7			use SilverShop\Model\Order;
8			use SilverShop\Model\OrderModifier;
			0 ignored issues – show Bug introduced 2018-02-08 22:43 UTC by Report Bug Copy Issue Report The type `SilverShop\Model\OrderModifier` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
9			use SilverShop\Page\Product;
10			use SilverShop\Tests\Model\Product\CustomProduct_OrderItem;
11			use SilverShop\Tests\ShopTest;
12			use SilverStripe\Core\Config\Config;
13			use SilverStripe\Dev\FunctionalTest;
14			use SilverStripe\ORM\DB;
15
16			/**
17			* @package shop
18			* @subpackage tests
19			*/
20			class OrderModifierTest extends FunctionalTest
21			{
22			public static $fixture_file = __DIR__ . '/../../Fixtures/shop.yml';
23			public static $disable_theme = true;
24			protected static $use_draft_site = true;
25
26			/**
27			* @var Product
28			*/
29			protected $mp3player;
30
31			/**
32			* @var Product
33			*/
34			protected $socks;
35
36			protected static $extra_dataobjects = [
37			CustomProduct_OrderItem::class,
38			OrderModifierTest_TestModifier::class
39			];
40
41			public function setUp()
42			{
43			parent::setUp();
44			ShopTest::setConfiguration();
45
46			Config::modify()
47			->set(
48			Order::class,
49			'modifiers',
50			[
51			FlatTax::class
52			]
53			)
54			->set(FlatTax::class, 'rate', 0.25)
55			->set(FlatTax::class, 'name', 'GST');
56
57
58			$this->logInWithPermission('ADMIN');
59			$this->mp3player = $this->objFromFixture(Product::class, 'mp3player');
			0 ignored issues – show Documentation Bug introduced 2018-08-05 20:37 UTC by Report Bug Copy Issue Report It seems like `$this->objFromFixture(Si...ct::class, 'mp3player')` of type `SilverStripe\ORM\DataObject` is incompatible with the declared type `SilverShop\Page\Product` of property `$mp3player`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
60			$this->socks = $this->objFromFixture(Product::class, 'socks');
			0 ignored issues – show Documentation Bug introduced 2018-08-05 20:37 UTC by Report Bug Copy Issue Report It seems like `$this->objFromFixture(Si...roduct::class, 'socks')` of type `SilverStripe\ORM\DataObject` is incompatible with the declared type `SilverShop\Page\Product` of property `$socks`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
61			$this->mp3player->publishSingle();
62			$this->socks->publishSingle();
63			}
64
65			public function testModifierCalculation()
66			{
67			$order = $this->createOrder();
68			$this->assertEquals(510, $order->calculate(), "Total with 25% tax");
69
70			//remove modifiers
71			Order::config()->modifiers = null;
72			$order->calculate();
73			$this->assertEquals(408, $order->calculate(), "Total with no modification");
74			}
75
76			public function testModifierFailure()
77			{
78			if (!DB::get_conn()->supportsTransactions()) {
79			$this->markTestSkipped(
80			'The Database doesn\'t support transactions.'
81			);
82			}
83
84			Config::modify()->set(
85			Order::class,
86			'modifiers',
87			[
88			OrderModifierTest_TestModifier::class,
89			FlatTax::class
90			]
91			);
92
93			$order = $this->createOrder();
94			$order->calculate();
95			$order->write();
96
97			// 408 from items + 10 from modifier + 25% from tax
98			$this->assertEquals('522.5', $order->Total);
99
100			$amounts = array();
101			foreach ($order->Modifiers()->sort('Sort') as $modifier) {
102			$amounts[] = (string)$modifier->Amount;
103			}
104
105			$this->assertEquals(array('10', '104.5'), $amounts);
106
107			OrderModifierTest_TestModifier::$value = 42;
108
109			try {
110			// Calculate will now fail!
111			$order->calculate();
112			} catch (Exception $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-08 22:43 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
113			}
114
115			// reload order from DB
116			$order = Order::get()->byID($order->ID);
117
118			// Order Total should not have changed
119			$this->assertEquals('522.5', $order->Total);
120
121			$amounts = array();
122			foreach ($order->Modifiers()->sort('Sort') as $modifier) {
123			$amounts[] = (string)$modifier->Amount;
124			}
125
126			$this->assertEquals(
127			array('10', '104.5'),
128			$amounts,
129			'Modifiers aren\'t allowed to change upon failure'
130			);
131			}
132
133			public function createOrder()
134			{
135			$order = new Order();
136			$order->write();
137			$item1a = $this->mp3player->createItem(2);
138			$item1a->write();
139			$order->Items()->add($item1a);
140			$item1b = $this->socks->createItem();
141			$item1b->write();
142			$order->Items()->add($item1b);
143			return $order;
144			}
145			}
146

silvershop / silvershop-core

Push — master ( 3c661d...2a57f9 )

OrderModifierTest::testModifierFailure() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like