AddressTest::testRequiredFields() - Code Metrics - Inspection of "Merge pull request #729 from shoosah/bugfix/config..." - silvershop/silvershop-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3c661d...2a57f9 )

by Will

created 2019-11-22 02:31 UTC

AddressTest::testRequiredFields() A

↳ Parent: AddressTest

Complexity

Conditions	3
Paths	4

Size

Total Lines	40
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	23
c	1
b	0
f	0
nc	4
nop	0
dl	0
loc	40
rs	9.552

<?php

namespace SilverShop\Tests\Model;

use SilverShop\Model\Address;
use SilverStripe\Dev\SapphireTest;
use Exception;

class AddressTest extends SapphireTest
{
    public function testForm()
    {
        $address = Address::create()->update(
            [
                'Country' => 'NZ',
                'State' => 'Wellington',
                'City' => 'TeAro',
                'PostalCode' => '1333',
                'Address' => '23 Blah Street',
                'AddressLine2' => 'Fitzgerald Building, Foor 3',
                'Company' => 'Ink inc',
                'FirstName' => 'Jerald',
                'Surname' => 'Smith',
                'Phone' => '12346678',
            ]
        );

        $fields = $address->getFrontEndFields();

        $requiremetns = $address->getRequiredFields();

        $this->assertEquals(
            "Ink inc|Jerald Smith|23 Blah Street|Fitzgerald Building, Foor 3|TeAro|Wellington|1333|NZ",
            $address->toString("|")
        );
    }

    public function testRequiredFields()
    {
        // create address instance that lacks some required fields (Address)
        $address = Address::create()->update(
            [
                'Country' => 'NZ',
                'State' => 'Wellington',
                'City' => 'TeAro',
            ]
        );

        $writeFailed = false;
        try {
            $address->write();
        } catch (Exception $ex) {
            $writeFailed = true;
        }

        $this->assertTrue($writeFailed, "Address should not be writable, since it doesn't contain all required fields");

        // Create an Address that satisfies the baseline required fields, but not the ones that were added via subclass.
        $address = ExtendedTestAddress::create()->update(
            [
                'Country' => 'NZ',
                'State' => 'Wellington',
                'City' => 'TeAro',
                'Address' => '23 Blah Street',
            ]
        );

        $writeFailed = false;
        try {
            $address->write();
        } catch (Exception $ex) {
            $writeFailed = true;
        }

        $this->assertTrue(
            $writeFailed,
            "Address should not be writable, since it doesn't contain required fields added via subclass"
        );
    }
}


1			<?php
2
3			namespace SilverShop\Tests\Model;
4
5			use SilverShop\Model\Address;
6			use SilverStripe\Dev\SapphireTest;
7			use Exception;
8
9			class AddressTest extends SapphireTest
10			{
11			public function testForm()
12			{
13			$address = Address::create()->update(
14			[
15			'Country' => 'NZ',
16			'State' => 'Wellington',
17			'City' => 'TeAro',
18			'PostalCode' => '1333',
19			'Address' => '23 Blah Street',
20			'AddressLine2' => 'Fitzgerald Building, Foor 3',
21			'Company' => 'Ink inc',
22			'FirstName' => 'Jerald',
23			'Surname' => 'Smith',
24			'Phone' => '12346678',
25			]
26			);
27
28			$fields = $address->getFrontEndFields();
			0 ignored issues – show Unused Code introduced 2018-02-04 17:27 UTC by Report Bug Copy Issue Report The assignment to `$fields` is dead and can be removed. Loading history...
29			$requiremetns = $address->getRequiredFields();
			0 ignored issues – show Unused Code introduced 2018-02-04 17:27 UTC by Report Bug Copy Issue Report The assignment to `$requiremetns` is dead and can be removed. Loading history...
30			$this->assertEquals(
31			"Ink inc\|Jerald Smith\|23 Blah Street\|Fitzgerald Building, Foor 3\|TeAro\|Wellington\|1333\|NZ",
32			$address->toString("\|")
33			);
34			}
35
36			public function testRequiredFields()
37			{
38			// create address instance that lacks some required fields (Address)
39			$address = Address::create()->update(
40			[
41			'Country' => 'NZ',
42			'State' => 'Wellington',
43			'City' => 'TeAro',
44			]
45			);
46
47			$writeFailed = false;
48			try {
49			$address->write();
50			} catch (Exception $ex) {
51			$writeFailed = true;
52			}
53
54			$this->assertTrue($writeFailed, "Address should not be writable, since it doesn't contain all required fields");
55
56			// Create an Address that satisfies the baseline required fields, but not the ones that were added via subclass.
57			$address = ExtendedTestAddress::create()->update(
58			[
59			'Country' => 'NZ',
60			'State' => 'Wellington',
61			'City' => 'TeAro',
62			'Address' => '23 Blah Street',
63			]
64			);
65
66			$writeFailed = false;
67			try {
68			$address->write();
69			} catch (Exception $ex) {
70			$writeFailed = true;
71			}
72
73			$this->assertTrue(
74			$writeFailed,
75			"Address should not be writable, since it doesn't contain required fields added via subclass"
76			);
77			}
78			}
79

silvershop / silvershop-core

Push — master ( 3c661d...2a57f9 )

AddressTest::testRequiredFields() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like