SilverShop\Tasks\CustomersToGroupTask::run()

Complexity

Conditions	6
Paths	7

Size

Total Lines	35
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function run($request)
    {

        $gp = ShopConfigExtension::current()->CustomerGroup();
        if (empty($gp)) {
            return false;
        }

        $allCombos = DB::query(
            'SELECT "ID", "MemberID", "GroupID" FROM "Group_Members" WHERE "Group_Members"."GroupID" = '
            . $gp->ID . ';'
        );
        //make an array of all combos
        $alreadyAdded = array();
        $alreadyAdded[-1] = -1;
        if ($allCombos) {

$allCombos is of type SilverStripe\ORM\Connect\Query, thus it always evaluated to true.

            foreach ($allCombos as $combo) {
                $alreadyAdded[$combo['MemberID']] = $combo['MemberID'];
            }
        }
        $unlistedMembers = DataObject::get(
            Member::class,
            $where = '"Member"."ID" NOT IN (' . implode(',', $alreadyAdded) . ')',
            $sort = null,
            $join = 'INNER JOIN "SilverShop_Order" ON "SilverShop_Order"."MemberID" = "Member"."ID"'
        );
        //add combos
        if ($unlistedMembers) {

$unlistedMembers is of type SilverStripe\ORM\DataList, thus it always evaluated to true.

            $existingMembers = $gp->Members();
            foreach ($unlistedMembers as $member) {
                $existingMembers->add($member);
                echo '.';
            }
        } else {
            echo 'no new members added';
        }