SilverShop\Admin\OrdersAdmin

Complexity

Total Complexity

5

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Importance

Changes	4
Bugs	1	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getEditForm()	0	31	3
A	getList()	0	11	2

<?php

namespace SilverShop\Admin;

use SilverShop\Forms\GridField\OrderGridFieldDetailForm_ItemRequest;
use SilverShop\Model\Order;
use SilverShop\Model\OrderStatusLog;
use SilverStripe\Admin\ModelAdmin;
use SilverStripe\Forms\GridField\GridFieldAddNewButton;
use SilverStripe\Forms\GridField\GridFieldDetailForm;
use SilverStripe\Forms\GridField\GridFieldSortableHeader;
use SilverStripe\ORM\DataObject;

/**
 * Order administration interface, based on ModelAdmin
 *
 * @package SilverShop\Admin
 */
class OrdersAdmin extends ModelAdmin
{
    private static $url_segment = 'orders';

The private property $url_segment is not used, and could be removed.

    private static $menu_title = 'Orders';

The private property $menu_title is not used, and could be removed.

    private static $menu_priority = 1;

The private property $menu_priority is not used, and could be removed.

    private static $menu_icon_class = 'silvershop-icon-cart';

The private property $menu_icon_class is not used, and could be removed.

    private static $managed_models = [

The private property $managed_models is not used, and could be removed.

        Order::class,
        OrderStatusLog::class
    ];

    private static $model_importers = [];

The private property $model_importers is not used, and could be removed.

    /**
     * Restrict list to non-hidden statuses
     */
    public function getList()
    {
        $list = parent::getList();

        if ($this->modelClass == Order::class) {
            // Exclude hidden statuses
            $list = $list->exclude('Status', Order::config()->hidden_status);
            $this->extend('updateList', $list);
        }

        return $list;
    }

    /**
     * Replace gridfield detail form to include print functionality
     */
    public function getEditForm($id = null, $fields = null)
    {
        $form = parent::getEditForm($id, $fields);
        if ($this->modelClass == Order::class) {
            /** @var GridFieldConfig $config */
            $config = $form

Are you sure the usage of $form->Fields()->fieldByName($this->sanitiseClassName($this->modelClass)) targeting SilverStripe\Forms\FieldList::fieldByName() seems to always return null.

                ->Fields()
                ->fieldByName($this->sanitiseClassName($this->modelClass))
                ->getConfig();

            $config
                ->getComponentByType(GridFieldSortableHeader::class)
                ->setFieldSorting([ 'StatusI18N' => 'Status' ]);

            $config
                ->getComponentByType(GridFieldDetailForm::class)
                ->setItemRequestClass(OrderGridFieldDetailForm_ItemRequest::class); //see below
        }

        if ($this->modelClass == OrderStatusLog::class) {
            /** @var GridFieldConfig $config */
            $config = $form

Are you sure the usage of $form->Fields()->fieldByName($this->sanitiseClassName($this->modelClass)) targeting SilverStripe\Forms\FieldList::fieldByName() seems to always return null.

                ->Fields()
                ->fieldByName($this->sanitiseClassName($this->modelClass))
                ->getConfig();

            // Remove add new button
            $config->removeComponentsByType($config->getComponentByType(GridFieldAddNewButton::class));
        }

        return $form;
    }
}