SilverLeague\LogViewer\Tests\Deprecated\DeprecatedLogFormatterTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	128
Duplicated Lines	6.25 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	testFormatLegacyEntry()	0	42	1
B	testCreateLegacyEntry()	0	31	1
A	testExtractValues()	0	21	1
A	invokeMethod()	8	8	1

<?php

namespace SilverLeague\LogViewer\Tests\Deprecated;

use ReflectionClass;
use SilverLeague\LogViewer\Helper\DeprecatedLogFormatter;
use SilverStripe\Dev\SapphireTest;

/**
 * @author Simon Erkelens <simon@casa-laguna.net>
 */
class DeprecatedLogFormatterTest extends SapphireTest
{

    /**
     * Check if old entries go through the entire precess neatly
     */
    public function testFormatLegacyEntry()
    {
        $arrayEntry = 'E_WARNING: Invalid argument supplied for foreach() {"code":2,"message":"Invalid argument ' .
            'supplied for foreach()","file":"/data/site/docroot/logviewer/src/Model/LogEntry.php","line":89} []';

        $result = DeprecatedLogFormatter::formatLegacyEntry($arrayEntry);
        $expectedJSON = 'E_WARNING: Invalid argument supplied for foreach(): <span style="color: #007700">[</span>' .
            '<ul style="margin-bottom: 0"><li class="list-unstyled"><span style="color: #0000BB">code</span>' .
            '<span style="color: #007700">: </span><span style="color: #DD0000">2</span></li>' .
            '<li class="list-unstyled"><span style="color: #0000BB">message</span>' .
            '<span style="color: #007700">: </span>' .
            '<span style="color: #DD0000">Invalid argument supplied for foreach()</span></li>' .
            '<li class="list-unstyled"><span style="color: #0000BB">file</span><span style="color: #007700">: </span>' .
            '<span style="color: #DD0000">/data/site/docroot/logviewer/src/Model/LogEntry.php</span></li>' .
            '<li class="list-unstyled"><span style="color: #0000BB">line</span><span style="color: #007700">: </span>' .
            '<span style="color: #DD0000">89</span></li></ul><span style="color: #007700">]</span>' .
            "\n" .
            'Other: <span style="color: #007700">[</span><ul style="margin-bottom: 0"></ul>' .
            '<span style="color: #007700">]</span>';
        $this->assertEquals($expectedJSON, $result);

        $stringEntry = 'E_WARNING: Invalid argument supplied for foreach() {"code":2,"message":"Invalid argument ' .
            'supplied for foreach()","file":"/data/site/docroot/logviewer/src/Model/LogEntry.php","line":89} OOPS';

        $result = DeprecatedLogFormatter::formatLegacyEntry($stringEntry);
        $expectedString = 'E_WARNING: Invalid argument supplied for foreach(): <span style="color: #007700">[</span>' .
            '<ul style="margin-bottom: 0"><li class="list-unstyled"><span style="color: #0000BB">code</span>' .
            '<span style="color: #007700">: </span><span style="color: #DD0000">2</span></li>' .
            '<li class="list-unstyled"><span style="color: #0000BB">message</span>' .
            '<span style="color: #007700">: </span>' .
            '<span style="color: #DD0000">Invalid argument supplied for foreach()</span></li>' .
            '<li class="list-unstyled"><span style="color: #0000BB">file</span><span style="color: #007700">: </span>' .
            '<span style="color: #DD0000">/data/site/docroot/logviewer/src/Model/LogEntry.php</span></li>' .
            '<li class="list-unstyled"><span style="color: #0000BB">line</span><span style="color: #007700">: </span>' .
            '<span style="color: #DD0000">89</span></li></ul><span style="color: #007700">]</span>' .
            "\nOther:\n OOPS";
        $this->assertEquals($expectedString, $result);

        $noJsonEntry = "We're making water!";
        $result = DeprecatedLogFormatter::formatLegacyEntry($noJsonEntry);
        $this->assertEquals('<p>' . $noJsonEntry . '</p>', $result);
    }

    /**
     * Check if the entries are created correctly from array.
     */
    public function testCreateLegacyEntry()
    {
        $entry = 'E_WARNING: Invalid argument supplied for foreach() {"code":2,"message":"Invalid argument ' .
            'supplied for foreach()","file":"/data/site/docroot/logviewer/src/Model/LogEntry.php","line":89} []';
        $entryArray = [
            0 =>
                [
                    0 => '{"code":2,"message":"Invalid argument supplied for foreach()","file":"/data/site/docroot/logviewer/src/Model/LogEntry.php","line":89} ',
                ],
            1 =>
                [
                    0 => '{"code":2,"message":"Invalid argument supplied for foreach()","file":"/data/site/docroot/logviewer/src/Model/LogEntry.php","line":89}',
                ],
        ];
        $expectedResult = 'E_WARNING: Invalid argument supplied for foreach(): <span style="color: #007700">[</span>' .
            '<ul style="margin-bottom: 0"><li class="list-unstyled"><span style="color: #0000BB">code</span>' .
            '<span style="color: #007700">: </span><span style="color: #DD0000">2</span></li>' .
            '<li class="list-unstyled"><span style="color: #0000BB">message</span>' .
            '<span style="color: #007700">: </span>' .
            '<span style="color: #DD0000">Invalid argument supplied for foreach()</span></li>' .
            '<li class="list-unstyled"><span style="color: #0000BB">file</span><span style="color: #007700">: </span>' .
            '<span style="color: #DD0000">/data/site/docroot/logviewer/src/Model/LogEntry.php</span></li>' .
            '<li class="list-unstyled"><span style="color: #0000BB">line</span><span style="color: #007700">: </span>' .
            '<span style="color: #DD0000">89</span></li></ul><span style="color: #007700">]</span>' .
            "\n" .
            'Other: <span style="color: #007700">[</span><ul style="margin-bottom: 0"></ul>' .
            '<span style="color: #007700">]</span>';
        $formatter = new DeprecatedLogFormatter();

The class SilverLeague\LogViewer\Helper\DeprecatedLogFormatter has been deprecated.

        $result = $this->invokeMethod($formatter, 'createLegacyEntry', array($entryArray, $entry, ''));
        $this->assertEquals($expectedResult, $result);
    }

    /**
     * Test if the JSON data is extracted correctly
     */
    public function testExtractValues()
    {
        $entry = 'E_WARNING: Invalid argument supplied for foreach() {"code":2,"message":"Invalid argument ' .
            'supplied for foreach()","file":"/data/site/docroot/logviewer/src/Model/LogEntry.php","line":89} []';
        $match = '{"code":2,"message":"Invalid argument supplied for foreach()","file":"/data/site/' .
            'docroot/logviewer/src/Model/LogEntry.php","line":89} ';
        $formatter = new DeprecatedLogFormatter();

The class SilverLeague\LogViewer\Helper\DeprecatedLogFormatter has been deprecated.

        $result = $this->invokeMethod($formatter, 'extractValues', array($entry, $match));
        $expectedResult = [
            0 => 'E_WARNING: Invalid argument supplied for foreach() ',
            1 =>
                [
                    'code'    => 2,
                    'message' => 'Invalid argument supplied for foreach()',
                    'file'    => '/data/site/docroot/logviewer/src/Model/LogEntry.php',
                    'line'    => 89
                ],
            2 => '[]'
        ];
        $this->assertEquals($expectedResult, $result);
    }

    /**
     * Call protected/private method of a class.
     *
     * @param DeprecatedLogFormatter &$object Instantiated object that we will run method on.
     * @param string $methodName Method name to call
     * @param array $parameters Array of parameters to pass into method.
     *
     * @return mixed Method return.
     */
    public function invokeMethod(&$object, $methodName, array $parameters = array())

This method seems to be duplicated in your project.

    {
        $reflection = new ReflectionClass(get_class($object));
        $method = $reflection->getMethod($methodName);
        $method->setAccessible(true);

        return $method->invokeArgs($object, $parameters);
    }

}