SilverLeague\LogViewer\Tests\Model\LogEntryTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	84
Duplicated Lines	23.81 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	3
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	testProvidePermissions()	0	7	1
A	testAllowCreate()	0	8	1
A	testAllowEditing()	0	4	1
A	testAllowView()	10	10	1
A	testAllowDelete()	10	10	1
A	testLogEntriesAreFormattedAsJson()	0	19	1

<?php

namespace SilverLeague\LogViewer\Tests\Model;

use SilverStripe\Core\Convert;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Forms\LiteralField;
use SilverLeague\LogViewer\Model\LogEntry;

/**
 * @package silverstripe-logviewer
 * @author  Robbie Averill <robbie@averill.co.nz>
 */
class LogEntryTest extends SapphireTest
{
    /**
     * Test if the Permissions are an array and contain the view and delete permissions
     */
    public function testProvidePermissions()
    {
        $permissions = LogEntry::create()->providePermissions();
        $this->assertTrue(is_array($permissions));
        $this->assertTrue(array_key_exists('DELETE_ENTRY', $permissions));
        $this->assertTrue(array_key_exists('VIEW_ENTRY', $permissions));
    }

    /**
     * There's no reason to manually create, so don't allow manual creation
     */
    public function testAllowCreate()
    {
        $createFalse = LogEntry::create()->canCreate(null);
        $this->assertFalse($createFalse);
        $this->logInWithPermission('ADMIN');
        $createFalse = LogEntry::create()->canCreate();
        $this->assertFalse($createFalse);
    }

    /**
     * Test that LogEntry classes can not be edited
     */
    public function testAllowEditing()
    {
        $this->assertFalse(LogEntry::create()->canEdit());
    }

    /**
     * We can view if we're logged in as admin. Otherwise, no.
     */
    public function testAllowView()

This method seems to be duplicated in your project.

    {
        $this->logOut();
        $viewFalse = LogEntry::create()->canView(null);
        $this->assertFalse($viewFalse);

        $this->logInWithPermission('ADMIN');
        $viewTrue = LogEntry::create()->canView();
        $this->assertTrue($viewTrue);
    }

    /**
     * We can Delete if we're logged in as admin. Otherwise, no.
     */
    public function testAllowDelete()

This method seems to be duplicated in your project.

    {
        $this->logOut();
        $deleteFalse = LogEntry::create()->canDelete(null);
        $this->assertFalse($deleteFalse);

        $this->logInWithPermission('ADMIN');
        $deleteTrue = LogEntry::create()->canDelete();
        $this->assertTrue($deleteTrue);
    }

    /**
     * Ensure that the contents are JSON encoded and pretty printed, and that the CSS class is correct
     */
    public function testLogEntriesAreFormattedAsJson()
    {
        $data = [
            'foo' => [
                'bar' => 'baz'
            ],
            'boo'
        ];

        $entry = LogEntry::create();
        $entry->Entry = Convert::raw2json($data);

The property Entry does not exist on object<SilverLeague\LogViewer\Model\LogEntry>. Since you implemented __set, maybe consider adding a @property annotation.

        $fields = $entry->getCMSFields();
        $field = $fields->fieldByName('Root.Main.Entry');

        $this->assertInstanceOf(LiteralField::class, $field);
        $this->assertContains(Convert::raw2json($data, JSON_PRETTY_PRINT), $field->getContent());
        $this->assertContains('<pre class="logviewer-logentry-entry"><code>', $field->getContent());
    }
}