DumpCommand::getParsedOutput() - Code Metrics - Inspection of "Merge pull request #50 from robbieaverill/bugfix/n..." - silverleague/silverstripe-console - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 322a58...f1cf97 )

by Robbie

created 2017-03-06 11:06 UTC

DumpCommand::getParsedOutput() C

↳ Parent: DumpCommand

Complexity

Conditions	12
Paths	6

Size

Total Lines	39
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	39
rs	5.1612
cc	12
eloc	27
nc	6
nop	1

How to fix Complexity

<?php

namespace SilverLeague\Console\Command\Config;

use SilverLeague\Console\Command\Config\AbstractConfigCommand;
use SilverStripe\Core\Convert;
use Symfony\Component\Console\Helper\Table;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Outputs a combined representation of all SilverStripe configuration
 *
 * @package silverstripe-console
 * @author  Robbie Averill <[email protected]>
 */
class DumpCommand extends AbstractConfigCommand
{
    /**
     * @var string|null
     */
    protected $filter;

    /**
     * {@inheritDoc}
     */
    protected function configure()
    {
        $this
            ->setName('config:dump')
            ->setDescription('Dumps all of the processed configuration properties and their values')
            ->addOption('filter', null, InputOption::VALUE_REQUIRED, 'Filter the results (search)');

        $this->setHelp(<<<HELP
Dumps all of the processed configuration properties and their values. You can optionally add the --filter option
with a search value to narrow the results.
HELP
        );
    }

    /**
     * {@inheritDoc}
     * @param InputInterface $input
     * @param OutputInterface $output
     * @throws InvalidArgumentException If an invalid configuration type is provided
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $this->filter = $input->getOption('filter');

        $data = $this->getParsedOutput($this->getConfig()->getAll());
        if ($this->filter) {
            $data = $this->filterOutput($data, $this->filter);
        }

        $table = new Table($output);
        $table
            ->setHeaders(['Class name', 'Property', 'Key', 'Value'])
            ->setRows($data)
            ->render();
    }

    /**
     * Creates a table-friendly output array from the input configuration source
     *
     * @param  array $data
     * @return array
     */
    protected function getParsedOutput($data)
    {
        $output = [];
        foreach ($data as $className => $classInfo) {
            foreach ($classInfo as $property => $values) {
                $row = [$className, $property];
                if (is_array($values) || is_object($values)) {
                    foreach ($values as $key => $value) {
                        $row[] = is_numeric($key) ? '' : $key;
                        if (is_array($value)) {
                            $value = Convert::raw2json($value, JSON_PRETTY_PRINT);
                        } elseif (is_object($value)) {
                            $value = get_class($value);
                        } else {
                            $value = (string) $value;
                        }
                        $row[] = $value;
                        if (array_filter($row) != []) {
                            $output[] = $row;
                        }
                        // We need the class and property data for second level values if we're filtering.
                        if ($this->filter !== null) {
                            $row = [$className, $property];
                        } else {
                            $row = ['', ''];
                        }
                    }
                } else {
                    $row[] = '';
                    $row[] = $values;
                }

                if (array_filter($row) != []) {
                    $output[] = $row;
                }
            }
        }
        return $output;
    }

    /**
     * Apply a search filter to the results
     *
     * @param  array  $data   The pre-parsed output data
     * @param  string $filter The string to search on
     * @return array          Rows that have a string match on any of their fields
     */
    protected function filterOutput($data, $filter)
    {
        $output = [];
        foreach ($data as $values) {
            foreach ($values as $value) {
                if (is_string($value) && stripos($value, $filter) !== false) {
                    $output[] = $values;
                }
            }
        }
        return $output;
    }
}


1			<?php
2
3			namespace SilverLeague\Console\Command\Config;
4
5			use SilverLeague\Console\Command\Config\AbstractConfigCommand;
6			use SilverStripe\Core\Convert;
7			use Symfony\Component\Console\Helper\Table;
8			use Symfony\Component\Console\Input\InputInterface;
9			use Symfony\Component\Console\Input\InputOption;
10			use Symfony\Component\Console\Output\OutputInterface;
11
12			/**
13			* Outputs a combined representation of all SilverStripe configuration
14			*
15			* @package silverstripe-console
16			* @author Robbie Averill <[email protected]>
17			*/
18			class DumpCommand extends AbstractConfigCommand
19			{
20			/**
21			* @var string\|null
22			*/
23			protected $filter;
24
25			/**
26			* {@inheritDoc}
27			*/
28			protected function configure()
29			{
30			$this
31			->setName('config:dump')
32			->setDescription('Dumps all of the processed configuration properties and their values')
33			->addOption('filter', null, InputOption::VALUE_REQUIRED, 'Filter the results (search)');
34
35			$this->setHelp(<<<HELP
36			Dumps all of the processed configuration properties and their values. You can optionally add the --filter option
37			with a search value to narrow the results.
38			HELP
39			);
40			}
41
42			/**
43			* {@inheritDoc}
44			* @param InputInterface $input
45			* @param OutputInterface $output
46			* @throws InvalidArgumentException If an invalid configuration type is provided
47			*/
48			protected function execute(InputInterface $input, OutputInterface $output)
49			{
50			$this->filter = $input->getOption('filter');
51
52			$data = $this->getParsedOutput($this->getConfig()->getAll());
53			if ($this->filter) {
54			$data = $this->filterOutput($data, $this->filter);
55			}
56
57			$table = new Table($output);
58			$table
59			->setHeaders(['Class name', 'Property', 'Key', 'Value'])
60			->setRows($data)
61			->render();
62			}
63
64			/**
65			* Creates a table-friendly output array from the input configuration source
66			*
67			* @param array $data
68			* @return array
69			*/
70			protected function getParsedOutput($data)
71			{
72			$output = [];
73			foreach ($data as $className => $classInfo) {
74			foreach ($classInfo as $property => $values) {
75			$row = [$className, $property];
76			if (is_array($values) \|\| is_object($values)) {
77			foreach ($values as $key => $value) {
78			$row[] = is_numeric($key) ? '' : $key;
79			if (is_array($value)) {
80			$value = Convert::raw2json($value, JSON_PRETTY_PRINT);
81			} elseif (is_object($value)) {
82			$value = get_class($value);
83			} else {
84			$value = (string) $value;
85			}
86			$row[] = $value;
87			if (array_filter($row) != []) {
88			$output[] = $row;
89			}
90			// We need the class and property data for second level values if we're filtering.
91			if ($this->filter !== null) {
92			$row = [$className, $property];
93			} else {
94			$row = ['', ''];
95			}
96			}
97			} else {
98			$row[] = '';
99			$row[] = $values;
100			}
101
102			if (array_filter($row) != []) {
103			$output[] = $row;
104			}
105			}
106			}
107			return $output;
108			}
109
110			/**
111			* Apply a search filter to the results
112			*
113			* @param array $data The pre-parsed output data
114			* @param string $filter The string to search on
115			* @return array Rows that have a string match on any of their fields
116			*/
117			protected function filterOutput($data, $filter)
118			{
119			$output = [];
120			foreach ($data as $values) {
121			foreach ($values as $value) {
122			if (is_string($value) && stripos($value, $filter) !== false) {
123			$output[] = $values;
124			}
125			}
126			}
127			return $output;
128			}
129			}
130

silverleague / silverstripe-console

Push — master ( 322a58...f1cf97 )

DumpCommand::getParsedOutput() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like