DumpCommand::getParsedOutput() - Code Metrics - Inspection of "FIX Update config commands for new config API in a..." - silverleague/silverstripe-console - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#50)

by Robbie

created 2017-03-06 10:24 UTC

DumpCommand::getParsedOutput() D

↳ Parent: DumpCommand

Complexity

Conditions	10
Paths	6

Size

Total Lines	31
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	31
rs	4.8196
cc	10
eloc	21
nc	6
nop	1

How to fix Complexity

<?php

namespace SilverLeague\Console\Command\Config;

use SilverLeague\Console\Command\Config\AbstractConfigCommand;
use Symfony\Component\Console\Helper\Table;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Outputs a combined representation of all SilverStripe configuration
 *
 * @package silverstripe-console
 * @author  Robbie Averill <[email protected]>
 */
class DumpCommand extends AbstractConfigCommand
{
    /**
     * @var string|null
     */
    protected $filter;

    /**
     * {@inheritDoc}
     */
    protected function configure()
    {
        $this
            ->setName('config:dump')
            ->setDescription('Dumps all of the processed configuration properties and their values')
            ->addOption('filter', null, InputOption::VALUE_REQUIRED, 'Filter the results (search)');

        $this->setHelp(<<<HELP
Dumps all of the processed configuration properties and their values. You can optionally add the --filter option
with a search value to narrow the results.
HELP
        );
    }

    /**
     * {@inheritDoc}
     * @param InputInterface $input
     * @param OutputInterface $output
     * @throws InvalidArgumentException If an invalid configuration type is provided
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $this->filter = $input->getOption('filter');

        $data = $this->getParsedOutput($this->getConfig()->getAll());
        if ($this->filter) {
            $data = $this->filterOutput($data, $this->filter);
        }

        $table = new Table($output);
        $table
            ->setHeaders(['Class name', 'Property', 'Key', 'Value'])
            ->setRows($data)
            ->render();
    }

    /**
     * Creates a table-friendly output array from the input configuration source
     *
     * @param  array $data
     * @return array
     */
    protected function getParsedOutput($data)
    {
        $output = [];
        foreach ($data as $className => $classInfo) {
            foreach ($classInfo as $property => $values) {
                $row = [$className, $property];
                if (is_array($values)) {
                    foreach ($values as $key => $value) {
                        $row[] = is_numeric($key) ? '' : $key;
                        $row[] = is_array($value) ? json_encode($value, JSON_PRETTY_PRINT) : $value;
                        if (array_filter($row) != []) {
                            $output[] = $row;
                        }
                        // We need the class and property data for second level values if we're filtering.
                        if ($this->filter !== null) {
                            $row = [$className, $property];
                        } else {
                            $row = ['', ''];
                        }
                    }
                } else {
                    $row[] = '';
                    $row[] = $values;
                }
                if (array_filter($row) != []) {
                    $output[] = $row;
                }
            }
        }
        return $output;
    }

    /**
     * Apply a search filter to the results
     *
     * @param  array  $data   The pre-parsed output data
     * @param  string $filter The string to search on
     * @return array          Rows that have a string match on any of their fields
     */
    protected function filterOutput($data, $filter)
    {
        $output = [];
        foreach ($data as $values) {
            foreach ($values as $value) {
                if (is_string($value) && stripos($value, $filter) !== false) {
                    $output[] = $values;
                }
            }
        }
        return $output;
    }
}


1			<?php
2
3			namespace SilverLeague\Console\Command\Config;
4
5			use SilverLeague\Console\Command\Config\AbstractConfigCommand;
6			use Symfony\Component\Console\Helper\Table;
7			use Symfony\Component\Console\Input\InputInterface;
8			use Symfony\Component\Console\Input\InputOption;
9			use Symfony\Component\Console\Output\OutputInterface;
10
11			/**
12			* Outputs a combined representation of all SilverStripe configuration
13			*
14			* @package silverstripe-console
15			* @author Robbie Averill <[email protected]>
16			*/
17			class DumpCommand extends AbstractConfigCommand
18			{
19			/**
20			* @var string\|null
21			*/
22			protected $filter;
23
24			/**
25			* {@inheritDoc}
26			*/
27			protected function configure()
28			{
29			$this
30			->setName('config:dump')
31			->setDescription('Dumps all of the processed configuration properties and their values')
32			->addOption('filter', null, InputOption::VALUE_REQUIRED, 'Filter the results (search)');
33
34			$this->setHelp(<<<HELP
35			Dumps all of the processed configuration properties and their values. You can optionally add the --filter option
36			with a search value to narrow the results.
37			HELP
38			);
39			}
40
41			/**
42			* {@inheritDoc}
43			* @param InputInterface $input
44			* @param OutputInterface $output
45			* @throws InvalidArgumentException If an invalid configuration type is provided
46			*/
47			protected function execute(InputInterface $input, OutputInterface $output)
48			{
49			$this->filter = $input->getOption('filter');
50
51			$data = $this->getParsedOutput($this->getConfig()->getAll());
52			if ($this->filter) {
53			$data = $this->filterOutput($data, $this->filter);
54			}
55
56			$table = new Table($output);
57			$table
58			->setHeaders(['Class name', 'Property', 'Key', 'Value'])
59			->setRows($data)
60			->render();
61			}
62
63			/**
64			* Creates a table-friendly output array from the input configuration source
65			*
66			* @param array $data
67			* @return array
68			*/
69			protected function getParsedOutput($data)
70			{
71			$output = [];
72			foreach ($data as $className => $classInfo) {
73			foreach ($classInfo as $property => $values) {
74			$row = [$className, $property];
75			if (is_array($values)) {
76			foreach ($values as $key => $value) {
77			$row[] = is_numeric($key) ? '' : $key;
78			$row[] = is_array($value) ? json_encode($value, JSON_PRETTY_PRINT) : $value;
79			if (array_filter($row) != []) {
80			$output[] = $row;
81			}
82			// We need the class and property data for second level values if we're filtering.
83			if ($this->filter !== null) {
84			$row = [$className, $property];
85			} else {
86			$row = ['', ''];
87			}
88			}
89			} else {
90			$row[] = '';
91			$row[] = $values;
92			}
93			if (array_filter($row) != []) {
94			$output[] = $row;
95			}
96			}
97			}
98			return $output;
99			}
100
101			/**
102			* Apply a search filter to the results
103			*
104			* @param array $data The pre-parsed output data
105			* @param string $filter The string to search on
106			* @return array Rows that have a string match on any of their fields
107			*/
108			protected function filterOutput($data, $filter)
109			{
110			$output = [];
111			foreach ($data as $values) {
112			foreach ($values as $value) {
113			if (is_string($value) && stripos($value, $filter) !== false) {
114			$output[] = $values;
115			}
116			}
117			}
118			return $output;
119			}
120			}
121

silverleague / silverstripe-console

Pull Request — master (#50)

DumpCommand::getParsedOutput() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like