SilverLeague\Console\Tests\Command\Member\ChangeGroupsCommandTest

Complexity

Total Complexity

10

Size/Duplication

Total Lines	101
Duplicated Lines	8.91 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	tearDown()	9	9	3
A	getTestCommand()	0	4	1
A	testReportMemberNotFound()	0	5	1
A	testAddToGroups()	0	16	1
A	createMember()	0	8	1
B	mockQuestionHelper()	0	25	3

<?php

namespace SilverLeague\Console\Tests\Command\Member;

use SilverLeague\Console\Tests\Command\AbstractCommandTest;
use SilverStripe\Security\Member;
use Symfony\Component\Console\Helper\QuestionHelper;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ChoiceQuestion;

/**
 * Change a member's assigned groups
 *
 * @coversDefaultClass \SilverLeague\Console\Command\Member\ChangeGroupsCommand
 * @package silverstripe-console
 * @author  Robbie Averill <robbie@averill.co.nz>
 */
class ChangeGroupsCommandTest extends AbstractCommandTest
{
    /**
     * Delete fixtured members after tests have run
     */
    protected function tearDown()

This method seems to be duplicated in your project.

    {
        parent::tearDown();

        $testMember = Member::get()->filter(['Email' => 'changemygroup@example.com'])->first();
        if ($testMember && $testMember->exists()) {
            $testMember->delete();
        }
    }

    /**
     * {@inheritDoc}
     */
    protected function getTestCommand()
    {
        return 'member:change-groups';
    }

    /**
     * Test that an error message is returned if the Member does not exist
     *
     * @covers ::execute
     */
    public function testReportMemberNotFound()
    {
        $tester = $this->executeTest(['email' => 'lonely.so.lonely@example.com']);
        $this->assertContains('Member with email "lonely.so.lonely@example.com" was not found', $tester->getDisplay());
    }

    /**
     * Test that when a Group is chosen from the multiselect list, the user is assigned to that Group or Groups
     *
     * @covers ::execute
     */
    public function testAddToGroups()
    {
        $member = $this->createMember();

$member is not used, you could remove the assignment.

        $this->mockQuestionHelper();
        $tester = $this->executeTest(['email' => 'changemygroup@example.com']);
        $this->assertContains('Groups updated.', $tester->getDisplay());

        $memberCodes = Member::get()
            ->filter('Email', 'changemygroup@example.com')
            ->first()
            ->Groups()
            ->column('Code');

        $this->assertSame(['content-authors'], $memberCodes);
    }

    /**
     * Creates a dummy user for testing with
     *
     * @return Member
     */
    protected function createMember()
    {
        $member = Member::create();
        $member->Email = 'changemygroup@example.com';
        $member->Password = 'Opensesame1';
        $member->write();
        return $member;
    }

    /**
     * Mock a QuestionHelper and tell it to return a predefined choice for which Group to assign
     *
     * @return QuestionHelper
     */
    protected function mockQuestionHelper()
    {
        $mock = $this
            ->getMockBuilder(QuestionHelper::class)
            ->setMethods(['ask'])
            ->getMock();

        $mock
            ->expects($this->once())
            ->method('ask')
            ->with(
                $this->isInstanceOf(InputInterface::class),
                $this->isInstanceOf(OutputInterface::class),
                $this->callback(
                    function ($argument) {
                        return $argument instanceof ChoiceQuestion
                            && $argument->isMultiselect()
                            && !empty($argument->getChoices());
                    }
                )
            )
            ->willReturn(['content-authors']);

        $this->command->getApplication()->getHelperSet()->set($mock, 'question');
    }
}