SilverCommerce\Postage\Model\FlatRate

Complexity

Total Complexity

6

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	getPossiblePostage()	0	32	6

<?php

namespace SilverCommerce\Postage\Model;

use SilverStripe\ORM\ArrayList;
use SilverStripe\ORM\DataObject;
use SilverCommerce\GeoZones\Model\Zone;
use SilverCommerce\Postage\Helpers\Parcel;
use SilverCommerce\Postage\Model\PostageType;
use SilverCommerce\Postage\Helpers\PostageOption;

/**
 * Represents a flat shipping cost, based on the selected regions.
 * 
 * NOTE If you dont select any regions, this rate will be applied to
 * ALL regions
 */
class FlatRate extends PostageType
{
    private static $table_name = 'PostageType_FlatRate';

The private property $table_name is not used, and could be removed.

    private static $db = [

The private property $db is not used, and could be removed.

        "Price" => "Currency"
    ];

    private static $many_many = [

The private property $many_many is not used, and could be removed.

        "Locations" => Zone::class
    ];

    /**
     * If the current parcel is located in an area that we
     * allow flat rate
     * 
     * @param Parcel
     * @return SSList

The type SilverCommerce\Postage\Model\SSList was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    public function getPossiblePostage(Parcel $parcel)
    {
        $return = ArrayList::create();
        $locations = $this->Locations();

The method Locations() does not exist on SilverCommerce\Postage\Model\FlatRate. Since you implemented __call, consider adding a @method annotation.

        $country = $parcel->getCountry();
        $region = $parcel->getRegion();
        $tax = null;

        if ($this->Tax()->exists()) {

The method Tax() does not exist on SilverCommerce\Postage\Model\FlatRate. Since you implemented __call, consider adding a @method annotation.

            $tax = $this->Tax()->ValidTax();
        }
        
        $postage = PostageOption::create(
            $this->Name,

The property Name does not exist on SilverCommerce\Postage\Model\FlatRate. Since you implemented __get, consider adding a @property annotation.

            $this->Price,

The property Price does not exist on SilverCommerce\Postage\Model\FlatRate. Since you implemented __get, consider adding a @property annotation.

            $tax
        ); 

        if (!$locations->exists()) {
            $return->add($postage);
        } elseif (isset($country) && isset($region)) {
            $locations = $locations->filter([
                "Regions.CountryCode" => $country,
                "Regions.Code" => $region
            ]);

            if ($locations->exists()) {
                $return->add($postage);
            }
        }

        return $return;
    }
}