SilverCommerce\OrdersAdmin\Model\Discount

Complexity

Total Complexity

15

Size/Duplication

Total Lines	134
Duplicated Lines	0 %

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	canDelete()	0	8	2
A	populateDefaults()	0	3	1
A	AddLink()	0	7	1
A	generateRandomString()	0	10	2
A	canView()	0	8	2
A	onBeforeWrite()	0	6	1
A	canEdit()	0	8	2
A	canCreate()	0	8	2
A	getCMSFields()	0	18	2

<?php

namespace SilverCommerce\OrdersAdmin\Model;

use SilverStripe\ORM\DataObject;
use SilverStripe\Control\Controller;
use SilverStripe\Forms\ReadonlyField;
use SilverStripe\Security\Group;
use SilverStripe\Core\Convert;
use SilverStripe\SiteConfig\SiteConfig;
use SilverCommerce\OrdersAdmin\Control\ShoppingCart;

The type SilverCommerce\OrdersAdmin\Control\ShoppingCart was not found. Maybe you did not declare it correctly or list all dependencies?

class Discount extends DataObject
{
    private static $table_name = 'Discount';

The private property $table_name is not used, and could be removed.

    private static $db = array(

The private property $db is not used, and could be removed.

        "Title"     => "Varchar",
        "Type"      => "Enum('Fixed,Percentage,Free Shipping','Percentage')",
        "Code"      => "Varchar(299)",
        "Amount"    => "Decimal",
        "Country"   => "Varchar(255)",
        "Expires"   => "Date"
    );

    private static $has_one = array(

The private property $has_one is not used, and could be removed.

        "Site"      => SiteConfig::class
    );

    private static $many_many = array(

The private property $many_many is not used, and could be removed.

        "Groups"    => Group::class
    );

    private static $summary_fields = array(

The private property $summary_fields is not used, and could be removed.

        "Title",
        "Code",
        "Expires"
    );

    /**
     * Generate a random string that we can use for the code by default
     *
     * @return string
     */
    private static function generateRandomString($length = 10)
    {
        $characters = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
        $string = '';

        for ($i = 0; $i < $length; $i++) {
            $string .= $characters[rand(0, strlen($characters) - 1)];
        }

        return $string;
    }

    /**
     * Set more complex default data
     */
    public function populateDefaults()
    {
        $this->setField('Code', self::generateRandomString());
    }

    /**
     * Return a URL that allows this code to be added to a cart
     * automatically
     *
     * @return String
     */
    public function AddLink()
    {
        $cart = ShoppingCart::get();
        
        return Controller::join_links(
            $cart->AbsoluteLink("usediscount"),
            $this->Code
        );
    }

    public function getCMSFields()
    {
        
        $this->beforeUpdateCMSFields(function ($fields) {
            if ($this->Code) {
                $fields->addFieldToTab(
                    "Root.Main",
                    ReadonlyField::create(
                        "DiscountURL",

'DiscountURL' of type string is incompatible with the type array expected by parameter $args of SilverStripe\View\ViewableData::create().

                        _t("OrdersAdmin.AddDiscountURL", "Add discount URL"),
                        $this->AddLink()
                    ),
                    "Code"
                );
            }
        });

        return parent::getCMSFields();
    }

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();

        // Ensure that the code is URL safe
        $this->Code = Convert::raw2url($this->Code);

The property Code does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function canView($member = null, $context = [])

The parameter $context is not used and could be removed.

    {
        $extended = $this->extendedCan('canView', $member);
        if ($extended !== null) {
            return $extended;
        }
        
        return true;
    }
    
    public function canCreate($member = null, $context = [])
    {
        $extended = $this->extendedCan('canCreate', $member);
        if ($extended !== null) {
            return $extended;
        }
        
        return true;
    }

    public function canEdit($member = null, $context = [])

The parameter $context is not used and could be removed.

    {
        $extended = $this->extendedCan('canEdit', $member);
        if ($extended !== null) {
            return $extended;
        }
        
        return true;
    }

    public function canDelete($member = null, $context = [])

The parameter $context is not used and could be removed.

    {
        $extended = $this->extendedCan('canDelete', $member);
        if ($extended !== null) {
            return $extended;
        }
        
        return true;
    }
}