SilverCommerce\OrdersAdmin\Tasks\OrdersMigrationTask::up()

Complexity

Conditions	16
Paths	720

Size

Total Lines	100
Code Lines	63

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function up()
    {
        // Migrate estimate/invoice numbers to new ref field
        $this->log('- Migrating estimate/invoice numbers');
        $total = 0;

The assignment to $total is dead and can be removed.

        if (class_exists(Subsite::class)) {
            $items = Subsite::get_from_all_subsites(Estimate::class);
        } else {
            $items = Estimate::get();
        }
        
        $count = false;
        if ($items) {
            $this->log('- '.$items->count().' items to convert.');
            $count = $items->count();
        }
        $i = 0;

        foreach ($items as $item) {
            if ($item->Number !== null) {
                $config = SiteConfig::current_site_config();
                $inv_prefix = $config->InvoiceNumberPrefix;
                $est_prefix = $config->EstimateNumberPrefix;
                $number = $item->Number;

                // Strip off current prefix and convert to a ref
                if ($item instanceof Invoice) {
                    $ref = str_replace($inv_prefix . "-", "", $number);
                    $ref = str_replace('-', '', $ref);
                    $item->Ref = (int)$ref;

The property Ref does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                    $item->Prefix = $inv_prefix;

The property Prefix does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                } else {
                    $ref = str_replace($est_prefix . "-", "", $number);
                    $ref = str_replace('-', '', $ref);
                    $item->Ref = (int)$ref;
                    $item->Prefix = $est_prefix;
                }

                $item->Number = null;

The property Number does not exist on SilverCommerce\OrdersAdmin\Model\Invoice. Since you implemented __set, consider adding a @property annotation.

                $item->write();
            }
            $i++;
            $this->log('- '.$i.'/'.$count.' items migrated.', true);

The call to SilverCommerce\OrdersAdmin\Tasks\OrdersMigrationTask::log() has too many arguments starting with true.

        }

        unset($items);

        // Change price/tax on line items to use new fields from extension
        $items = LineItem::get();
        $count = $items->count();
        $this->log("Migrating {$count} Line Items");
        $i = 0;

        foreach ($items as $item) {
            $write = false;

            if ((int)$item->Price && (int)$item->BasePrice == 0) {
                $item->BasePrice = $item->Price;
                $write = true;
            }

            if ($item->TaxID != 0 && $item->TaxRateID == 0) {
                $item->TaxRateID = $item->TaxID;
                $write = true;
            }

            if ($write) {
                $item->write();
                $i++;
            }
        }

        unset($items);
        
        $this->log("Migrated {$i} Line Item Customisations");

        // Change price/tax on line items to use new fields from extension
        $items = LineItemCustomisation::get();
        $count = $items->count();
        $this->log("Migrating {$count} Line Items");
        $i = 0;

        foreach ($items as $item) {
            $write = false;

            if ((int)$item->Price && (int)$item->BasePrice == 0) {
                $item->BasePrice = $item->Price;
                $write = true;
            }

            if ($write) {
                $item->write();
                $i++;
            }
        }

        unset($items);
        
        $this->log("Migrated {$i} Line Items");
    }