DownloadFolder::onBeforeWrite() - Code Metrics - Inspection of "Add singular and plural names to product" - silvercommerce/downloadable-products - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — 1.0 ( 550c2d...ebbabc )

by Morven

created 2021-04-07 09:50 UTC

DownloadFolder::onBeforeWrite() A

↳ Parent: DownloadFolder

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	6
dl	0
loc	11
c	0
b	0
f	0
rs	10
cc	2
nc	2
nop	0

<?php

namespace SilverCommerce\DownloadableProducts;

use SilverStripe\ORM\DB;
use SilverStripe\Assets\Folder;
use SilverStripe\Security\InheritedPermissions;

/**
 * A custom type of folder used to 
 */
class DownloadFolder extends Folder
{
    /**
     * The location of this folder
     * 
     * @var string
     */
    private static $folder_name = "downloadableproducts";

    /**
     * Setup defaults when a dev build is run
     * 
     * @return void
     */
    public function requireDefaultRecords()
    {
        parent::requireDefaultRecords();

        // Setup, or change, the top level download folder.
        $download_folder = static::find_or_make(static::config()->folder_name);
        $download_folder->ClassName = self::class;
        $download_folder->write();
        DB::alteration_message("Setup downloadableproduct folder");
    }

    /**
     * Ensure this folder has correct permissions
     */
    public function onBeforeWrite()
    {
        parent::onBeforeWrite();

        $allowed = [
            InheritedPermissions::LOGGED_IN_USERS,
            InheritedPermissions::ONLY_THESE_USERS
        ];

        if (!in_array($this->CanViewType, $allowed)) {
            $this->CanViewType = InheritedPermissions::LOGGED_IN_USERS;

        }
    }

}

1			<?php
2
3			namespace SilverCommerce\DownloadableProducts;
4
5			use SilverStripe\ORM\DB;
6			use SilverStripe\Assets\Folder;
7			use SilverStripe\Security\InheritedPermissions;
8
9			/**
10			* A custom type of folder used to
11			*/
12			class DownloadFolder extends Folder
13			{
14			/**
15			* The location of this folder
16			*
17			* @var string
18			*/
19			private static $folder_name = "downloadableproducts";
20
21			/**
22			* Setup defaults when a dev build is run
23			*
24			* @return void
25			*/
26			public function requireDefaultRecords()
27			{
28			parent::requireDefaultRecords();
29
30			// Setup, or change, the top level download folder.
31			$download_folder = static::find_or_make(static::config()->folder_name);
32			$download_folder->ClassName = self::class;
33			$download_folder->write();
34			DB::alteration_message("Setup downloadableproduct folder");
35			}
36
37			/**
38			* Ensure this folder has correct permissions
39			*/
40			public function onBeforeWrite()
41			{
42			parent::onBeforeWrite();
43
44			$allowed = [
45			InheritedPermissions::LOGGED_IN_USERS,
46			InheritedPermissions::ONLY_THESE_USERS
47			];
48
49			if (!in_array($this->CanViewType, $allowed)) {
50			$this->CanViewType = InheritedPermissions::LOGGED_IN_USERS;
			0 ignored issues – show Bug Best Practice introduced 2021-04-07 09:59 UTC by Report Bug Copy Issue Report The property `CanViewType` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
51			}
52			}
53
54			}

silvercommerce / downloadable-products

Push — 1.0 ( 550c2d...ebbabc )

DownloadFolder::onBeforeWrite() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like