silvercommerce / discounts

src/model/FixedRateDiscount.php

<?php

namespace SilverCommerce\Discounts\Model;

use SilverStripe\ORM\ArrayList;
use SilverCommerce\Discounts\Model\Discount;
use SilverCommerce\OrdersAdmin\Model\Estimate;

class FixedRateDiscount extends Discount
{
    private static $table_name = 'Discount_FixedRate';

The private property $table_name is not used, and could be removed.

    private static $description = "Simple fixed value discount";

The private property $description is not used, and could be removed.

    private static $db = [

The private property $db is not used, and could be removed.

        "Amount"    => "Decimal"
    ];

    public function calculateAmount(Estimate $estimate)
    {
        $cats = $this->Categories();

The method Categories() does not exist on SilverCommerce\Discounts\Model\FixedRateDiscount. Since you implemented __call, consider adding a @method annotation.

        $all_products = ArrayList::create();
        $value = $estimate->getSubTotal();
        $min = (float) $this->MinOrder;

The property MinOrder does not exist on SilverCommerce\Discounts\Model\FixedRateDiscount. Since you implemented __get, consider adding a @property annotation.

        if ($cats->count() > 0) {
            $value = 0;
            foreach ($cats as $cat) {
                $all_products->merge($cat->Products());
            }

            foreach ($estimate->Items() as $line_item) {
                $match = $line_item->FindStockItem();
                if ($all_products->find('ID', $match->ID)) {
                    $value += ($line_item->Quantity * $line_item->UnitPrice);
                }
            }
        }

        $amount = $this->Amount;

The property Amount does not exist on SilverCommerce\Discounts\Model\FixedRateDiscount. Since you implemented __get, consider adding a @property annotation.

        if ($value < $min) {
            $amount = 0;
        }

        if ($amount > $value) {
            $amount = $value;
        }

        return $amount;
    }

    public function appliedAmount(AppliedDiscount $item)
    {
        return $this->calculateAmount($item->Estimate());

The method Estimate() does not exist on SilverCommerce\Discounts\Model\AppliedDiscount. Since you implemented __call, consider adding a @method annotation.

    }
}