silvercommerce / discounts

src/model/AppliedDiscount.php

<?php

namespace SilverCommerce\Discounts\Model;

use SilverStripe\ORM\DataObject;
use SilverCommerce\Discounts\DiscountFactory;
use SilverCommerce\OrdersAdmin\Model\Estimate;
use SilverCommerce\OrdersAdmin\Model\LineItem;

class AppliedDiscount extends DataObject
{
    private static $table_name = 'AppliedDiscount';

The private property $table_name is not used, and could be removed.

    private static $db = [

The private property $db is not used, and could be removed.

        'Title' => 'Varchar',
        'Code' => 'Varchar',
        'Value' => 'Currency'
    ];

    private static $has_one = [

The private property $has_one is not used, and could be removed.

        'Estimate' => Estimate::class
    ];

    private static $many_many = [

The private property $many_many is not used, and could be removed.

        'Items' => LineItem::class
    ];

    private static $summary_fields = [

The private property $summary_fields is not used, and could be removed.

        'Title',
        'Code',
        'Value'
    ];

    public function appliedAmount(AppliedDiscount $item)
    {
        return $this->calculateValue($item->Estimate()->getTotal());

The method Estimate() does not exist on SilverCommerce\Discounts\Model\AppliedDiscount. Since you implemented __call, consider adding a @method annotation.

The method calculateValue() does not exist on SilverCommerce\Discounts\Model\AppliedDiscount. Since you implemented __call, consider adding a @method annotation.

    }

    public function updateDiscount()
    {
        $discount = $this->getDiscount();
        if ($discount->exists()) {
            $value = $discount->appliedAmount($this);

            $this->Value = $value;

The property Value does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->write();
        }
    }

    public function getDiscount()
    {
        return DiscountFactory::create()->getByIdent($this->Code);

The property Code does not exist on SilverCommerce\Discounts\Model\AppliedDiscount. Since you implemented __get, consider adding a @property annotation.

    }
}