Discount::getCMSFields() - Code Metrics - Inspection of "added desription to MinOrder field" - silvercommerce/discounts - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — 1.0 ( 538dd9...e2c8be )

unknown
created 2020-04-14 15:25 UTC
Discount::getCMSFields() A

↳ Parent: Discount
Complexity

Conditions	2
Paths	2
Size

Total Lines	13
Code Lines	6
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	0	Features	1
Metric	Value
eloc	6
c	1
b	0
f	1
dl	0
loc	13
rs	10
cc	2
nc	2
nop	0
<?php

namespace SilverCommerce\Discounts\Model;

use SilverStripe\Core\Convert;
use SilverStripe\ORM\DataObject;
use SilverStripe\Security\Group;
use SilverStripe\Security\Security;
use SilverStripe\Control\Controller;
use SilverStripe\Forms\ReadonlyField;
use SilverStripe\Security\Permission;
use SilverStripe\SiteConfig\SiteConfig;
use SilverStripe\Security\PermissionProvider;
use SilverCommerce\OrdersAdmin\Model\Estimate;
use SilverCommerce\TaxAdmin\Helpers\MathsHelper;
use SilverCommerce\Discounts\Model\AppliedDiscount;
use SilverCommerce\CatalogueAdmin\Model\CatalogueCategory;
filter:
    dependency_paths: ["lib/*"]

class Discount extends DataObject implements PermissionProvider
{
    private static $table_name = 'Discount';


    private static $db = [

        "Title"     => "Varchar",
        "Code"      => "Varchar(99)",
        "MinOrder"  => "Decimal",
        "Starts"    => "Date",
        "Expires"   => "Date"
    ];

    private static $has_one = [

        "Site"      => SiteConfig::class
    ];

    private static $many_many = [

        "Groups"    => Group::class,
        "Categories" => CatalogueCategory::class
    ];

    private static $summary_fields = [

        "Title",
        "Code",
        "Starts",
        "Expires"
    ];

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $min = $fields->dataFieldByName("MinOrder");

        if ($min) {

            $min->setDescription(
                _t(self::class.".MinOrderPreTax","This is the SubTotal of an order EXCLUDING vat and tax")
            );
        }

        return $fields;
    }

    /**
     * calculate the price reduction for this discount
     *
     * @param  Currency $value - the total/sub-total of the items this discount applies to.
filter:
    dependency_paths: ["lib/*"]
     * @return int
     */
    public function calculateAmount(Estimate $estimate)
    {
        return 0;
    }

    /**
     * calculate the value of a discount using an AppliedDiscount item.
     *
     * @param  AppliedDiscount $item
     * @return float
     */
    public function appliedAmount(AppliedDiscount $item)
    public function appliedAmount(/** @scrutinizer ignore-unused */ AppliedDiscount $item)
    {
        return 0;        
    }

    public function applyDiscount($estimate, $code = null)
    public function applyDiscount($estimate, /** @scrutinizer ignore-unused */ $code = null)
    {
        $applied = AppliedDiscount::create();
        $applied->Code = $this->Code;
        $applied->Title = $this->Title;
        $applied->Value = $this->calculateAmount($estimate);
        $applied->EstimateID = $estimate->ID;

        $applied->write();

        $estimate->Discounts()->add($applied);
    }

    /**
     * Generate a random string that we can use for the code by default
     *
     * @return string
     */
    protected static function generateRandomString($length = 10)
    {
        $characters = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
        $string = '';

        for ($i = 0; $i < $length; $i++) {
            $string .= $characters[rand(0, strlen($characters) - 1)];
        }

        return $string;
    }

    /**
     * Set more complex default data
     */
    public function populateDefaults()
    {
        $this->setField('Code', self::generateRandomString());
    }

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();

        // Ensure that the code is URL safe
        $this->Code = Convert::raw2url($this->Code);

    }

    public function canView($member = null, $context = [])
    public function canView($member = null, /** @scrutinizer ignore-unused */ $context = [])
    {
        $extended = $this->extendedCan('canView', $member);
        if ($extended !== null) {
            return $extended;
        }
        
        return true;
    }
    
    public function canCreate($member = null, $context = [])
    {
        $extended = $this->extendedCan('canCreate', $member);
        if ($extended !== null) {
            return $extended;
        }

        $permissions = ["ADMIN", "DISCOUNTS_CREATE"];

        if (!$member) {
            $member = Security::getCurrentUser();
        }
        
        if ($member && Permission::checkMember($member->ID, $permissions)) {
            return true;
        }

        return false;
    }

    public function canEdit($member = null, $context = [])
    public function canEdit($member = null, /** @scrutinizer ignore-unused */ $context = [])
    {
        $extended = $this->extendedCan('canEdit', $member);
        if ($extended !== null) {
            return $extended;
        }

        $permissions = ["ADMIN", "DISCOUNTS_EDIT"];

        if (!$member) {
            $member = Security::getCurrentUser();
        }
        
        if ($member && Permission::checkMember($member->ID, $permissions)) {
            return true;
        }

        return false;
    }

    public function canDelete($member = null, $context = [])
    public function canDelete($member = null, /** @scrutinizer ignore-unused */ $context = [])
    {
        $extended = $this->extendedCan('canDelete', $member);
        if ($extended !== null) {
            return $extended;
        }

        $permissions = ["ADMIN", "DISCOUNTS_DELETE"];

        if (!$member) {
            $member = Security::getCurrentUser();
        }
        
        if ($member && Permission::checkMember($member->ID, $permissions)) {
            return true;
        }

        return false;
    }



    public function providePermissions()
    {
        return [
            "DISCOUNTS_CREATE" => [
                'name' => 'Create Discounts',
                'help' => 'Allow user to create discounts',
                'category' => 'Discounts',
                'sort' => 88
            ],
            "DISCOUNTS_EDIT" => [
                'name' => 'Edit Discounts',
                'help' => 'Allow user to edit discounts',
                'category' => 'Discounts',
                'sort' => 87
            ],
            "DISCOUNTS_DELETE" => [
                'name' => 'Delete Discounts',
                'help' => 'Allow user to delete discounts',
                'category' => 'Discounts',
                'sort' => 86
            ]
        ];
    }
}

silvercommerce / discounts

Push — 1.0 ( 538dd9...e2c8be )

Discount::getCMSFields() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
