SilverCommerce\Discounts\Model\PercentageDiscount::calculateAmount()

Complexity

Conditions	7
Paths	8

Size

Total Lines	36
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	1	Features	1

<?php
    public function calculateAmount(Estimate $estimate)
    {
        $cats = $this->Categories();

The method Categories() does not exist on SilverCommerce\Discounts\Model\PercentageDiscount. Since you implemented __call, consider adding a @method annotation.

        $all_products = ArrayList::create();
        $value = $estimate->getSubTotal();
        $min = (float) $this->MinOrder;

The property MinOrder does not exist on SilverCommerce\Discounts\Model\PercentageDiscount. Since you implemented __get, consider adding a @property annotation.

        if ($cats->count() > 0) {
            $value = 0;
            foreach ($cats as $cat) {
                $all_products->merge($cat->Products());
            }

            foreach ($estimate->Items() as $line_item) {
                $match = $line_item->FindStockItem();
                if ($all_products->find('ID', $match->ID)) {
                    $value += ($line_item->Quantity * $line_item->UnitPrice);
                }
            }
        }

        $converted_value = (int) ($value * 100);

        $converted_amount = $converted_value * ($this->Amount / 100);

The property Amount does not exist on SilverCommerce\Discounts\Model\PercentageDiscount. Since you implemented __get, consider adding a @property annotation.

        $amount = MathsHelper::round($converted_amount, 0)/100;

        if ($amount > $value) {
            $amount = $value;
        }

        if ($value < $min) {
            $amount = 0;
        }

        return $amount;
    }