SilverCommerce\CatalogueAdmin\Forms\GridField\ContactDetailForm_ItemRequest

Complexity

Total Complexity

9

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	doCreateUser()	0	16	3
A	ItemEditForm()	0	25	6

<?php

namespace SilverCommerce\CatalogueAdmin\Forms\GridField;

use SilverCommerce\ContactAdmin\Helpers\ContactHelper;
use SilverCommerce\ContactAdmin\Model\Contact;
use SilverStripe\Forms\FormAction;
use SilverStripe\Security\Security;
use SilverStripe\Forms\GridField\GridFieldDetailForm_ItemRequest;

/**
 * Custom detailform that allows generating user account from a contact
 *
 * @author ilateral
 */
class ContactDetailForm_ItemRequest extends GridFieldDetailForm_ItemRequest
{
    private static $allowed_actions = [

The private property $allowed_actions is not used, and could be removed.

        'edit',
        'view',
        'ItemEditForm'
    ];

    public function ItemEditForm()
    {
        $form = parent::ItemEditForm();
        $record = $this->record;

        if ($record instanceof Contact
            && $form && $record->ID !== 0
            && $record->canEdit()
            && !$record->Member()->exists()

The method Member() does not exist on SilverCommerce\ContactAdmin\Model\Contact. Since you implemented __call, consider adding a @method annotation.

        ) {
            $actions = $form->Actions();

The method Actions() does not exist on SilverStripe\Control\HTTPResponse.

            $actions->insertAfter(
                FormAction::create(
                    'doCreateUser',
                    _t('ContactAdmin.CreateUser', 'Create User Account')
                )->setUseButtonTag(true)
                ->addExtraClass('btn btn-outline-info')
                ->addExtraClass('action font-icon-torso'),
                "action_doSave"
            );
        }
        
        $this->extend("updateItemEditForm", $form);
        
        return $form;
    }

    public function doCreateUser($data, $form)

The parameter $data is not used and could be removed.

The parameter $form is not used and could be removed.

    {
        $record = $this->record;

        if ($record && !$record->canEdit()) {
            return Security::permissionFailure($this);

$this of type SilverCommerce\CatalogueAdmin\Forms\GridField\ContactDetailForm_ItemRequest is incompatible with the type SilverStripe\Control\Controller expected by parameter $controller of SilverStripe\Security\Security::permissionFailure().

        }

        $helper = ContactHelper::create()
            ->setContact($record);

        $member = $helper->findOrMakeMember();
        $helper->setMember($member);
        $helper->linkMemberToGroups();
        
        return $this->redirectAfterSave(false);
    }
}