Poloniex\Response\Traits\DateTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setDate()	0	3	1
A	getDate()	0	5	2
A	getDateTime()	0	3	1

<?php
/**
 * This file is part of Poloniex PHP SDK.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @copyright 2017-2018 Chasovskih Grisha <chasovskihgrisha@gmail.com>
 * @license https://github.com/signulls/poloniex-php-sdk/blob/master/LICENSE MIT
 */

namespace Poloniex\Response\Traits;

use DateTime;
use Poloniex\Response\ResponseInterface;

/**
 * Trait DateTrait
 *
 * @author Grisha Chasovskih <chasovskihgrisha@gmail.com>
 */
trait DateTrait
{
    /**
     * Example: "2014-10-18 23:03:21"
     *
     * @var string
     */
    public $date;

    /**
     * @internal
     * @param string $date
     */
    public function setDate(string $date): void
    {
        $this->date = $date;
    }

    /**
     * @internal
     * @param null $format

Are you sure the doc-type for parameter $format is correct as it would always require null to be passed?

     * @return string
     */
    public function getDate($format = null): string
    {
        return $format

$format is of type null, thus it always evaluated to false.

            ? $this->getDateTime()->format($format)
            : $this->date;
    }

    /**
     * @return DateTime
     */
    public function getDateTime(): DateTime
    {
        return DateTime::createFromFormat(ResponseInterface::DATE_FORMAT, $this->date);

The expression return DateTime::createFromFormat(Poloniex\Response\ResponseInterface::DATE_FORMAT, $this->date) could return the type false which is incompatible with the type-hinted return DateTime. Consider adding an additional type-check to rule them out.

    }
}