Poloniex\Api\Traits\ResponseFactoryTrait

Complexity

Total Complexity

7

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	throwExceptionIf()	0	4	2
A	setSerializer()	0	3	1
A	factory()	0	19	4

<?php
/**
 * This file is part of Poloniex PHP SDK.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @copyright 2017-2018 Chasovskih Grisha <chasovskihgrisha@gmail.com>
 * @license https://github.com/signulls/poloniex-php-sdk/blob/master/LICENSE MIT
 */

namespace Poloniex\Api\Traits;

use Poloniex\Exception\PoloniexException;
use Poloniex\Response\ResponseInterface;
use Symfony\Component\Serializer\{Serializer, SerializerInterface};

/**
 * Trait ResponseFactoryTrait
 *
 * @author Grisha Chasovskih <chasovskihgrisha@gmail.com>
 */
trait ResponseFactoryTrait
{
    /**
     * @var Serializer
     */
    protected $serializer;

    /**
     * Sets the serializer.
     *
     * @param SerializerInterface $serializer A SerializerInterface instance
     */
    public function setSerializer(SerializerInterface $serializer): void
    {
        $this->serializer = $serializer;

$serializer is of type Symfony\Component\Serializer\SerializerInterface, but the property $serializer was declared to be of type Symfony\Component\Serializer\Serializer. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * @param string $responseClass
     * @param array  $data
     *
     * @return ResponseInterface
     */
    protected function factory(string $responseClass, array $data): ResponseInterface
    {
        /* @var $response ResponseInterface */
        $response = $this->serializer->denormalize($data, $responseClass);
        $this->throwExceptionIf(!$response instanceof $responseClass, 'Poloniex response is not valid.');

        if (isset($data['globalTradeID'])) {
            $response->globalTradeId = (int) $data['globalTradeID'];

Accessing globalTradeId on the interface Poloniex\Response\ResponseInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        if (isset($data['tradeID'])) {
            $response->tradeId = (int) $data['tradeID'];

Accessing tradeId on the interface Poloniex\Response\ResponseInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        if (isset($data['orderID'])) {
            $response->orderId = (int) $data['orderID'];

Accessing orderId on the interface Poloniex\Response\ResponseInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        return $response;
    }

    /**
     * Throw exception by condition
     *
     * @param bool $condition
     * @param string $message
     *
     * @throws PoloniexException
     */
    protected function throwExceptionIf(bool $condition, string $message): void
    {
        if ($condition) {
            throw new PoloniexException($message);
        }
    }
}