IPBanEntry - Code Metrics - Inspection of "Merge branch 'initial-development'. Adds a CMS adm..." - signify-nz/silverstripe-iplogger - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 636aed...cb2cea )

by Charles

created 2017-02-26 03:50 UTC

IPBanEntry A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	1
dl	0
loc	20
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	Title()	0	4	1

<?php
/**
 * Provides a {@link DataObject} to store a ban against a specififc IP.
 *
 * @package silverstripe-iplogger
 */
class IPBanEntry extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        'Event'   => 'Varchar(255)',
        'IP'      => 'Varchar(255)'
    );

    private static $default_sort = 'Created';


    private static $summary_fields = array(

        'Created',
        'IP',
        'Event'
    );

    public function Title()
    {
        return $this->Event;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
2			/**
3			* Provides a {@link DataObject} to store a ban against a specififc IP.
4			*
5			* @package silverstripe-iplogger
6			*/
7			class IPBanEntry extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2017-02-22 00:00 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
8			{
9			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-02-22 00:00 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-02-22 00:00 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
10			'Event' => 'Varchar(255)',
11			'IP' => 'Varchar(255)'
12			);
13
14			private static $default_sort = 'Created';
			0 ignored issues – show Comprehensibility introduced 2017-02-26 03:52 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-02-26 03:52 UTC by Report Bug Copy Issue Report The property `$default_sort` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
15
16			private static $summary_fields = array(
			0 ignored issues – show Comprehensibility introduced 2017-02-26 03:52 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-02-26 03:52 UTC by Report Bug Copy Issue Report The property `$summary_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
17			'Created',
18			'IP',
19			'Event'
20			);
21
22			public function Title()
23			{
24			return $this->Event;
			0 ignored issues – show Documentation introduced 2017-02-26 03:52 UTC by Report Bug Copy Issue Report The property `Event` does not exist on `object<IPBanEntry>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
25			}
26			}
27

signify-nz / silverstripe-iplogger

GitHub Access Token became invalid

Push — master ( 636aed...cb2cea )

IPBanEntry A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like