siduko /
laravel-activitylog
| Conditions | 2 |
| Paths | 2 |
| Total Lines | 11 |
| Code Lines | 5 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
| 1 | <?php |
||
| 14 | protected static function bootDetectsChanges() |
||
| 15 | { |
||
| 16 | if (static::eventsToBeRecorded()->contains('updated')) { |
||
| 17 | static::updating(function (Model $model) { |
||
| 18 | //temporary hold the original attributes on the model |
||
| 19 | //as we'll need these in the updating event |
||
| 20 | $oldValues = $model->replicate()->setRawAttributes($model->getOriginal()); |
||
| 21 | $model->oldAttributes = static::logChanges($oldValues); |
||
| 22 | }); |
||
| 23 | } |
||
| 24 | } |
||
| 25 | public function attributesToBeLogged() |
||
| 48 | } |
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.