DetectsChanges::attributeValuesToBeLogged() - Code Metrics - siduko/laravel-activitylog - Measure and Improve Code Quality continuously with Scrutinizer

DetectsChanges::attributeValuesToBeLogged() A
last analyzed 2016-10-25 08:39 UTC

↳ Parent: DetectsChanges

Complexity

Conditions	4
Paths	3

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	8
nc	3
nop	1
dl	0
loc	12
rs	9.2
c	0
b	0
f	0

<?php
namespace LaiVu\ActivityLog\Traits;
use Illuminate\Database\Eloquent\Model;

/**
 * Created by PhpStorm.
 * User: Lai Vu
 * Date: 10/25/2016
 * Time: 10:10 AM
 */
trait DetectsChanges
{
    protected $oldAttributes = [];
    protected static function bootDetectsChanges()
    {
        if (static::eventsToBeRecorded()->contains('updated')) {
            static::updating(function (Model $model) {
                //temporary hold the original attributes on the model
                //as we'll need these in the updating event
                $oldValues = $model->replicate()->setRawAttributes($model->getOriginal());
                $model->oldAttributes = static::logChanges($oldValues);
            });
        }
    }
    public function attributesToBeLogged()
    {
        if (! isset(static::$logAttributes)) {
            return [];
        }
        return static::$logAttributes;
    }
    public function attributeValuesToBeLogged( $processingEvent)
    {
        if (! count($this->attributesToBeLogged())) {
            return [];
        }
        $properties['attributes'] = static::logChanges($this);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        if (static::eventsToBeRecorded()->contains('updated') && $processingEvent == 'updated') {
            $nullProperties = array_fill_keys(array_keys($properties['attributes']), null);
            $properties['old'] = array_merge($nullProperties, $this->oldAttributes);
        }
        return $properties;
    }
    public static function logChanges(Model $model)
    {
        return collect($model)->only($model->attributesToBeLogged())->toArray();
    }
}

1			<?php
2			namespace LaiVu\ActivityLog\Traits;
3			use Illuminate\Database\Eloquent\Model;
4
5			/**
6			* Created by PhpStorm.
7			* User: Lai Vu
8			* Date: 10/25/2016
9			* Time: 10:10 AM
10			*/
11			trait DetectsChanges
12			{
13			protected $oldAttributes = [];
14			protected static function bootDetectsChanges()
15			{
16			if (static::eventsToBeRecorded()->contains('updated')) {
17			static::updating(function (Model $model) {
18			//temporary hold the original attributes on the model
19			//as we'll need these in the updating event
20			$oldValues = $model->replicate()->setRawAttributes($model->getOriginal());
21			$model->oldAttributes = static::logChanges($oldValues);
22			});
23			}
24			}
25			public function attributesToBeLogged()
26			{
27			if (! isset(static::$logAttributes)) {
28			return [];
29			}
30			return static::$logAttributes;
31			}
32			public function attributeValuesToBeLogged( $processingEvent)
33			{
34			if (! count($this->attributesToBeLogged())) {
35			return [];
36			}
37			$properties['attributes'] = static::logChanges($this);
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-10-25 08:18 UTC by Report Bug Copy Issue Report `$properties` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$properties = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
38			if (static::eventsToBeRecorded()->contains('updated') && $processingEvent == 'updated') {
39			$nullProperties = array_fill_keys(array_keys($properties['attributes']), null);
40			$properties['old'] = array_merge($nullProperties, $this->oldAttributes);
41			}
42			return $properties;
43			}
44			public static function logChanges(Model $model)
45			{
46			return collect($model)->only($model->attributesToBeLogged())->toArray();
47			}
48			}

siduko / laravel-activitylog

DetectsChanges::attributeValuesToBeLogged() A last analyzed 2016-10-25 08:39 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

DetectsChanges::attributeValuesToBeLogged() A
last analyzed 2016-10-25 08:39 UTC