m160219_091156_createUser - Code Metrics - Inspection of "Update" - sibds/yii2-enterprise - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 26336c...0097a9 )

by Vadim

created 2016-02-20 06:00 UTC

m160219_091156_createUser A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Metric	Value
wmc	6
lcom	0
cbo	3
dl	0
loc	44
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	down()	0	6	1
B	up()	0	23	5

<?php

use yii\db\Migration;

class m160219_091156_createUser extends Migration
namespace YourVendor;

class YourClass { }
{
    public function up()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if(isset($_SERVER['TRAVIS'])||(isset($_SERVER['PWD'])&&strpos($_SERVER['PWD'], '/tests/')))
            return null;

        $userName = 'webmaster';

        $tableName = \dektrium\user\models\User::tableName();
        $query = 'SELECT COUNT(*) FROM '.$tableName.' WHERE `username`=:username';
        $count = \Yii::$app->db->createCommand($query, [':username'=>$userName])->queryScalar();
        if($count>0)
            return null;

        $user = \Yii::createObject([
            'class'    => \dektrium\user\models\User::className(),
            'scenario' => 'create',
            'username' => $userName,
            'password' => $userName,
            'email' => $userName.'@yii2enterprise.dev',
        ]);

        return $user->create();
    }

    public function down()
    {
        echo "m160219_091156_createUser cannot be reverted.\n";

        return false;
    }

    /*
    // Use safeUp/safeDown to run migration code within a transaction
    public function safeUp()
    {
    }

    public function safeDown()
    {
    }
    */
}


1			<?php
2
3			use yii\db\Migration;
4
5			class m160219_091156_createUser extends Migration
			0 ignored issues – show Coding Style Compatibility introduced 2016-02-19 10:10 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6			{
7			public function up()
			0 ignored issues – show Coding Style introduced 2016-02-19 12:00 UTC by Report Bug Copy Issue Report `up` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
8			{
9			if(isset($_SERVER['TRAVIS'])\|\|(isset($_SERVER['PWD'])&&strpos($_SERVER['PWD'], '/tests/')))
10			return null;
11
12			$userName = 'webmaster';
13
14			$tableName = \dektrium\user\models\User::tableName();
15			$query = 'SELECT COUNT(*) FROM '.$tableName.' WHERE `username`=:username';
16			$count = \Yii::$app->db->createCommand($query, [':username'=>$userName])->queryScalar();
17			if($count>0)
18			return null;
19
20			$user = \Yii::createObject([
21			'class' => \dektrium\user\models\User::className(),
22			'scenario' => 'create',
23			'username' => $userName,
24			'password' => $userName,
25			'email' => $userName.'@yii2enterprise.dev',
26			]);
27
28			return $user->create();
29			}
30
31			public function down()
32			{
33			echo "m160219_091156_createUser cannot be reverted.\n";
34
35			return false;
36			}
37
38			/*
39			// Use safeUp/safeDown to run migration code within a transaction
40			public function safeUp()
41			{
42			}
43
44			public function safeDown()
45			{
46			}
47			*/
48			}
49

sibds / yii2-enterprise

Push — master ( 26336c...0097a9 )

m160219_091156_createUser A

Complexity

Size/Duplication

Coupling/Cohesion

2 Methods

Duplication Side-by-Side

Filter issues like