BeforeQueryTrait::find() - Code Metrics - Inspection of "Update BeforeQueryTrait.php" - sibds/yii2-activerecord - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cc63dc...6993dc )

by Vadim

created 2016-03-06 18:23 UTC

BeforeQueryTrait::find() B

↳ Parent: BeforeQueryTrait

Complexity

Conditions	5
Paths	6

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	18
rs	8.8571
cc	5
eloc	11
nc	6
nop	0

<?php

namespace sibds\components;

trait BeforeQueryTrait
{

    public static function find()
    {
        /**
         * @var $obj ActiveRecord
         */
        $obj = new static;
        $class = new \ReflectionClass($obj);
        $condition = [];
        foreach ($class->getProperties(\ReflectionProperty::IS_STATIC) as $property) {
            if (strpos($property->getName(), 'BEFORE_QUERY') !== false && is_array($property->getValue($obj))) {
                $condition = array_merge($condition, $property->getValue($obj));
            }
        }
        if($obj->hasAttribute($obj->removedAttribute))
            return  (new \sibds\behaviors\TrashQuery($obj))->findRemoved()->andFilterWhere($condition);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        else
            return parent::find()->andFilterWhere($condition);
    }
}


1			<?php
2
3			namespace sibds\components;
4
5			trait BeforeQueryTrait
6			{
7
8			public static function find()
9			{
10			/**
11			* @var $obj ActiveRecord
12			*/
13			$obj = new static;
14			$class = new \ReflectionClass($obj);
15			$condition = [];
16			foreach ($class->getProperties(\ReflectionProperty::IS_STATIC) as $property) {
17			if (strpos($property->getName(), 'BEFORE_QUERY') !== false && is_array($property->getValue($obj))) {
18			$condition = array_merge($condition, $property->getValue($obj));
19			}
20			}
21			if($obj->hasAttribute($obj->removedAttribute))
22			return (new \sibds\behaviors\TrashQuery($obj))->findRemoved()->andFilterWhere($condition);
			0 ignored issues – show Documentation introduced 2016-03-06 18:29 UTC by Report Bug Copy Issue Report `$obj` is of type `object<sibds\components\ActiveRecord>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
23			else
24			return parent::find()->andFilterWhere($condition);
25			}
26			}
27

sibds / yii2-activerecord

GitHub Access Token became invalid

Push — master ( cc63dc...6993dc )

BeforeQueryTrait::find() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like