UserDataBehavior::init() - Code Metrics - Inspection of "Add LockedBehavior. Fix UserDataBehavior. Update B..." - sibds/yii2-activerecord - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0ebcf3...2447f9 )

by Vadim

created 2016-02-05 08:10 UTC

UserDataBehavior::init() A

↳ Parent: UserDataBehavior

Complexity

Conditions	2
Paths	2

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	1

Metric	Value
c	1
b	1
f	1
dl	0
loc	5
rs	9.4285
cc	2
eloc	3
nc	2
nop	0

<?php
/**
 * Created by PhpStorm.
 * User: vadim
 * Date: 26.05.15
 * Time: 15:12
 */

namespace sibds\behaviors;


use yii\behaviors\BlameableBehavior;

class UserDataBehavior extends BlameableBehavior {

    public $userClass = null;

    public function init()
    {
        if(is_null($this->userClass))
            $this->userClass = \Yii::$app->user->className();
    }

    /**
     * @getCreateUser
     * @return null|\yii\db\ActiveQuery
     */
    public function getCreateUser()

    {
        /* @var $owner BaseActiveRecord */
        $owner = $this->owner;

        if ($owner->hasAttribute($this->createdByAttribute) && $owner->hasAttribute($this->updatedByAttribute))
            return $owner->hasOne($this->userClass, ['id' => $this->createdByAttribute]);

        return null;
    }

    /**
     * @getCreateUserName
     * @return null|\yii\db\ActiveQuery
     */
    public function getCreateUserName()

    {
        /* @var $owner BaseActiveRecord */
        $owner = $this->owner;

        if ($owner->hasAttribute($this->createdByAttribute) && $owner->hasAttribute($this->updatedByAttribute))
            return $this->createUser ? $this->createUser->username : '- no user -';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return null;
    }

    /**
     * @getUpdateUser
     * @return null|\yii\db\ActiveQuery
     */
    public function getUpdateUser()

    {
        /* @var $owner BaseActiveRecord */
        $owner = $this->owner;

        if ($owner->hasAttribute($this->createdByAttribute) && $owner->hasAttribute($this->updatedByAttribute))
            return $this->hasOne($this->userClass, ['id' => $this->updatedByAttribute]);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        return null;
    }

    /**
     * @getUpdateUserName
     * @return null|\yii\db\ActiveQuery
     */
    public function getUpdateUserName()

    {
        /* @var $owner BaseActiveRecord */
        $owner = $this->owner;

        if ($owner->hasAttribute($this->createdByAttribute) && $owner->hasAttribute($this->updatedByAttribute))
            return $this->createUser ? $this->updateUser->username : '- no user -';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return null;
    }
}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: vadim
5		* Date: 26.05.15
6		* Time: 15:12
7		*/
8
9		namespace sibds\behaviors;
10
11
12		use yii\behaviors\BlameableBehavior;
13
14		class UserDataBehavior extends BlameableBehavior {
15
16		public $userClass = null;
17
18		public function init()
19		{
20		if(is_null($this->userClass))
21		$this->userClass = \Yii::$app->user->className();
22		}
23
24		/**
25		* @getCreateUser
26		* @return null\|\yii\db\ActiveQuery
27		*/
28	View Code Duplication	public function getCreateUser()
		0 ignored issues – show Duplication introduced 2016-01-31 17:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		{
30		/* @var $owner BaseActiveRecord */
31		$owner = $this->owner;
32
33		if ($owner->hasAttribute($this->createdByAttribute) && $owner->hasAttribute($this->updatedByAttribute))
34		return $owner->hasOne($this->userClass, ['id' => $this->createdByAttribute]);
35
36		return null;
37		}
38
39		/**
40		* @getCreateUserName
41		* @return null\|\yii\db\ActiveQuery
42		*/
43	View Code Duplication	public function getCreateUserName()
		0 ignored issues – show Duplication introduced 2016-01-31 17:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		{
45		/* @var $owner BaseActiveRecord */
46		$owner = $this->owner;
47
48		if ($owner->hasAttribute($this->createdByAttribute) && $owner->hasAttribute($this->updatedByAttribute))
49		return $this->createUser ? $this->createUser->username : '- no user -';
		0 ignored issues – show Documentation introduced 2016-01-31 17:59 UTC by Report Bug Copy Issue Report The property `createUser` does not exist on `object<sibds\behaviors\UserDataBehavior>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
50
51		return null;
52		}
53
54		/**
55		* @getUpdateUser
56		* @return null\|\yii\db\ActiveQuery
57		*/
58	View Code Duplication	public function getUpdateUser()
		0 ignored issues – show Duplication introduced 2016-01-31 17:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59		{
60		/* @var $owner BaseActiveRecord */
61		$owner = $this->owner;
62
63		if ($owner->hasAttribute($this->createdByAttribute) && $owner->hasAttribute($this->updatedByAttribute))
64		return $this->hasOne($this->userClass, ['id' => $this->updatedByAttribute]);
		0 ignored issues – show Documentation Bug introduced 2016-01-31 17:59 UTC by Report Bug Copy Issue Report The method `hasOne` does not exist on `object<sibds\behaviors\UserDataBehavior>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
65
66		return null;
67		}
68
69		/**
70		* @getUpdateUserName
71		* @return null\|\yii\db\ActiveQuery
72		*/
73	View Code Duplication	public function getUpdateUserName()
		0 ignored issues – show Duplication introduced 2016-01-31 17:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
74		{
75		/* @var $owner BaseActiveRecord */
76		$owner = $this->owner;
77
78		if ($owner->hasAttribute($this->createdByAttribute) && $owner->hasAttribute($this->updatedByAttribute))
79		return $this->createUser ? $this->updateUser->username : '- no user -';
		0 ignored issues – show Documentation introduced 2016-01-31 17:59 UTC by Report Bug Copy Issue Report The property `createUser` does not exist on `object<sibds\behaviors\UserDataBehavior>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-01-31 17:59 UTC by Report Bug Copy Issue Report The property `updateUser` does not exist on `object<sibds\behaviors\UserDataBehavior>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
80
81		return null;
82		}
83		}

sibds / yii2-activerecord

GitHub Access Token became invalid

Push — master ( 0ebcf3...2447f9 )

UserDataBehavior::init() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like