SettingsAction::run() - Code Metrics - Inspection of "Add tests for autodetect setting type" - shurik2k5/yii2-settings - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 366f5a...9cc24d )

by Alex

created 2019-04-17 16:05 UTC

SettingsAction::run() B

↳ Parent: SettingsAction

Complexity

Conditions	7
Paths	16

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	23
rs	8.6186
c	0
b	0
f	0
cc	7
nc	16
nop	0

<?php
namespace pheme\settings;

use Yii;
use yii\base\Action;

class SettingsAction extends Action
{
    /**
     * @var string class name of the model which will be used to validate the attributes.
     * The class should have a scenario matching the `scenario` variable.
     * The model class must implement [[Model]].
     * This property must be set.
     */
    public $modelClass;

    /**
     * @var string The scenario this model should use to make validation
     */
    public $scenario;

    /**
     * @var string the name of the view to generate the form. Defaults to 'settings'.
     */
    public $viewName = 'settings';

    /**
     * @var string name on section. Default is ModelClass formname
     */
    public $section = null;

    /**
     * Render the settings form.
     */
    public function run()
    {
        /* @var $model \yii\db\ActiveRecord */
        $model = new $this->modelClass();
        $section = ($this->section !== null) ? $this->section : $model->formName();
        if ($this->scenario) {
            $model->setScenario($this->scenario);
        }
        if ($model->load(Yii::$app->request->post()) && $model->validate()) {
            foreach ($model->toArray() as $key => $value) {
                Yii::$app->settings->set($key, $value, $section);
            }
            Yii::$app->getSession()->addFlash('success',
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                Module::t('settings', 'Successfully saved settings on {section}',
                    ['section' => $model->formName()]
                )
            );
        }
        foreach ($model->attributes() as $key) {
            $model->{$key} = Yii::$app->settings->get($key, $section);
        }
        return $this->controller->render($this->viewName, ['model' => $model]);
    }
}


1			<?php
2			namespace pheme\settings;
3
4			use Yii;
5			use yii\base\Action;
6
7			class SettingsAction extends Action
8			{
9			/**
10			* @var string class name of the model which will be used to validate the attributes.
11			* The class should have a scenario matching the `scenario` variable.
12			* The model class must implement [[Model]].
13			* This property must be set.
14			*/
15			public $modelClass;
16
17			/**
18			* @var string The scenario this model should use to make validation
19			*/
20			public $scenario;
21
22			/**
23			* @var string the name of the view to generate the form. Defaults to 'settings'.
24			*/
25			public $viewName = 'settings';
26
27			/**
28			* @var string name on section. Default is ModelClass formname
29			*/
30			public $section = null;
31
32			/**
33			* Render the settings form.
34			*/
35			public function run()
36			{
37			/* @var $model \yii\db\ActiveRecord */
38			$model = new $this->modelClass();
39			$section = ($this->section !== null) ? $this->section : $model->formName();
40			if ($this->scenario) {
41			$model->setScenario($this->scenario);
42			}
43			if ($model->load(Yii::$app->request->post()) && $model->validate()) {
44			foreach ($model->toArray() as $key => $value) {
45			Yii::$app->settings->set($key, $value, $section);
46			}
47			Yii::$app->getSession()->addFlash('success',
			0 ignored issues – show Bug introduced 2019-04-17 13:21 UTC by Report Bug Copy Issue Report The method `getSession` does only exist in `yii\web\Application`, but not in `yii\console\Application`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
48			Module::t('settings', 'Successfully saved settings on {section}',
49			['section' => $model->formName()]
50			)
51			);
52			}
53			foreach ($model->attributes() as $key) {
54			$model->{$key} = Yii::$app->settings->get($key, $section);
55			}
56			return $this->controller->render($this->viewName, ['model' => $model]);
57			}
58			}
59

shurik2k5 / yii2-settings

Push — master ( 366f5a...9cc24d )

SettingsAction::run() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like