FormatterTrait::level() - Code Metrics - Inspection of "Use trait" - shrikeh/guzzle-middleware-responsetimer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4)

by Barney

created 2017-09-26 11:26 UTC

FormatterTrait::level() A

↳ Parent: FormatterTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	3

<?php
/**
 * @codingStandardsIgnoreStart
 *
 * @author       Barney Hanlon <[email protected]>
 * @copyright    Barney Hanlon 2017
 * @license      https://opensource.org/licenses/MIT
 *
 * @codingStandardsIgnoreEnd
 */

namespace Shrikeh\GuzzleMiddleware\TimerLogger\Formatter;

use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;
use Shrikeh\GuzzleMiddleware\TimerLogger\Timer\TimerInterface;

/**
 * Trait FormatterTrait
 */
trait FormatterTrait
{
    /**
     * @var string|callable
     */
    private $msg;

    /**
     * @var string|callable
     */
    private $level;

    /**
     * @param \Shrikeh\GuzzleMiddleware\TimerLogger\Timer\TimerInterface $timer    A Timer to format
     * @param \Psr\Http\Message\RequestInterface                         $request  A Request to format
     * @param \Psr\Http\Message\ResponseInterface|null                   $response The Response to format
     *
     * @return string
     */
    private function msg(
        TimerInterface $timer,
        RequestInterface $request,
        ResponseInterface $response = null
    ) {
        $msg = $this->msg;

        return $msg($timer, $request, $response);
    }

    /**
     * @param \Shrikeh\GuzzleMiddleware\TimerLogger\Timer\TimerInterface $timer    A Timer to format
     * @param \Psr\Http\Message\RequestInterface                         $request  A Request to format
     * @param \Psr\Http\Message\ResponseInterface|null                   $response The Response to format
     *
     * @return string
     */
    private function level(
        TimerInterface $timer,
        RequestInterface $request,
        ResponseInterface $response = null
    ) {
        $level = $this->level;

        if (is_callable($level)) {
            $level = $level($timer, $request, $response);
        }

        return $level;

    }
}


1			<?php
2			/**
3			* @codingStandardsIgnoreStart
4			*
5			* @author Barney Hanlon <[email protected]>
6			* @copyright Barney Hanlon 2017
7			* @license https://opensource.org/licenses/MIT
8			*
9			* @codingStandardsIgnoreEnd
10			*/
11
12			namespace Shrikeh\GuzzleMiddleware\TimerLogger\Formatter;
13
14			use Psr\Http\Message\RequestInterface;
15			use Psr\Http\Message\ResponseInterface;
16			use Shrikeh\GuzzleMiddleware\TimerLogger\Timer\TimerInterface;
17
18			/**
19			* Trait FormatterTrait
20			*/
21			trait FormatterTrait
22			{
23			/**
24			* @var string\|callable
25			*/
26			private $msg;
27
28			/**
29			* @var string\|callable
30			*/
31			private $level;
32
33			/**
34			* @param \Shrikeh\GuzzleMiddleware\TimerLogger\Timer\TimerInterface $timer A Timer to format
35			* @param \Psr\Http\Message\RequestInterface $request A Request to format
36			* @param \Psr\Http\Message\ResponseInterface\|null $response The Response to format
37			*
38			* @return string
39			*/
40			private function msg(
41			TimerInterface $timer,
42			RequestInterface $request,
43			ResponseInterface $response = null
44			) {
45			$msg = $this->msg;
46
47			return $msg($timer, $request, $response);
48			}
49
50			/**
51			* @param \Shrikeh\GuzzleMiddleware\TimerLogger\Timer\TimerInterface $timer A Timer to format
52			* @param \Psr\Http\Message\RequestInterface $request A Request to format
53			* @param \Psr\Http\Message\ResponseInterface\|null $response The Response to format
54			*
55			* @return string
56			*/
57			private function level(
58			TimerInterface $timer,
59			RequestInterface $request,
60			ResponseInterface $response = null
61			) {
62			$level = $this->level;
63
64			if (is_callable($level)) {
65			$level = $level($timer, $request, $response);
66			}
67
68			return $level;
			0 ignored issues – show Bug Best Practice introduced 2017-09-26 11:28 UTC by Report Bug Copy Issue Report The expression `return $level` also could return the type `callable` which is incompatible with the documented return type `string`. Loading history...
69			}
70			}
71

shrikeh / guzzle-middleware-responsetimer

Pull Request — master (#4)

FormatterTrait::level() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like