Users::findById() - Code Metrics - shrikeh-pagerduty/pagerduty-core - Measure and Improve Code Quality continuously with Scrutinizer

Users::findById() A
last analyzed 2016-10-19 13:27 UTC

↳ Parent: Users

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	8
nc	1
nop	2

<?php

namespace Shrikeh\PagerDuty\Repository\Users;

use Shrikeh\PagerDuty\Client;
use Shrikeh\PagerDuty\Repository\Users as UsersRepositoryInterface;
use Shrikeh\PagerDuty\Collection\Users as UserCollection;
use GuzzleHttp\Psr7\Uri;

use Shrikeh\PagerDuty\Hydrator;

final class Users implements UsersRepositoryInterface
{
    private $client;

    private $hydrator;

    public function __construct(
        Client $client,
        Hydrator $hydrator
    ) {
        $this->client   = $client;
        $this->hydrator = $hydrator;
    }

    public function get()
    {

    }

    public function findById($id, array $extras = array())
    {
      $response = $this->client->request(
          'GET',
          sprintf('%s/%s', static::ENDPOINT, $id),
          ['query' => $this->query($extras)]
      );

      $dto = json_decode($response->getBody());
      $users[] = $this->hydrator->hydrate($dto->user);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
      return UserCollection::fromArray($users);
    }

    private function query(array $extras = array())
    {
        $query = [];
        foreach ($extras as $extra) {
            $query[] = ['include[]' => $extra];
        }
        $newQuery = [];
        foreach ($query as $part) {
          foreach ($part as $key => $value) {
              $newQuery[] = "$key=$value";
          }
        }
        return implode('&', $newQuery);
    }
}


1			<?php
2
3			namespace Shrikeh\PagerDuty\Repository\Users;
4
5			use Shrikeh\PagerDuty\Client;
6			use Shrikeh\PagerDuty\Repository\Users as UsersRepositoryInterface;
7			use Shrikeh\PagerDuty\Collection\Users as UserCollection;
8			use GuzzleHttp\Psr7\Uri;
9
10			use Shrikeh\PagerDuty\Hydrator;
11
12			final class Users implements UsersRepositoryInterface
13			{
14			private $client;
15
16			private $hydrator;
17
18			public function __construct(
19			Client $client,
20			Hydrator $hydrator
21			) {
22			$this->client = $client;
23			$this->hydrator = $hydrator;
24			}
25
26			public function get()
27			{
28
29			}
30
31			public function findById($id, array $extras = array())
32			{
33			$response = $this->client->request(
34			'GET',
35			sprintf('%s/%s', static::ENDPOINT, $id),
36			['query' => $this->query($extras)]
37			);
38
39			$dto = json_decode($response->getBody());
40			$users[] = $this->hydrator->hydrate($dto->user);
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-10-12 13:13 UTC by Report Bug Copy Issue Report `$users` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$users = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
41			return UserCollection::fromArray($users);
42			}
43
44			private function query(array $extras = array())
45			{
46			$query = [];
47			foreach ($extras as $extra) {
48			$query[] = ['include[]' => $extra];
49			}
50			$newQuery = [];
51			foreach ($query as $part) {
52			foreach ($part as $key => $value) {
53			$newQuery[] = "$key=$value";
54			}
55			}
56			return implode('&', $newQuery);
57			}
58			}
59

shrikeh-pagerduty / pagerduty-core

Users::findById() A last analyzed 2016-10-19 13:27 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Users::findById() A
last analyzed 2016-10-19 13:27 UTC