ScriptFinder::findScriptByName() - Code Metrics - Inspection of "Bugfix/#21 #22 improve error handling" - shopwareLabs/psh - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#24)

by Thomas

created 2017-02-09 12:11 UTC

ScriptFinder::findScriptByName() A

↳ Parent: ScriptFinder

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	5
nc	3
nop	1

<?php declare(strict_types=1);


namespace Shopware\Psh\Listing;

/**
 * Load all scripts from all the supplied paths and create an array of scripts
 */
class ScriptFinder
{
    const VALID_EXTENSIONS = [
        'sh',
        'psh'
    ];

    /**
     * @var string[]
     */
    private $scriptPaths;

    /**
     * @param string[] $scriptPaths
     */
    public function __construct(array $scriptPaths)
    {
        $this->scriptPaths = $scriptPaths;
    }

    /**
     * @return Script[]
     * @throws ScriptPathNotValidException
     */
    public function getAllScripts(): array
    {
        $scripts = [];

        foreach ($this->scriptPaths as $pathNamespace => $path) {
            if (!is_dir($path)) {
                throw new ScriptPathNotValidException("The given script path: '{$path}' is not a valid directory");
            }

            foreach (scandir($path) as $fileName) {
                $scriptNamespace = null;

                if (strpos($fileName, '.') === 0) {
                    continue;
                }

                $extension = pathinfo($fileName, PATHINFO_EXTENSION);

                if (!in_array($extension, self::VALID_EXTENSIONS)) {
                    continue;
                }

                if (!is_numeric($pathNamespace)) {
                    $scriptNamespace = $pathNamespace;
                }

                $scripts[] = new Script($path, $fileName, $scriptNamespace);
            }
        }

        return $scripts;
    }

    /**
     * @param string $scriptName
     * @return Script
     * @throws ScriptNotFoundException
     */
    public function findScriptByName(string $scriptName): Script
    {
        foreach ($this->getAllScripts() as $script) {
            if ($script->getName() === $scriptName) {
                return $script;
            }
        }

        throw new ScriptNotFoundException('Unable to find script named "' . $scriptName . '"');
    }
}


1			<?php declare(strict_types=1);
2
3
4			namespace Shopware\Psh\Listing;
5
6			/**
7			* Load all scripts from all the supplied paths and create an array of scripts
8			*/
9			class ScriptFinder
10			{
11			const VALID_EXTENSIONS = [
12			'sh',
13			'psh'
14			];
15
16			/**
17			* @var string[]
18			*/
19			private $scriptPaths;
20
21			/**
22			* @param string[] $scriptPaths
23			*/
24			public function __construct(array $scriptPaths)
25			{
26			$this->scriptPaths = $scriptPaths;
27			}
28
29			/**
30			* @return Script[]
31			* @throws ScriptPathNotValidException
32			*/
33			public function getAllScripts(): array
34			{
35			$scripts = [];
36
37			foreach ($this->scriptPaths as $pathNamespace => $path) {
38			if (!is_dir($path)) {
39			throw new ScriptPathNotValidException("The given script path: '{$path}' is not a valid directory");
40			}
41
42			foreach (scandir($path) as $fileName) {
43			$scriptNamespace = null;
44
45			if (strpos($fileName, '.') === 0) {
46			continue;
47			}
48
49			$extension = pathinfo($fileName, PATHINFO_EXTENSION);
50
51			if (!in_array($extension, self::VALID_EXTENSIONS)) {
52			continue;
53			}
54
55			if (!is_numeric($pathNamespace)) {
56			$scriptNamespace = $pathNamespace;
57			}
58
59			$scripts[] = new Script($path, $fileName, $scriptNamespace);
60			}
61			}
62
63			return $scripts;
64			}
65
66			/**
67			* @param string $scriptName
68			* @return Script
69			* @throws ScriptNotFoundException
70			*/
71			public function findScriptByName(string $scriptName): Script
72			{
73			foreach ($this->getAllScripts() as $script) {
74			if ($script->getName() === $scriptName) {
75			return $script;
76			}
77			}
78
79			throw new ScriptNotFoundException('Unable to find script named "' . $scriptName . '"');
80			}
81			}
82

shopwareLabs / psh

Pull Request — master (#24)

ScriptFinder::findScriptByName() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like