Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php declare(strict_types=1); |
||
5 | class ConfigMerger |
||
6 | { |
||
7 | /** |
||
8 | * @param Config $config |
||
9 | * @param Config|null $override |
||
10 | * @return Config |
||
11 | */ |
||
12 | public function merge(Config $config, Config $override = null): Config |
||
36 | |||
37 | /** |
||
38 | * @param Config $config |
||
39 | * @param Config $override |
||
40 | * @return array |
||
41 | */ |
||
42 | private function mergeConfigEnvironments(Config $config, Config $override): array |
||
67 | |||
68 | private function mergeEnvironments(ConfigEnvironment $original, ConfigEnvironment $override): ConfigEnvironment |
||
79 | |||
80 | /** |
||
81 | * @param ConfigEnvironment $configEnvironment |
||
82 | * @param ConfigEnvironment $overrideEnv |
||
83 | * @return array |
||
84 | */ |
||
85 | private function mergeDynamicVariables(ConfigEnvironment $configEnvironment, ConfigEnvironment $overrideEnv): array |
||
89 | |||
90 | /** |
||
91 | * @param ConfigEnvironment $configEnvironment |
||
92 | * @param ConfigEnvironment $overrideConfigEnv |
||
93 | * @return ScriptsPath[] |
||
94 | */ |
||
95 | private function mergeDotenvPaths(ConfigEnvironment $configEnvironment, ConfigEnvironment $overrideConfigEnv): array |
||
99 | |||
100 | /** |
||
101 | * @param ConfigEnvironment $configEnvironment |
||
102 | * @param ConfigEnvironment $overrideConfigEnv |
||
103 | * @return ScriptsPath[] |
||
104 | */ |
||
105 | private function overrideScriptsPaths(ConfigEnvironment $configEnvironment, ConfigEnvironment $overrideConfigEnv): array |
||
113 | |||
114 | /** |
||
115 | * @param ConfigEnvironment $configEnvironment |
||
116 | * @param ConfigEnvironment $overrideConfigEnv |
||
117 | * @return array |
||
118 | */ |
||
119 | private function mergeConstants(ConfigEnvironment $configEnvironment, ConfigEnvironment $overrideConfigEnv): array |
||
123 | |||
124 | /** |
||
125 | * @param ConfigEnvironment $configEnvironment |
||
126 | * @param $overrideConfigEnv |
||
127 | * @return array |
||
128 | */ |
||
129 | private function overrideTemplates(ConfigEnvironment $configEnvironment, ConfigEnvironment $overrideConfigEnv): array |
||
137 | |||
138 | private function overrideHidden(ConfigEnvironment $originalConfigEnv, ConfigEnvironment $overrideEnv): bool |
||
146 | } |
||
147 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.