Shopware\Psh\Config\ConfigFactory

Complexity

Total Complexity

14

Size/Duplication

Total Lines	118
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	loadImports()	0	34	6
A	mergeConfigs()	0	10	2
A	__construct()	0	11	1
A	gatherConfigs()	0	31	5

<?php declare(strict_types=1);

namespace Shopware\Psh\Config;

use function array_merge;
use function array_pop;
use function array_shift;
use function count;
use function dirname;
use function glob;
use function is_dir;

class ConfigFactory
{
    /**
     * @var ConfigMerger
     */
    private $configMerger;

    /**
     * @var ConfigFileFinder
     */
    private $configFileFinder;

    /**
     * @var ConfigFileLoader[]
     */
    private $configLoaders;

    /**
     * @var ConfigLogger
     */
    private $configLogger;

    public function __construct(
        ConfigMerger $configMerger,
        ConfigFileFinder $configFileFinder,
        ConfigLogger $configLogger,
        array $configLoaders
    ) {
        $this->configMerger = $configMerger;
        $this->configFileFinder = $configFileFinder;
        $this->configLoaders = $configLoaders;
        $this->configLogger = $configLogger;
    }

    /**
     * @return Config[]
     */
    public function gatherConfigs(
        array $configFiles,
        array $overwrittenConsts
    ): array {
        $configs = [];
        $additionalConfigs = [[]];

        foreach ($configFiles as $configFile) {
            foreach ($this->configLoaders as $configLoader) {
                if (!$configLoader->isSupported($configFile)) {
                    continue;
                }

                $config = $configLoader
                    ->load($configFile, $overwrittenConsts);

                $additionalConfigs[] = $this
                    ->loadImports($config, dirname($configFile), $overwrittenConsts);

                $configs[] = $config;
            }
        }

        if (!$configs) {

The expression $configs of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return [];
        }

        $config = $this->configMerger->mergeOverride(...$configs);

$configs is of type array, but the function expects a object<Shopware\Psh\Config\Config>.

        return array_merge([$config], ...array_merge(...$additionalConfigs));
    }

    private function loadImports(
        Config $config,
        string $fromPath,
        array $overwrittenConsts
    ): array {
        $additionalConfigs = [];

        foreach ($config->getImports() as $importPath) {
            $foundSomething = false;
            foreach (glob($fromPath . '/' . $importPath) as $foundOccurrence) {
                if (!is_dir($foundOccurrence)) {
                    continue;
                }

                $foundConfigFiles = $this->configFileFinder
                    ->discoverConfigInDirectory($foundOccurrence);

                if (count($foundConfigFiles) === 0) {
                    continue;
                }

                $foundSomething = true;
                $this->configLogger->importConfigFiles($importPath, ...$foundConfigFiles);

$foundConfigFiles is of type array, but the function expects a string.

                $additionalConfigs[] = $this
                    ->gatherConfigs($foundConfigFiles, $overwrittenConsts);
            }

            if (!$foundSomething) {
                $this->configLogger->notifyImportNotFound($importPath);
            }
        }

        return $additionalConfigs;
    }

    /**
     * @param Config[] $configs
     */
    public function mergeConfigs(array $configs): Config
    {
        $mainConfig = array_shift($configs);

        while (count($configs) !== 0) {
            $mainConfig = $this->configMerger->mergeImport($mainConfig, array_pop($configs));

It seems like $mainConfig can be null; however, mergeImport() does not accept null, maybe add an additional type check?

        }

        return $mainConfig;
    }
}