NoSuperGlobalsInsideCompilerPassRule::processNode() - Code Metrics - Inspection of "Merge branch 'next-21195/remove-env-inside-compile..." - shopware/platform - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — trunk ( 516571...cb9bb6 )

by Christian

created 2022-10-29 22:36 UTC

processNode() A

↳ Parent: NoSuperGlobalsInsideCompilerPassRule

Complexity

Conditions	5
Paths	5

Size

Total Lines	21
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	10
nc	5
nop	2
dl	0
loc	21
rs	9.6111
c	1
b	0
f	0

<?php declare(strict_types=1);

namespace Shopware\Core\DevOps\StaticAnalyze\PHPStan\Rules;

use PhpParser\Node;
use PhpParser\Node\Expr\ArrayDimFetch;
use PHPStan\Analyser\Scope;
filter:
    dependency_paths: ["lib/*"]
use PHPStan\Rules\Rule;
filter:
    dependency_paths: ["lib/*"]
use PHPStan\Rules\RuleError;
filter:
    dependency_paths: ["lib/*"]
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;

/**
 * @internal
 *
 * @implements Rule<ArrayDimFetch>
 */
class NoSuperGlobalsInsideCompilerPassRule implements Rule
{
    public function getNodeType(): string
    {
        return ArrayDimFetch::class;
    }

    /**
     * @param ArrayDimFetch $node
     *
     * @return array<array-key, RuleError|string>

     */
    public function processNode(Node $node, Scope $scope): array
    {
        $class = $scope->getClassReflection();

        if ($class === null) {
            return [];
        }

        if (!$class->implementsInterface(CompilerPassInterface::class)) {
            return [];
        }

        if (!$node->var instanceof Node\Expr\Variable) {

            return [];
        }

        if (!\in_array($node->var->name, ['_GET', '_POST', '_COOKIE', '_SERVER', '_FILES', '_REQUEST'], true)) {
            return [];
        }

        return ['Do not use super globals inside compiler passes.'];
    }
}


1			<?php declare(strict_types=1);
2
3			namespace Shopware\Core\DevOps\StaticAnalyze\PHPStan\Rules;
4
5			use PhpParser\Node;
6			use PhpParser\Node\Expr\ArrayDimFetch;
7			use PHPStan\Analyser\Scope;
			0 ignored issues – show Bug introduced 2022-10-29 22:45 UTC by Report Bug Copy Issue Report The type `PHPStan\Analyser\Scope` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
8			use PHPStan\Rules\Rule;
			0 ignored issues – show Bug introduced 2022-01-05 09:55 UTC by Report Bug Copy Issue Report The type `PHPStan\Rules\Rule` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
9			use PHPStan\Rules\RuleError;
			0 ignored issues – show Bug introduced 2022-10-29 22:45 UTC by Report Bug Copy Issue Report The type `PHPStan\Rules\RuleError` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
10			use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
11
12			/**
13			* @internal
14			*
15			* @implements Rule<ArrayDimFetch>
16			*/
17			class NoSuperGlobalsInsideCompilerPassRule implements Rule
18			{
19			public function getNodeType(): string
20			{
21			return ArrayDimFetch::class;
22			}
23
24			/**
25			* @param ArrayDimFetch $node
26			*
27			* @return array<array-key, RuleError\|string>
			0 ignored issues – show Documentation Bug introduced 2022-01-05 09:55 UTC by Report Bug Copy Issue Report The doc comment `array<array-key, RuleError\|string>` at position `2` could not be parsed: Unknown type name 'array-key' at position 2 in array<array-key, RuleError\|string>. Loading history...
28			*/
29			public function processNode(Node $node, Scope $scope): array
30			{
31			$class = $scope->getClassReflection();
32
33			if ($class === null) {
34			return [];
35			}
36
37			if (!$class->implementsInterface(CompilerPassInterface::class)) {
38			return [];
39			}
40
41			if (!$node->var instanceof Node\Expr\Variable) {
			0 ignored issues – show Bug introduced 2022-10-29 22:45 UTC by Report Bug Copy Issue Report Accessing `var` on the interface `PhpParser\Node` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
42			return [];
43			}
44
45			if (!\in_array($node->var->name, ['_GET', '_POST', '_COOKIE', '_SERVER', '_FILES', '_REQUEST'], true)) {
46			return [];
47			}
48
49			return ['Do not use super globals inside compiler passes.'];
50			}
51			}
52

shopware / platform

Push — trunk ( 516571...cb9bb6 )

processNode() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like