app.js ➔ showLog - Code Metrics - Inspection of "Merge branch 'next-24090/cherry-pick' into '6.5.0...." - shopware/platform - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — 6.5.0.0 ( 85bd4e...fe6596 )

by Christian

created 2023-03-08 09:49 UTC

app.js ➔ showLog F

↳ Parent: src/WebInstaller/src/Resources/public/assets/app.js

Complexity

Conditions

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	16
eloc	2
dl	0
loc	3
rs	2.4
c	0
b	0
f	0

How to fix Complexity

const decoder = new TextDecoder();


async function tailLog(response, element) {
    const reader = response.body.getReader();

    while (true) {
        const {value, done} = await reader.read();
        if (done) break;
if (a > 0)
    b = 42;

        const text = decoder.decode(value);

        let result = null

        try {
            let strings = text.split("\n");
            result = JSON.parse(strings.pop());

            element.innerHTML += strings.join("\n");
            element.scrollTop = element.scrollHeight;
        } catch (e) {
            element.innerHTML += text;
            element.scrollTop = element.scrollHeight;
        }

        if (result) {
            if (!result.success) {
                throw new Error('update failed');
            }

            return result
        }
    }

    throw new Error('Unexpected end of stream');
}

const installButton = document.getElementById('install-start');
const updateButton = document.getElementById('update-start');
const logCard = document.getElementById('log-card');
const logOutput = document.getElementById('log-output');
const logError = document.getElementById('log-error');

if (installButton) {
    installButton.onclick = async function () {
        logCard.style.removeProperty('display');

        installButton.disabled = true;

        const folder = document.getElementById('folder');

        const installResponse = await fetch(`${baseUrl}/install/_run?folder=` + folder.value, {method: 'POST'});


        try {
            const result = await tailLog(installResponse, logOutput);
            if (result.newLocation) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
                window.location = result.newLocation;

            }
        } catch (e) {
            console.log(e);

            return showLog();
        }
    }
}

if (updateButton) {
    updateButton.onclick = async function () {
        updateButton.disabled = true;
        logCard.style.removeProperty('display');

        const prepareUpdate = await fetch(`${baseUrl}/update/_prepare`, {method: 'POST'})

        if (prepareUpdate.status !== 200) {
            logOutput.innerHTML += 'Failed to prepare update' + "\n"
            return showLog();
        } else {

            try {
                await tailLog(prepareUpdate, logOutput);
            } catch (e) {
                return showLog();
            }
        }

        if (!isFlexProject) {

            logOutput.innerHTML += 'Updating to Flex Project' + "\n"

            const migrate = await fetch(`${baseUrl}/update/_migrate-template`, {method: 'POST'})

            if (migrate.status !== 204 && migrate.status !== 200) {
                logOutput.innerHTML += 'Failed to update to Flex Project' + "\n"
                logOutput.innerHTML += await migrate.text();
                return showLog();
            } else {

                logOutput.innerHTML += 'Updated to Flex Project' + "\n"
            }
        }

        const updateRun = await fetch(`${baseUrl}/update/_run`, {method: 'POST'});

        try {
            await tailLog(updateRun, logOutput);
        } catch (e) {
            return showLog();
        }

        const resetConfig = await fetch(`${baseUrl}/update/_reset_config`, {method: 'POST'});

        if (resetConfig.status !== 200) {
            logOutput.innerHTML += 'Failed to update config files' + "\n"
            logOutput.innerHTML += await resetConfig.text();
        } else {
            try {
                await tailLog(resetConfig, logOutput);
            } catch (e) {
                return showLog();
            }
        }

        const finishUpdate = await fetch(`${baseUrl}/update/_finish`, {method: 'POST'})
        if (finishUpdate.status !== 200) {
            logOutput.innerHTML += 'Failed to prepare update' + "\n"
            logOutput.innerHTML += await finishUpdate.text();
        } else {
            try {
                await tailLog(finishUpdate, logOutput);
            } catch (e) {
                return showLog();
            }
        }

        window.location.href = `${baseUrl}/finish`;

    }
}

function showLog() {
    logError.style.removeProperty('display');
}

const downloadLogButton = document.getElementById('download-log');

if (downloadLogButton) {
    downloadLogButton.onclick = function () {
        const text = new Blob([logOutput.innerText], {type: 'text/plain'});

        const element = document.createElement('a');
        element.href = URL.createObjectURL(text);

        element.setAttribute('download', 'log.txt');

        element.style.display = 'none';
        document.body.appendChild(element);

        element.click();

        document.body.removeChild(element);
    }
}


1			const decoder = new TextDecoder();
			0 ignored issues – show Bug introduced 2023-02-22 11:21 UTC by Report Bug Copy Issue Report The variable `TextDecoder` seems to be never declared. If this is a global, consider adding a `/** global: TextDecoder */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
2
3			async function tailLog(response, element) {
4			const reader = response.body.getReader();
5
6			while (true) {
7			const {value, done} = await reader.read();
8			if (done) break;
			0 ignored issues – show Coding Style Best Practice introduced 2023-02-22 11:21 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
9
10			const text = decoder.decode(value);
11
12			let result = null
13
14			try {
15			let strings = text.split("\n");
16			result = JSON.parse(strings.pop());
17
18			element.innerHTML += strings.join("\n");
19			element.scrollTop = element.scrollHeight;
20			} catch (e) {
21			element.innerHTML += text;
22			element.scrollTop = element.scrollHeight;
23			}
24
25			if (result) {
26			if (!result.success) {
27			throw new Error('update failed');
28			}
29
30			return result
31			}
32			}
33
34			throw new Error('Unexpected end of stream');
35			}
36
37			const installButton = document.getElementById('install-start');
38			const updateButton = document.getElementById('update-start');
39			const logCard = document.getElementById('log-card');
40			const logOutput = document.getElementById('log-output');
41			const logError = document.getElementById('log-error');
42
43			if (installButton) {
44			installButton.onclick = async function () {
45			logCard.style.removeProperty('display');
46
47			installButton.disabled = true;
48
49			const folder = document.getElementById('folder');
50
51			const installResponse = await fetch(`${baseUrl}/install/_run?folder=` + folder.value, {method: 'POST'});
			0 ignored issues – show Bug introduced 2023-02-22 11:21 UTC by Report Bug Copy Issue Report The variable `baseUrl` seems to be never declared. If this is a global, consider adding a `/** global: baseUrl */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
52
53			try {
54			const result = await tailLog(installResponse, logOutput);
55			if (result.newLocation) {
			0 ignored issues – show Complexity Best Practice introduced 2023-02-22 11:21 UTC by Report Bug Copy Issue Report There is no return statement if `result.newLocation` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
56			window.location = result.newLocation;
			0 ignored issues – show Best Practice introduced 2023-02-22 11:21 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
57			}
58			} catch (e) {
59			console.log(e);
			0 ignored issues – show Debugging Code introduced 2023-02-22 11:21 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
60			return showLog();
61			}
62			}
63			}
64
65			if (updateButton) {
66			updateButton.onclick = async function () {
67			updateButton.disabled = true;
68			logCard.style.removeProperty('display');
69
70			const prepareUpdate = await fetch(`${baseUrl}/update/_prepare`, {method: 'POST'})
			0 ignored issues – show Bug introduced 2023-02-22 11:21 UTC by Report Bug Copy Issue Report The variable `baseUrl` seems to be never declared. If this is a global, consider adding a `/** global: baseUrl */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
71			if (prepareUpdate.status !== 200) {
72			logOutput.innerHTML += 'Failed to prepare update' + "\n"
73			return showLog();
74			} else {
			0 ignored issues – show Comprehensibility introduced 2023-02-22 11:21 UTC by Report Bug Copy Issue Report `else` is not necessary here since all `if` branches return, consider removing it to reduce nesting and make code more readable. Loading history...
75			try {
76			await tailLog(prepareUpdate, logOutput);
77			} catch (e) {
78			return showLog();
79			}
80			}
81
82			if (!isFlexProject) {
			0 ignored issues – show Best Practice introduced 2023-02-22 11:21 UTC by Report Bug Copy Issue Report If you intend to check if the variable `isFlexProject` is declared in the current environment, consider using `typeof isFlexProject === "undefined"` instead. This is safe if the variable is not actually declared. Loading history...
83			logOutput.innerHTML += 'Updating to Flex Project' + "\n"
84
85			const migrate = await fetch(`${baseUrl}/update/_migrate-template`, {method: 'POST'})
86
87			if (migrate.status !== 204 && migrate.status !== 200) {
88			logOutput.innerHTML += 'Failed to update to Flex Project' + "\n"
89			logOutput.innerHTML += await migrate.text();
90			return showLog();
91			} else {
			0 ignored issues – show Comprehensibility introduced 2023-02-22 11:21 UTC by Report Bug Copy Issue Report `else` is not necessary here since all `if` branches return, consider removing it to reduce nesting and make code more readable. Loading history...
92			logOutput.innerHTML += 'Updated to Flex Project' + "\n"
93			}
94			}
95
96			const updateRun = await fetch(`${baseUrl}/update/_run`, {method: 'POST'});
97
98			try {
99			await tailLog(updateRun, logOutput);
100			} catch (e) {
101			return showLog();
102			}
103
104			const resetConfig = await fetch(`${baseUrl}/update/_reset_config`, {method: 'POST'});
105
106			if (resetConfig.status !== 200) {
107			logOutput.innerHTML += 'Failed to update config files' + "\n"
108			logOutput.innerHTML += await resetConfig.text();
109			} else {
110			try {
111			await tailLog(resetConfig, logOutput);
112			} catch (e) {
113			return showLog();
114			}
115			}
116
117			const finishUpdate = await fetch(`${baseUrl}/update/_finish`, {method: 'POST'})
118			if (finishUpdate.status !== 200) {
119			logOutput.innerHTML += 'Failed to prepare update' + "\n"
120			logOutput.innerHTML += await finishUpdate.text();
121			} else {
122			try {
123			await tailLog(finishUpdate, logOutput);
124			} catch (e) {
125			return showLog();
126			}
127			}
128
129			window.location.href = `${baseUrl}/finish`;
			0 ignored issues – show Best Practice introduced 2023-02-22 11:21 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
130			}
131			}
132
133			function showLog() {
134			logError.style.removeProperty('display');
135			}
136
137			const downloadLogButton = document.getElementById('download-log');
138
139			if (downloadLogButton) {
140			downloadLogButton.onclick = function () {
141			const text = new Blob([logOutput.innerText], {type: 'text/plain'});
			0 ignored issues – show Bug introduced 2023-02-22 11:21 UTC by Report Bug Copy Issue Report The variable `Blob` seems to be never declared. If this is a global, consider adding a `/** global: Blob */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
142			const element = document.createElement('a');
143			element.href = URL.createObjectURL(text);
			0 ignored issues – show Bug introduced 2023-02-22 11:21 UTC by Report Bug Copy Issue Report The variable `URL` seems to be never declared. If this is a global, consider adding a `/** global: URL */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
144			element.setAttribute('download', 'log.txt');
145
146			element.style.display = 'none';
147			document.body.appendChild(element);
148
149			element.click();
150
151			document.body.removeChild(element);
152			}
153			}
154

shopware / platform

Push — 6.5.0.0 ( 85bd4e...fe6596 )

app.js ➔ showLog F

Complexity

Size

Duplication

Importance

How to fix Complexity

Complexity

Duplication Side-by-Side

Filter issues like