| Conditions | 3 |
| Paths | 4 |
| Total Lines | 160 |
| Code Lines | 134 |
| Lines | 10 |
| Ratio | 6.25 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 205 | public function testGetConnectProduct() |
||
| 206 | { |
||
| 207 | $row = [ |
||
| 208 | 'sku' => 'SW10005', |
||
| 209 | 'sourceId' => '22', |
||
| 210 | 'ean' => NULL, |
||
| 211 | 'title' => 'Glas -Teetasse 0,25l', |
||
| 212 | 'shortDescription' => 'Almus Emitto Bos sicut hae Amplitudo rixa ortus retribuo Vicarius an nam capitagium medius.', |
||
| 213 | 'vendor' => [ |
||
| 214 | 'name' => 'Teapavilion', |
||
| 215 | 'description' => 'Teapavilion description', |
||
| 216 | 'logo_url' => 'tea_pavilion.jpg', |
||
| 217 | 'url' => 'http://teapavilion.com', |
||
| 218 | 'page_title' => 'Teapavilion title', |
||
| 219 | ], |
||
| 220 | 'vat' => '0.190000', |
||
| 221 | 'availability' => 3445, |
||
| 222 | 'price' => 10.924369747899, |
||
| 223 | 'purchasePrice' => 0, |
||
| 224 | 'longDescription' => '<p>Reficio congratulor simplex Ile familia mire hae Prosequor in pro St quae Muto,, St Texo aer Cornu ferox lex inconsiderate propitius, animus ops nos haero vietus Subdo qui Gemo ipse somniculosus. Non Apertio ops, per Repere torpeo penintentiarius Synagoga res mala caelestis praestigiator. Ineo via consectatio Gemitus sui domus ludio is vulgariter, hic ut legens nox Falx nos cui vaco insudo tero, tollo valde emo. deprecativus fio redigo probabiliter pacificus sem Nequequam, suppliciter dis Te summisse Consuesco cur Desolo sis insolesco expeditus pes Curo aut Crocotula Trimodus. Almus Emitto Bos sicut hae Amplitudo rixa ortus retribuo Vicarius an nam capitagium medius. Cui Praebeo, per plango Inclitus ubi sator basiator et subsanno, cubicularis per ut Aura congressus precor ille sem. aro quid ius Praedatio vitupero Tractare nos premo procurator. Ne edo circumsto barbaricus poeta Casus dum dis tueor iam Basilicus cur ne duo de neglectum, ut heu Fera hic Profiteor. Ius Perpetuus stilla co.</p>', |
||
| 225 | 'fixedPrice' => null, |
||
| 226 | 'deliveryWorkDays' => null, |
||
| 227 | 'shipping' => null, |
||
| 228 | 'translations' => [], |
||
| 229 | 'attributes' => [ |
||
| 230 | 'unit' => null, |
||
| 231 | 'quantity' => null, |
||
| 232 | 'ref_quantity' => null, |
||
| 233 | ], |
||
| 234 | ]; |
||
| 235 | |||
| 236 | $productMedia = []; |
||
| 237 | for ($i = 1; $i < 12; $i++) { |
||
| 238 | $media = new Media(); |
||
| 239 | $media->setFile(sprintf('http://myshop/media/image/2e/4f/tea_pavilion_product_image%s.jpg', $i)); |
||
| 240 | $productMedia[] = $media; |
||
| 241 | } |
||
| 242 | |||
| 243 | $variantMedia = []; |
||
| 244 | for ($i = 1; $i < 12; $i++) { |
||
| 245 | $media = new Media(); |
||
| 246 | $media->setFile(sprintf('http://myshop/media/image/2e/4f/tea_pavilion_variant_image%s.jpg', $i)); |
||
| 247 | $variantMedia[] = $media; |
||
| 248 | } |
||
| 249 | |||
| 250 | $this->localMediaService->expects($this->once()) |
||
| 251 | ->method('getProductMediaList') |
||
| 252 | ->with($this->anything(), $this->productContext) |
||
| 253 | ->willReturn([$row['sku'] => $productMedia]); |
||
| 254 | |||
| 255 | $this->localMediaService->expects($this->once()) |
||
| 256 | ->method('getVariantMediaList') |
||
| 257 | ->with($this->anything(), $this->productContext) |
||
| 258 | ->willReturn([$row['sku'] => $variantMedia]); |
||
| 259 | |||
| 260 | $expectedProduct = new Product($row); |
||
| 261 | $expectedProduct->vendor['logo_url'] = 'http://myshop/media/image/2e/4f/tea_pavilion.jpg'; |
||
| 262 | $expectedProduct->url = $this->getProductBaseUrl() . '22'; |
||
| 263 | $expectedProduct->attributes = [ |
||
| 264 | 'quantity' => NULL, |
||
| 265 | 'ref_quantity' => NULL, |
||
| 266 | ]; |
||
| 267 | $expectedProduct->translations = $this->translations; |
||
| 268 | $expectedProduct->priceRanges = [ |
||
| 269 | new PriceRange([ |
||
| 270 | 'customerGroupKey' => 'EK', |
||
| 271 | 'from' => 1, |
||
| 272 | 'to' => 5, |
||
| 273 | 'price' => 123.99, |
||
| 274 | ]), |
||
| 275 | new PriceRange([ |
||
| 276 | 'customerGroupKey' => 'EK', |
||
| 277 | 'from' => 6, |
||
| 278 | 'to' => PriceRange::ANY, |
||
| 279 | 'price' => 113.99, |
||
| 280 | ]), |
||
| 281 | ]; |
||
| 282 | |||
| 283 | $expectedProduct->properties = [ |
||
| 284 | new \Shopware\Connect\Struct\Property([ |
||
| 285 | 'groupName' => 'Adidas', |
||
| 286 | 'groupPosition' => 3, |
||
| 287 | 'comparable' => false, |
||
| 288 | 'sortMode' => 3, |
||
| 289 | 'option' => 'color', |
||
| 290 | 'filterable' => false, |
||
| 291 | 'value' => 'green', |
||
| 292 | 'valuePosition' => 0, |
||
| 293 | ]), |
||
| 294 | new \Shopware\Connect\Struct\Property([ |
||
| 295 | 'groupName' => 'Adidas', |
||
| 296 | 'groupPosition' => 3, |
||
| 297 | 'comparable' => false, |
||
| 298 | 'sortMode' => 3, |
||
| 299 | 'option' => 'size', |
||
| 300 | 'filterable' => false, |
||
| 301 | 'value' => '2xl', |
||
| 302 | 'valuePosition' => 0, |
||
| 303 | ]), |
||
| 304 | new \Shopware\Connect\Struct\Property([ |
||
| 305 | 'groupName' => 'Adidas', |
||
| 306 | 'groupPosition' => 3, |
||
| 307 | 'comparable' => false, |
||
| 308 | 'sortMode' => 3, |
||
| 309 | 'option' => 'size', |
||
| 310 | 'filterable' => false, |
||
| 311 | 'value' => '3xl', |
||
| 312 | 'valuePosition' => 0, |
||
| 313 | ]), |
||
| 314 | ]; |
||
| 315 | |||
| 316 | $expectedProduct->images = [ |
||
| 317 | 'http://myshop/media/image/2e/4f/tea_pavilion_product_image1.jpg', |
||
| 318 | 'http://myshop/media/image/2e/4f/tea_pavilion_product_image2.jpg', |
||
| 319 | 'http://myshop/media/image/2e/4f/tea_pavilion_product_image3.jpg', |
||
| 320 | 'http://myshop/media/image/2e/4f/tea_pavilion_product_image4.jpg', |
||
| 321 | 'http://myshop/media/image/2e/4f/tea_pavilion_product_image5.jpg', |
||
| 322 | 'http://myshop/media/image/2e/4f/tea_pavilion_product_image6.jpg', |
||
| 323 | 'http://myshop/media/image/2e/4f/tea_pavilion_product_image7.jpg', |
||
| 324 | 'http://myshop/media/image/2e/4f/tea_pavilion_product_image8.jpg', |
||
| 325 | 'http://myshop/media/image/2e/4f/tea_pavilion_product_image9.jpg', |
||
| 326 | 'http://myshop/media/image/2e/4f/tea_pavilion_product_image10.jpg', |
||
| 327 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image1.jpg', |
||
| 328 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image2.jpg', |
||
| 329 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image3.jpg', |
||
| 330 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image4.jpg', |
||
| 331 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image5.jpg', |
||
| 332 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image6.jpg', |
||
| 333 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image7.jpg', |
||
| 334 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image8.jpg', |
||
| 335 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image9.jpg', |
||
| 336 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image10.jpg', |
||
| 337 | ]; |
||
| 338 | $expectedProduct->variantImages = [ |
||
| 339 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image1.jpg', |
||
| 340 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image2.jpg', |
||
| 341 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image3.jpg', |
||
| 342 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image4.jpg', |
||
| 343 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image5.jpg', |
||
| 344 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image6.jpg', |
||
| 345 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image7.jpg', |
||
| 346 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image8.jpg', |
||
| 347 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image9.jpg', |
||
| 348 | 'http://myshop/media/image/2e/4f/tea_pavilion_variant_image10.jpg', |
||
| 349 | ]; |
||
| 350 | |||
| 351 | $row['vendorName'] = $row['vendor']['name']; |
||
| 352 | $row['vendorLink'] = $row['vendor']['url']; |
||
| 353 | $row['vendorImage'] = $row['vendor']['logo_url']; |
||
| 354 | $row['vendorDescription'] = $row['vendor']['description']; |
||
| 355 | $row['vendorMetaTitle'] = $row['vendor']['page_title']; |
||
| 356 | unset($row['vendor']); |
||
| 357 | $row['category'] = ''; |
||
| 358 | $row['weight'] = null; |
||
| 359 | $row['unit'] = null; |
||
| 360 | $row['localId'] = $this->article->getId(); |
||
| 361 | $row['detailId'] = $this->article->getMainDetail()->getId(); |
||
| 362 | |||
| 363 | $this->assertEquals($expectedProduct, $this->getLocalProductQuery()->getConnectProduct($row)); |
||
| 364 | } |
||
| 365 | |||
| 483 |