| Conditions | 2 |
| Paths | 2 |
| Total Lines | 179 |
| Code Lines | 20 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 111 | private function createMyTables() |
||
| 112 | { |
||
| 113 | $queries = [' |
||
| 114 | CREATE TABLE IF NOT EXISTS `sw_connect_change` ( |
||
| 115 | `c_entity_id` varchar(64) NOT NULL, |
||
| 116 | `c_operation` char(8) NOT NULL, |
||
| 117 | `c_revision` decimal(20,10) NOT NULL, |
||
| 118 | `c_payload` longblob, |
||
| 119 | `changed` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, |
||
| 120 | UNIQUE KEY `c_revision` (`c_revision`), |
||
| 121 | KEY `c_entity_id` (`c_entity_id`), |
||
| 122 | INDEX `c_operation` (`c_operation`) |
||
| 123 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8;', ' |
||
| 124 | CREATE TABLE IF NOT EXISTS `sw_connect_data` ( |
||
| 125 | `d_key` varchar(32) NOT NULL, |
||
| 126 | `d_value` varchar(256) NOT NULL, |
||
| 127 | `changed` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, |
||
| 128 | PRIMARY KEY (`d_key`) |
||
| 129 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8;', ' |
||
| 130 | CREATE TABLE IF NOT EXISTS `sw_connect_product` ( |
||
| 131 | `p_source_id` varchar(64) NOT NULL, |
||
| 132 | `p_hash` varchar(64) NOT NULL, |
||
| 133 | `changed` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, |
||
| 134 | PRIMARY KEY (`p_source_id`) |
||
| 135 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8;', ' |
||
| 136 | CREATE TABLE IF NOT EXISTS `sw_connect_reservations` ( |
||
| 137 | `r_id` varchar(32) NOT NULL, |
||
| 138 | `r_state` varchar(12) NOT NULL, |
||
| 139 | `r_order` longblob NOT NULL, |
||
| 140 | `changed` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, |
||
| 141 | PRIMARY KEY (`r_id`) |
||
| 142 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8;', ' |
||
| 143 | CREATE TABLE IF NOT EXISTS `sw_connect_shop_config` ( |
||
| 144 | `s_shop` varchar(32) NOT NULL, |
||
| 145 | `s_config` LONGBLOB NOT NULL, |
||
| 146 | `changed` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, |
||
| 147 | PRIMARY KEY (`s_shop`) |
||
| 148 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8;', ' |
||
| 149 | CREATE TABLE IF NOT EXISTS `s_plugin_connect_config` ( |
||
| 150 | `id` int(11) NOT NULL AUTO_INCREMENT, |
||
| 151 | `name` varchar(255) NOT NULL, |
||
| 152 | `value` TEXT NOT NULL, |
||
| 153 | `shopId` int(11) NULL, |
||
| 154 | `groupName` varchar(255) NULL, |
||
| 155 | PRIMARY KEY (`id`) |
||
| 156 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8;', ' |
||
| 157 | CREATE TABLE IF NOT EXISTS `sw_connect_shipping_costs` ( |
||
| 158 | `sc_from_shop` VARCHAR(32) NOT NULL, |
||
| 159 | `sc_to_shop` VARCHAR(32) NOT NULL, |
||
| 160 | `sc_revision` VARCHAR(32) NOT NULL, |
||
| 161 | `sc_shipping_costs` LONGBLOB NOT NULL, |
||
| 162 | `sc_customer_costs` LONGBLOB NOT NULL, |
||
| 163 | `changed` TIMESTAMP DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, |
||
| 164 | PRIMARY KEY (`sc_from_shop`, `sc_to_shop`), |
||
| 165 | INDEX (`sc_revision`) |
||
| 166 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8;', ' |
||
| 167 | CREATE TABLE IF NOT EXISTS `s_plugin_connect_log` ( |
||
| 168 | `id` int(11) NOT NULL AUTO_INCREMENT, |
||
| 169 | `isError` int(1) NOT NULL, |
||
| 170 | `service` varchar(255) COLLATE utf8_unicode_ci DEFAULT NULL, |
||
| 171 | `command` varchar(255) COLLATE utf8_unicode_ci DEFAULT NULL, |
||
| 172 | `request` text COLLATE utf8_unicode_ci DEFAULT NULL, |
||
| 173 | `response` text COLLATE utf8_unicode_ci DEFAULT NULL, |
||
| 174 | `time` datetime NOT NULL, |
||
| 175 | PRIMARY KEY (`id`) |
||
| 176 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8;', ' |
||
| 177 | CREATE TABLE IF NOT EXISTS `s_plugin_connect_marketplace_attr` ( |
||
| 178 | `id` int(11) NOT NULL AUTO_INCREMENT, |
||
| 179 | `marketplace_attribute` varchar(255) NOT NULL UNIQUE, |
||
| 180 | `local_attribute` varchar(255) NOT NULL UNIQUE, |
||
| 181 | PRIMARY KEY (`id`) |
||
| 182 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8;', " |
||
| 183 | CREATE TABLE IF NOT EXISTS `s_plugin_connect_items` ( |
||
| 184 | `id` int(11) NOT NULL AUTO_INCREMENT, |
||
| 185 | `article_id` int(11) unsigned DEFAULT NULL, |
||
| 186 | `article_detail_id` int(11) unsigned DEFAULT NULL, |
||
| 187 | `shop_id` varchar(255) COLLATE utf8_unicode_ci DEFAULT NULL, |
||
| 188 | `source_id` varchar(255) COLLATE utf8_unicode_ci DEFAULT NULL, |
||
| 189 | `export_status` varchar(255) COLLATE utf8_unicode_ci, |
||
| 190 | `export_message` text COLLATE utf8_unicode_ci, |
||
| 191 | `exported` TINYINT(1) DEFAULT 0, |
||
| 192 | `category` text COLLATE utf8_unicode_ci, |
||
| 193 | `purchase_price` double DEFAULT NULL, |
||
| 194 | `fixed_price` int(1) DEFAULT NULL, |
||
| 195 | `free_delivery` int(1) DEFAULT NULL, |
||
| 196 | `update_price` varchar(255) COLLATE utf8_unicode_ci DEFAULT 'inherit', |
||
| 197 | `update_image` varchar(255) COLLATE utf8_unicode_ci DEFAULT 'inherit', |
||
| 198 | `update_main_image` varchar(255) COLLATE utf8_unicode_ci DEFAULT 'inherit', |
||
| 199 | `update_long_description` varchar(255) COLLATE utf8_unicode_ci DEFAULT 'inherit', |
||
| 200 | `update_short_description` varchar(255) COLLATE utf8_unicode_ci DEFAULT 'inherit', |
||
| 201 | `update_additional_description` varchar(255) COLLATE utf8_unicode_ci DEFAULT 'inherit', |
||
| 202 | `update_name` varchar(255) COLLATE utf8_unicode_ci DEFAULT 'inherit', |
||
| 203 | `last_update` longtext COLLATE utf8_unicode_ci, |
||
| 204 | `last_update_flag` int(11) DEFAULT NULL, |
||
| 205 | `group_id` VARCHAR (64) NULL DEFAULT NULL, |
||
| 206 | `is_main_variant` TINYINT(1) NULL DEFAULT NULL, |
||
| 207 | `purchase_price_hash` varchar(255) COLLATE utf8_unicode_ci NOT NULL, |
||
| 208 | `offer_valid_until` int(10) NOT NULL, |
||
| 209 | `stream` varchar(255) COLLATE utf8_unicode_ci NOT NULL, |
||
| 210 | `cron_update` TINYINT(1) NULL DEFAULT NULL, |
||
| 211 | `revision` decimal(20,10) DEFAULT NULL, |
||
| 212 | PRIMARY KEY (`id`), |
||
| 213 | UNIQUE KEY `article_detail_id` (`article_detail_id`), |
||
| 214 | KEY `article_id` (`article_id`), |
||
| 215 | INDEX source_id (source_id, shop_id), |
||
| 216 | INDEX group_id (group_id, shop_id), |
||
| 217 | INDEX IDX_revision (revision), |
||
| 218 | INDEX IDX_status (export_status) |
||
| 219 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;", ' |
||
| 220 | CREATE TABLE IF NOT EXISTS `sw_connect_shipping_rules` ( |
||
| 221 | `sr_id` int(11) NOT NULL AUTO_INCREMENT, |
||
| 222 | `sr_group_id` int(11) unsigned DEFAULT NULL, |
||
| 223 | `sr_country` varchar(32) COLLATE utf8_unicode_ci NOT NULL, |
||
| 224 | `sr_delivery_days` int(5) DEFAULT NULL, |
||
| 225 | `sr_price` double DEFAULT NULL, |
||
| 226 | `sr_zip_prefix` varchar(255) COLLATE utf8_unicode_ci DEFAULT NULL, |
||
| 227 | PRIMARY KEY (`sr_id`), |
||
| 228 | KEY `sr_group_id` (`sr_group_id`) |
||
| 229 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci',' |
||
| 230 | CREATE TABLE IF NOT EXISTS `s_plugin_connect_categories` ( |
||
| 231 | `id` int(11) NOT NULL AUTO_INCREMENT, |
||
| 232 | `category_key` varchar(255) COLLATE utf8_unicode_ci NOT NULL, |
||
| 233 | `label` varchar(255) COLLATE utf8_unicode_ci NOT NULL, |
||
| 234 | `local_category_id` int(11) DEFAULT NULL, |
||
| 235 | `shop_id` int(11) NULL, |
||
| 236 | PRIMARY KEY (`id`), |
||
| 237 | INDEX (`category_key`), |
||
| 238 | UNIQUE KEY `scuk_connect_category_for_shop_id` (`category_key`,`shop_id`) |
||
| 239 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;', ' |
||
| 240 | CREATE TABLE IF NOT EXISTS `s_plugin_connect_product_to_categories` ( |
||
| 241 | `id` int(11) NOT NULL AUTO_INCREMENT, |
||
| 242 | `connect_category_id` int(11) NOT NULL, |
||
| 243 | `articleID` int(11) NOT NULL, |
||
| 244 | PRIMARY KEY (`id`), |
||
| 245 | INDEX article_id (articleID), |
||
| 246 | UNIQUE KEY `scuk_connect_category_id` (`connect_category_id`,`articleID`) |
||
| 247 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;', ' |
||
| 248 | CREATE TABLE IF NOT EXISTS `s_plugin_connect_streams` ( |
||
| 249 | `id` int(11) NOT NULL AUTO_INCREMENT, |
||
| 250 | `stream_id` int(11) NOT NULL, |
||
| 251 | `export_status` varchar(255) COLLATE utf8_unicode_ci DEFAULT NULL, |
||
| 252 | `export_message` text COLLATE utf8_unicode_ci DEFAULT NULL, |
||
| 253 | PRIMARY KEY (`id`) |
||
| 254 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;'," |
||
| 255 | CREATE TABLE IF NOT EXISTS `s_plugin_connect_streams_relation` ( |
||
| 256 | `stream_id` int(11) unsigned NOT NULL, |
||
| 257 | `article_id` int(11) unsigned NOT NULL, |
||
| 258 | `deleted` int(1) NOT NULL DEFAULT '0', |
||
| 259 | UNIQUE KEY `stream_id` (`stream_id`,`article_id`), |
||
| 260 | CONSTRAINT s_plugin_connect_streams_selection_fk_stream_id FOREIGN KEY (stream_id) REFERENCES s_product_streams (id) ON DELETE CASCADE, |
||
| 261 | CONSTRAINT s_plugin_connect_streams_selection_fk_article_id FOREIGN KEY (article_id) REFERENCES s_articles (id) ON DELETE CASCADE |
||
| 262 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;", ' |
||
| 263 | CREATE TABLE IF NOT EXISTS `s_plugin_connect_categories_to_local_categories` ( |
||
| 264 | `id` int(11) NOT NULL AUTO_INCREMENT, |
||
| 265 | `remote_category_id` int(11) NOT NULL, |
||
| 266 | `local_category_id` int(11) unsigned NOT NULL, |
||
| 267 | `stream` varchar(255) COLLATE utf8_unicode_ci DEFAULT NULL, |
||
| 268 | PRIMARY KEY (`id`), |
||
| 269 | UNIQUE KEY `scuk_connect_category_to_local_category` (`remote_category_id`, `local_category_id`, `stream`), |
||
| 270 | CONSTRAINT s_plugin_connect_remote_categories_fk_remote_category_id FOREIGN KEY (remote_category_id) REFERENCES s_plugin_connect_categories (id) ON DELETE CASCADE, |
||
| 271 | CONSTRAINT s_plugin_connect_remote_categories_fk_local_category_id FOREIGN KEY (local_category_id) REFERENCES s_categories (id) ON DELETE CASCADE |
||
| 272 | ) ENGINE = InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; |
||
| 273 | ', ' |
||
| 274 | CREATE TABLE IF NOT EXISTS `s_plugin_connect_article_relations` ( |
||
| 275 | `id` int(11) NOT NULL AUTO_INCREMENT, |
||
| 276 | `article_id` int(11) unsigned NOT NULL, |
||
| 277 | `shop_id` int(11) NOT NULL, |
||
| 278 | `related_article_local_id` int(11) NOT NULL, |
||
| 279 | `relationship_type` varchar(32) COLLATE utf8_unicode_ci NOT NULL, |
||
| 280 | PRIMARY KEY (`id`), |
||
| 281 | UNIQUE KEY `relations` (`article_id`, `shop_id`, `related_article_local_id`, `relationship_type`), |
||
| 282 | CONSTRAINT s_plugin_connect_article_relations_fk_article_id FOREIGN KEY (article_id) REFERENCES s_articles (id) ON DELETE CASCADE |
||
| 283 | ) ENGINE = InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; |
||
| 284 | ']; |
||
| 285 | |||
| 286 | foreach ($queries as $query) { |
||
| 287 | $this->db->exec($query); |
||
| 288 | } |
||
| 289 | } |
||
| 290 | |||
| 745 |