ShopwarePlugins\Connect\Components\ConnectExport

Complexity

Total Complexity

76

Size/Duplication

Total Lines	794
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

24 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	17	1
A	getArticleModelById()	0	4	1
A	getArticleDetailById()	0	4	1
D	export()	0	125	14
A	processChanged()	0	30	2
A	markProductsDeleted()	0	12	2
B	updateLocalConnectItem()	0	36	6
A	fetchConnectItems()	0	33	3
A	getExportArticlesIds()	0	25	2
A	getChangesCount()	0	6	1
A	syncDeleteDetail()	0	17	2
A	setDeleteStatusForVariants()	0	23	2
A	updateConnectItemsStatus()	0	25	4
F	getExportList()	0	114	12
A	clearConnectItems()	0	5	1
A	markArticleForCronUpdate()	0	8	1
A	recordDelete()	0	4	1
A	deleteAllConnectProducts()	0	6	1
A	resetConnectItemsStatus()	0	12	1
A	getMarketplaceGateway()	0	9	2
A	extractProductAttributes()	0	22	4
B	markProductsInToBeDeletedCategories()	0	42	5
A	handleMarkedProducts()	0	16	2
A	addGroupBy()	0	20	5

<?php
/**
 * (c) shopware AG <info@shopware.com>
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ShopwarePlugins\Connect\Components;

use Doctrine\DBAL\DBALException;
use Shopware\Connect\SDK;
use Shopware\CustomModels\Connect\Attribute;
use ShopwarePlugins\Connect\Components\Marketplace\MarketplaceGateway;
use ShopwarePlugins\Connect\Components\Validator\ProductAttributesValidator;
use Shopware\Components\Model\ModelManager;
use Shopware\Models\Article\Article;
use Shopware\Models\Article\Detail;
use Shopware\Models\Category\Category;
use ShopwarePlugins\Connect\Components\ProductStream\ProductStreamsAssignments;
use ShopwarePlugins\Connect\Struct\ExportList;
use ShopwarePlugins\Connect\Struct\SearchCriteria;
use Enlight_Event_EventManager;

class ConnectExport
{
    const BATCH_SIZE = 200;

    /** @var
     * Helper
     */
    protected $helper;

    /** @var
     * SDK
     */
    protected $sdk;

    /** @var
     * ModelManager
     */
    protected $manager;

    /**
     * @var ProductAttributesValidator
     */
    protected $productAttributesValidator;

    /** @var
     * MarketplaceGateway
     */
    protected $marketplaceGateway;

    /**
     * @var ErrorHandler
     */
    protected $errorHandler;

    /**
     * @var Config
     */
    protected $configComponent;

    /**
     * @var Enlight_Event_EventManager
     */
    private $eventManager;

    /**
     * ConnectExport constructor.
     * @param Helper $helper
     * @param SDK $sdk
     * @param ModelManager $manager
     * @param ProductAttributesValidator $productAttributesValidator
     * @param Config $configComponent
     * @param \ShopwarePlugins\Connect\Components\ErrorHandler $errorHandler
     * @param Enlight_Event_EventManager $eventManager
     */
    public function __construct(
        Helper $helper,
        SDK $sdk,
        ModelManager $manager,
        ProductAttributesValidator $productAttributesValidator,
        Config $configComponent,
        ErrorHandler $errorHandler,
        Enlight_Event_EventManager $eventManager
    ) {
        $this->helper = $helper;
        $this->sdk = $sdk;
        $this->manager = $manager;
        $this->productAttributesValidator = $productAttributesValidator;
        $this->configComponent = $configComponent;
        $this->errorHandler = $errorHandler;
        $this->eventManager = $eventManager;
    }

    /**
     * Load article entity
     *
     * @param $id
     * @return null|\Shopware\Models\Article\Article
     */
    public function getArticleModelById($id)
    {
        return $this->manager->getRepository('Shopware\Models\Article\Article')->find($id);
    }

    /**
     * Load article detail entity
     *
     * @param $id
     * @return null|\Shopware\Models\Article\Detail
     */
    public function getArticleDetailById($id)
    {
        return $this->manager->getRepository('Shopware\Models\Article\Detail')->find($id);
    }

    /**
     * Helper function to mark a given array of source ids for connect update
     *
     * There is a problem with flush when is called from life cycle event in php7,
     * this flag '$isEvent' is preventing the flush
     *
     * @param array $ids
     * @param ProductStreamsAssignments|null $streamsAssignments
     * @return array
     */
    public function export(array $ids, ProductStreamsAssignments $streamsAssignments = null)
    {
        $ids = $this->eventManager->filter(
            'Connect_Supplier_Get_Products_Filter_Source_IDS',
            $ids,
            [
                'subject' => $this
            ]
        );

        $connectItems = $this->fetchConnectItems($ids);

        $this->eventManager->notify(
            'Connect_Supplier_Get_All_Products_Before',
            [
                'subject' => $this,
                'products' => $connectItems
            ]
        );

        $this->manager->beginTransaction();
        $excludeInactiveProducts = $this->configComponent->getConfig('excludeInactiveProducts');

Are you sure the assignment to $excludeInactiveProducts is correct as $this->configComponent->getConfig('excludeInactiveProducts') (which targets ShopwarePlugins\Connect\Components\Config::getConfig()) seems to always return null.

        foreach ($connectItems as &$item) {
            $model = $this->getArticleDetailById($item['articleDetailId']);
            if ($model === null) {
                continue;
            }

            $connectAttribute = $this->helper->getOrCreateConnectAttributeByModel($model);

            if ($excludeInactiveProducts && !$model->getActive()) {
                $this->updateLocalConnectItem(
                    $connectAttribute->getSourceId(),
                    [
                        'export_status' => Attribute::STATUS_INACTIVE,
                        'exported' => false,
                        'export_message' =>  Shopware()->Snippets()->getNamespace('backend/connect/view/main')->get(
                            'export/message/error_product_is_not_active',
                            'Produkt ist inaktiv',
                            true
                        ),
                    ]
                );
                $this->manager->refresh($connectAttribute);
                continue;
            }

            if (!$this->helper->isProductExported($connectAttribute)) {
                $status = Attribute::STATUS_INSERT;
            } else {
                $status = Attribute::STATUS_UPDATE;
            }

            $categories = $this->helper->getConnectCategoryForProduct($item['articleId']);
            if (is_string($categories)) {
                $categories = [$categories];
            }
            $categories = json_encode($categories);

            $this->updateLocalConnectItem(
                $connectAttribute->getSourceId(),
                [
                    'export_status' => $status,
                    'export_message' => null,
                    'exported' => true,
                    'category' => $categories,
                ]
            );

            try {
                $this->productAttributesValidator->validate($this->extractProductAttributes($model));
                if ($status == Attribute::STATUS_INSERT) {
                    $this->sdk->recordInsert($item['sourceId']);
                } else {
                    $this->sdk->recordUpdate($item['sourceId']);
                }

                if ($this->helper->isMainVariant($item['sourceId']) &&
                    $streamsAssignments !== null &&
                    $streamsAssignments->getStreamsByArticleId($item['articleId']) !== null
                ) {
                    $this->sdk->recordStreamAssignment(
                        $item['sourceId'],
                        $streamsAssignments->getStreamsByArticleId($item['articleId']),
                        $item['groupId']
                    );
                }
            } catch (\Exception $e) {
                if ($this->errorHandler->isPriceError($e)) {
                    $this->updateLocalConnectItem(
                        $connectAttribute->getSourceId(),
                        [
                            'export_status' => Attribute::STATUS_ERROR_PRICE,
                            'export_message' => Shopware()->Snippets()->getNamespace('backend/connect/view/main')->get(
                                'export/message/error_price_status',
                                'There is an empty price field',
                                true
                            ),
                        ]
                    );
                } else {
                    $this->updateLocalConnectItem(
                        $connectAttribute->getSourceId(),
                        [
                            'export_status' => Attribute::STATUS_ERROR,
                            'export_message' => $e->getMessage() . "\n" . $e->getTraceAsString(),
                        ]
                    );
                }

                $this->errorHandler->handle($e);
            }
            $this->manager->refresh($connectAttribute);
        }

        try {
            $this->manager->commit();
        } catch (\Exception $e) {
            $this->manager->rollback();
            $this->errorHandler->handle($e);
        }

        return $this->errorHandler->getMessages();
    }

    public function processChanged(array $ids)
    {
        $deleted = $this->manager->getConnection()->executeQuery(
            'SELECT ci.source_id
            FROM s_plugin_connect_items AS ci
            LEFT JOIN s_articles_details AS ad ON ad.id = ci.article_detail_id
            WHERE ad.id IS NULL AND ci.source_id IN (?)',
            [$ids],
            [\Doctrine\DBAL\Connection::PARAM_STR_ARRAY]
        )->fetchAll(\PDO::FETCH_COLUMN);

        $inactive = $this->manager->getConnection()->executeQuery(
            'SELECT ci.source_id
             FROM s_plugin_connect_items AS ci
             JOIN s_articles as a ON ci.article_id = a.id
             WHERE a.active = 0 AND ci.source_id IN (?)',
            [$ids],
            [\Doctrine\DBAL\Connection::PARAM_STR_ARRAY]
        )->fetchAll(\PDO::FETCH_COLUMN);
        $deleted = array_merge($deleted, $inactive);

        $updatedIds = array_diff($ids, $deleted);
        if ($updatedIds === null) {
            $updatedIds = [];
        }
        $this->export($updatedIds);

        $this->markProductsDeleted($deleted);
        $this->markProductsDeleted($inactive);
    }

    /**
     * @param array $ids
     */
    private function markProductsDeleted($ids)
    {
        foreach ($ids as $sourceId) {
            $this->recordDelete($sourceId);
        }

        $this->manager->getConnection()->executeQuery(
            'UPDATE s_plugin_connect_items SET export_status = ? WHERE source_id IN (?)',
            [Attribute::STATUS_DELETE, $ids],
            [\PDO::PARAM_STR, \Doctrine\DBAL\Connection::PARAM_STR_ARRAY]
        );
    }

    /**
     * Update connect attribute data
     *
     * @param string $sourceId
     * @param array $params
     */
    private function updateLocalConnectItem($sourceId, $params = [])
    {
        if (empty($params)) {
            return;
        }
        $possibleValues = [
            Attribute::STATUS_DELETE,
            Attribute::STATUS_INSERT,
            Attribute::STATUS_UPDATE,
            Attribute::STATUS_ERROR,
            Attribute::STATUS_ERROR_PRICE,
            Attribute::STATUS_INACTIVE,
            Attribute::STATUS_SYNCED,
            null,
        ];

        if (isset($params['export_status']) && !in_array($params['export_status'], $possibleValues)) {
            throw new \InvalidArgumentException('Invalid export status');
        }

        if (isset($params['exported']) && !is_bool($params['exported'])) {
            throw new \InvalidArgumentException('Parameter $exported must be boolean.');
        }

        $builder = $this->manager->getConnection()->createQueryBuilder();
        $builder->update('s_plugin_connect_items', 'ci');
        array_walk($params, function ($param, $name) use ($builder) {
            $builder->set('ci.' . $name, ':' . $name)
                    ->setParameter($name, $param);
        });

        $builder->where('source_id = :sourceId')
                ->setParameter('sourceId', $sourceId)
                ->andWhere('shop_id IS NULL')
                ->execute();
    }

    /**
     * Fetch connect items
     * Default order is main variant first, after that regular variants.
     * This is needed, because first received variant with an unknown groupId in Connect
     * will be selected as main variant.
     *
     * @param array $sourceIds
     * @param bool $orderByMainVariants
     * @return array
     */
    public function fetchConnectItems(array $sourceIds, $orderByMainVariants = true)
    {
        if (count($sourceIds) == 0) {
            return [];
        }

        $implodedIds = '"' . implode('","', $sourceIds) . '"';
        $query = "SELECT bi.article_id as articleId,
                    bi.article_detail_id as articleDetailId,
                    bi.export_status as exportStatus,
                    bi.export_message as exportMessage,
                    bi.source_id as sourceId,
                    bi.exported,
                    a.name as title,
                    IF (a.configurator_set_id IS NOT NULL, a.id, NULL) as groupId,
                    d.ordernumber as number
            FROM s_plugin_connect_items bi
            LEFT JOIN s_articles a ON bi.article_id = a.id
            LEFT JOIN s_articles_details d ON bi.article_detail_id = d.id
            WHERE bi.source_id IN ($implodedIds)";

        if ($orderByMainVariants === false) {
            $query .= ';';

            return Shopware()->Db()->fetchAll($query);
        }

        $query .= 'AND d.kind = ?;';
        $mainVariants = Shopware()->Db()->fetchAll($query, [1]);
        $regularVariants = Shopware()->Db()->fetchAll($query, [2]);

        return array_merge($mainVariants, $regularVariants);
    }

    /**
     * Helper function to return export product ids
     * @return array
     */
    public function getExportArticlesIds()
    {
        $builder = $this->manager->createQueryBuilder();
        $builder->from('Shopware\CustomModels\Connect\Attribute', 'at');
        $builder->join('at.article', 'a');
        $builder->join('a.mainDetail', 'd');
        $builder->leftJoin('d.prices', 'p', 'with', "p.from = 1 AND p.customerGroupKey = 'EK'");
        $builder->leftJoin('a.supplier', 's');
        $builder->leftJoin('a.tax', 't');

        $builder->select(['a.id']);

        $builder->where("at.exportStatus = 'update' OR at.exportStatus = 'insert' OR at.exportStatus = 'error'");
        $builder->andWhere('at.shopId IS NULL');

        $query = $builder->getQuery();
        $articles = $query->getArrayResult();

        $ids = [];
        foreach ($articles as $article) {
            $ids[] = $article['id'];
        }

        return $ids;
    }

    /**
     * Helper function to count how many changes
     * are waiting to be synchronized
     *
     * @return int
     */
    public function getChangesCount()
    {
        $sql = 'SELECT COUNT(*) FROM `sw_connect_change`';

        return (int) Shopware()->Db()->fetchOne($sql);
    }

    /**
     * Mark single connect product detail for delete
     *
     * @param \Shopware\Models\Article\Detail $detail
     */
    public function syncDeleteDetail(Detail $detail)
    {
        $attribute = $this->helper->getConnectAttributeByModel($detail);
        // force fetching ConnectAttribute from DB
        // if it was update via query builder
        // changes are not visible, because of doctrine proxy cache
        $this->manager->refresh($attribute);

        if (!$this->helper->isProductExported($attribute)) {
            return;
        }
        $this->sdk->recordDelete($attribute->getSourceId());
        $attribute->setExportStatus(Attribute::STATUS_DELETE);
        $attribute->setExported(false);
        $this->manager->persist($attribute);
        $this->manager->flush($attribute);
    }

    /**
     * Mark all product variants for delete
     *
     * @param Article $article
     */
    public function setDeleteStatusForVariants(Article $article)
    {
        $builder = $this->manager->createQueryBuilder();
        $builder->select(['at.sourceId'])
            ->from('Shopware\CustomModels\Connect\Attribute', 'at')
            ->where('at.articleId = :articleId')
            ->andWhere('at.exported = 1')
            ->setParameter(':articleId', $article->getId());
        $connectItems = $builder->getQuery()->getArrayResult();

        foreach ($connectItems as $item) {
            $this->sdk->recordDelete($item['sourceId']);
        }

        $builder = $this->manager->createQueryBuilder();
        $builder->update('Shopware\CustomModels\Connect\Attribute', 'at')
            ->set('at.exportStatus', $builder->expr()->literal(Attribute::STATUS_DELETE))
            ->set('at.exported', 0)
            ->where('at.articleId = :articleId')
            ->setParameter(':articleId', $article->getId());

        $builder->getQuery()->execute();
    }

    /**
     * @param array $sourceIds
     * @param $status
     */
    public function updateConnectItemsStatus(array $sourceIds, $status)
    {
        if (empty($sourceIds)) {
            return;
        }

        $chunks = array_chunk($sourceIds, self::BATCH_SIZE);

        $exported = false;
        if ($status == Attribute::STATUS_DELETE) {
            $exported = true;
        }

        foreach ($chunks as $chunk) {
            $builder = $this->manager->getConnection()->createQueryBuilder();
            $builder->update('s_plugin_connect_items', 'ci')
                ->set('ci.export_status', ':status')
                ->set('ci.exported', ':exported')
                ->where('source_id IN (:sourceIds)')
                ->setParameter('sourceIds', $chunk, \Doctrine\DBAL\Connection::PARAM_STR_ARRAY)
                ->setParameter('status', $status)
                ->setParameter('exported', $exported)
                ->execute();
        }
    }

    /**
     * @param SearchCriteria $criteria
     * @return ExportList
     */
    public function getExportList(SearchCriteria $criteria)
    {
        $customProductsTableExists = false;
        try {
            $builder = $this->manager->getConnection()->createQueryBuilder();
            $builder->select('id');
            $builder->from('s_plugin_custom_products_template');
            $builder->setMaxResults(1);
            $builder->execute()->fetch();

            $customProductsTableExists = true;
        } catch (DBALException $e) {

The class Doctrine\DBAL\DBALException does not exist. Did you forget a USE statement, or did you not list all dependencies?

            // ignore it
            // custom products is not installed
        }

        $builder = $this->manager->getConnection()->createQueryBuilder();
        $builder->select([
            'a.id',
            'd.ordernumber as number',
            'd.inStock as inStock',
            'a.name as name',
            's.name as supplier',
            'a.active as active',
            't.tax as tax',
            'p.price * (100 + t.tax) / 100 as price',
            'i.category',
            'i.export_status as exportStatus',
            'i.export_message as exportMessage',
            'i.cron_update as cronUpdate'
        ])
            ->from('s_plugin_connect_items', 'i')
            ->leftJoin('i', 's_articles', 'a', 'a.id = i.article_id')
            ->leftJoin('a', 's_articles_details', 'd', 'a.main_detail_id = d.id')
            ->leftJoin('d', 's_articles_prices', 'p', 'd.id = p.articledetailsID')
            ->leftJoin('a', 's_core_tax', 't', 'a.taxID = t.id')
            ->leftJoin('a', 's_articles_supplier', 's', 'a.supplierID = s.id')
            ->where('i.shop_id IS NULL');

        if ($customProductsTableExists) {
            $builder->addSelect('IF(spcptpr.template_id > 0, 1, 0) as customProduct')
                    ->leftJoin('a', 's_plugin_custom_products_template_product_relation', 'spcptpr', 'a.id = spcptpr.article_id');
        }

        if ($criteria->search) {
            $builder->andWhere('d.ordernumber LIKE :search OR a.name LIKE :search OR s.name LIKE :search')
                ->setParameter('search', $criteria->search);
        }

        if ($criteria->categoryId) {

            // Get all children categories
            $qBuilder = $this->manager->getConnection()->createQueryBuilder();
            $qBuilder->select('c.id');
            $qBuilder->from('s_categories', 'c');
            $qBuilder->where('c.path LIKE :categoryIdSearch');
            $qBuilder->orWhere('c.id = :categoryId');
            $qBuilder->setParameter(':categoryId', $criteria->categoryId);
            $qBuilder->setParameter(':categoryIdSearch', "%|$criteria->categoryId|%");

            $categoryIds = $qBuilder->execute()->fetchAll(\PDO::FETCH_COLUMN);

            if (count($categoryIds) === 0) {
                $categoryIds = [$criteria->categoryId];
            }

            $builder->innerJoin('a', 's_articles_categories', 'sac', 'a.id = sac.articleID')
                ->andWhere('sac.categoryID IN (:categoryIds)')
                ->setParameter('categoryIds', $categoryIds, \Doctrine\DBAL\Connection::PARAM_STR_ARRAY);
        }

        if ($criteria->supplierId) {
            $builder->andWhere('a.supplierID = :supplierId')
                ->setParameter('supplierId', $criteria->supplierId);
        }

        if ($criteria->exportStatus) {
            $errorStatuses = [Attribute::STATUS_ERROR, Attribute::STATUS_ERROR_PRICE];

            if (in_array($criteria->exportStatus, $errorStatuses)) {
                $builder->andWhere('i.export_status IN (:status)')
                    ->setParameter('status', $errorStatuses, \Doctrine\DBAL\Connection::PARAM_STR_ARRAY);
            } elseif ($criteria->exportStatus == Attribute::STATUS_INACTIVE) {
                $builder->andWhere('a.active = :status')
                    ->setParameter('status', false);
            } else {
                $builder->andWhere('i.export_status LIKE :status')
                    ->setParameter('status', $criteria->exportStatus);
            }
        }

        if ($criteria->active) {
            $builder->andWhere('a.active = :active')
                ->setParameter('active', $criteria->active);
        }

        if ($criteria->orderBy) {
            $this->addGroupBy($criteria, $builder);
        }

        $totalBuilder = clone $builder;
        $builder->groupBy('i.article_id');
        $builder->setFirstResult($criteria->offset);
        $builder->setMaxResults($criteria->limit);
        $data = $builder->execute()->fetchAll();

        $totalBuilder->select('COUNT(DISTINCT a.id)');
        $total = $totalBuilder->execute()->fetchColumn();

        return new ExportList([
            'articles' => $data,
            'count' => $total,
        ]);
    }

    public function clearConnectItems()
    {
        $this->deleteAllConnectProducts();
        $this->resetConnectItemsStatus();
    }

    /**
     * @param int $articleId
     */
    public function markArticleForCronUpdate($articleId)
    {
        $this->manager->getConnection()->update(
            's_plugin_connect_items',
            ['cron_update' => 1],
            ['article_id' => (int) $articleId]
        );
    }

    /**
     * Wrapper method
     *
     * @param string $sourceId
     */
    public function recordDelete($sourceId)
    {
        $this->sdk->recordDelete($sourceId);
    }

    /**
     * Deletes products hash
     */
    private function deleteAllConnectProducts()
    {
        $builder = $this->manager->getConnection()->createQueryBuilder();
        $builder->delete('sw_connect_product');
        $builder->execute();
    }

    /**
     * Resets all item status
     */
    private function resetConnectItemsStatus()
    {
        $builder = $this->manager->getConnection()->createQueryBuilder();
        $builder->update('s_plugin_connect_items', 'ci')
            ->set('export_status', ':exportStatus')
            ->set('revision', ':revision')
            ->set('exported', 0)
            ->setParameter('exportStatus', null)
            ->setParameter('revision', null);

        $builder->execute();
    }

    private function getMarketplaceGateway()
    {
        //todo@fixme: Implement better way to get MarketplaceGateway
        if (!$this->marketplaceGateway) {
            $this->marketplaceGateway = new MarketplaceGateway($this->manager);
        }

        return $this->marketplaceGateway;
    }

    /**
     * Extracts all marketplaces attributes from product
     *
     * @param Detail $detail
     * @return array
     */
    private function extractProductAttributes(Detail $detail)
    {
        $marketplaceAttributes = [];
        $marketplaceAttributes['purchaseUnit'] = $detail->getPurchaseUnit();
        $marketplaceAttributes['referenceUnit'] = $detail->getReferenceUnit();

        // marketplace attributes are available only for SEM shops
        if ($this->configComponent->getConfig('isDefault', true)) {
            return $marketplaceAttributes;
        }

        foreach ($this->getMarketplaceGateway()->getMappings() as $mapping) {
            $shopwareAttribute = $mapping['shopwareAttributeKey'];
            $getter = 'get' . ucfirst($shopwareAttribute);

            if (method_exists($detail->getAttribute(), $getter)) {
                $marketplaceAttributes[$shopwareAttribute] = $detail->getAttribute()->{$getter}();
            }
        }

        return $marketplaceAttributes;
    }

    /**
     * @param Category $category
     */
    public function markProductsInToBeDeletedCategories(Category $category)
    {
        $categoryId = $category->getId();
        $builder = $this->manager->getConnection()->createQueryBuilder();
        $builder->select('categories.id')
            ->from('s_categories', 'categories')
            ->where('categories.path LIKE :categoryIDs')
            ->orWhere('categories.id = :categoryID')
            ->setParameter('categoryIDs', "%|$categoryId|%")
            ->setParameter('categoryID', $categoryId);
        $categoriesToBeDeleted = $builder->execute()->fetchAll(\PDO::FETCH_COLUMN);

        if ($categoriesToBeDeleted) {
            $articlesInDeletedCategories = [];
            foreach ($categoriesToBeDeleted as $categoryToBeDeleted) {
                //it's necessary to fetch all articleIDs in the deleted categories
                //because DQL doesn't allow a join in update
                $builder->select('articleCategories.articleID')
                    ->from('s_articles_categories', 'articleCategories')
                    ->where('articleCategories.categoryID = (:categoryID)')
                    ->setParameter('categoryID', $categoryToBeDeleted);
                $articlesInCategory = $builder->execute()->fetchAll(\PDO::FETCH_COLUMN);
                foreach ($articlesInCategory as $articleId) {
                    //trick to get just unique articleIDs -> should be faster than array_unique(array_merge())
                    $articlesInDeletedCategories[$articleId] = true;
                }
            }

            //we can't export Products directly because Categories are still there
            //we are in preRemove
            //we just mark them do be updated
            if ($articlesInDeletedCategories) {

The expression $articlesInDeletedCategories of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                $builder->update('s_plugin_connect_items', 'connectItems')
                    ->set('connectItems.cron_update', 1)
                    ->where('connectItems.article_id IN (:articleIDs)')
                    ->andWhere('connectItems.exported = 1')
                    ->setParameter('articleIDs', array_keys($articlesInDeletedCategories), \Doctrine\DBAL\Connection::PARAM_STR_ARRAY);

                $builder->execute();
            }
        }
    }

    /**
     * exports every article that is marked with cron_update = 1
     * this is called in postRemoveCategories
     * to change products if their category was deleted
     */
    public function handleMarkedProducts()
    {
        $builder = $this->manager->getConnection()->createQueryBuilder();
        $builder->select('items.article_id')
            ->from('s_plugin_connect_items', 'items')
            ->where('items.cron_update = 1');
        $articlesToBeExported = $builder->execute()->fetchAll(\PDO::FETCH_COLUMN);

        if ($articlesToBeExported) {
            $this->export($articlesToBeExported);

            $builder->update('s_plugin_connect_items', 'items')
                ->set('items.cron_update', 0);
            $builder->execute();
        }
    }

    /**
     * @param SearchCriteria $criteria
     * @param $builder
     */
    private function addGroupBy(SearchCriteria $criteria, $builder)
    {
        if ($criteria->orderBy === 'exportStatus') {
            $builder->orderBy('i.export_status', $criteria->orderByDirection);
            return;
        }
        if ($criteria->orderBy === 'name') {
            $builder->orderBy('a.name', $criteria->orderByDirection);
            return;
        }
        if ($criteria->orderBy === 'supplier') {
            $builder->orderBy('s.name', $criteria->orderByDirection);
            return;
        }
        if ($criteria->orderBy === 'number') {
            $builder->orderBy('d.ordernumber', $criteria->orderByDirection);
            return;
        }
        $builder->orderBy($criteria->orderBy, $criteria->orderByDirection);
    }
}