Factory::factory() - Code Metrics - shopware-blog/shopware-environment-variables - Measure and Improve Code Quality continuously with Scrutinizer

Factory::factory() A
last analyzed 2019-09-12 08:59 UTC

↳ Parent: Factory

Complexity

Conditions	5
Paths	9

Size

Total Lines	25
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	10
c	1
b	0
f	0
dl	0
loc	25
rs	9.6111
cc	5
nc	9
nop	4

<?php declare(strict_types=1);

namespace ShopwareEnvironmentVariables\Source\Config;

use Doctrine\DBAL\Connection;
filter:
    dependency_paths: ["lib/*"]
use Shopware\Components\DependencyInjection\Bridge\Config as ShopwareConfigFactory;
filter:
    dependency_paths: ["lib/*"]
use Shopware\Components\ShopwareReleaseStruct;
filter:
    dependency_paths: ["lib/*"]
use ShopwareEnvironmentVariables\Source\Helper\ShopProvider;

class Factory extends ShopwareConfigFactory
{
    /**
     * @var array
     */
    private $customConfig;

    /**
     * @var ShopProvider
     */
    private $shopProvider;

    /**
     * @param ShopProvider $shopProvider
     * @param array|null $customConfig
     */
    public function __construct(ShopProvider $shopProvider, array $customConfig = null)
    {
        $this->customConfig = $customConfig;
        $this->shopProvider = $shopProvider;
    }

    public function factory(
        \Zend_Cache_Core $cache,
filter:
    dependency_paths: ["lib/*"]
        Connection $db = null,
        $config = [],
        ShopwareReleaseStruct $release
    ) {
        if (!$db) {
            return null;
        }

        if (!isset($config['cache'])) {
            $config['cache'] = $cache;
        }

        $config['db'] = $db;

        if ($release) {

            $config['release'] = $release;
        }

        if ($this->customConfig) {

            $config['custom'] = $this->customConfig;
        }

        return new Config($config, $this->shopProvider->getDefaultShopId());
    }
}


1			<?php declare(strict_types=1);
2
3			namespace ShopwareEnvironmentVariables\Source\Config;
4
5			use Doctrine\DBAL\Connection;
			0 ignored issues – show Bug introduced 2019-09-12 08:58 UTC by Report Bug Copy Issue Report The type `Doctrine\DBAL\Connection` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
6			use Shopware\Components\DependencyInjection\Bridge\Config as ShopwareConfigFactory;
			0 ignored issues – show Bug introduced 2018-05-08 14:33 UTC by Report Bug Copy Issue Report The type `Shopware\Components\Depe...Injection\Bridge\Config` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
7			use Shopware\Components\ShopwareReleaseStruct;
			0 ignored issues – show Bug introduced 2019-09-12 08:58 UTC by Report Bug Copy Issue Report The type `Shopware\Components\ShopwareReleaseStruct` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
8			use ShopwareEnvironmentVariables\Source\Helper\ShopProvider;
9
10			class Factory extends ShopwareConfigFactory
11			{
12			/**
13			* @var array
14			*/
15			private $customConfig;
16
17			/**
18			* @var ShopProvider
19			*/
20			private $shopProvider;
21
22			/**
23			* @param ShopProvider $shopProvider
24			* @param array\|null $customConfig
25			*/
26			public function __construct(ShopProvider $shopProvider, array $customConfig = null)
27			{
28			$this->customConfig = $customConfig;
29			$this->shopProvider = $shopProvider;
30			}
31
32			public function factory(
33			\Zend_Cache_Core $cache,
			0 ignored issues – show Bug introduced 2019-09-12 08:58 UTC by Report Bug Copy Issue Report The type `Zend_Cache_Core` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
34			Connection $db = null,
35			$config = [],
36			ShopwareReleaseStruct $release
37			) {
38			if (!$db) {
39			return null;
40			}
41
42			if (!isset($config['cache'])) {
43			$config['cache'] = $cache;
44			}
45
46			$config['db'] = $db;
47
48			if ($release) {
			0 ignored issues – show introduced 2019-09-12 08:58 UTC by Report Bug Copy Issue Report `$release` is of type `Shopware\Components\ShopwareReleaseStruct`, thus it always evaluated to `true`. Loading history...
49			$config['release'] = $release;
50			}
51
52			if ($this->customConfig) {
			0 ignored issues – show Bug Best Practice introduced 2018-05-08 14:33 UTC by Report Bug Copy Issue Report The expression `$this->customConfig` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
53			$config['custom'] = $this->customConfig;
54			}
55
56			return new Config($config, $this->shopProvider->getDefaultShopId());
57			}
58			}
59

shopware-blog / shopware-environment-variables

Factory::factory() A last analyzed 2019-09-12 08:59 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Factory::factory() A
last analyzed 2019-09-12 08:59 UTC