shootphp / shoot

src/Twig/Node/DisplayStartNode.php

<?php
declare(strict_types=1);

namespace Shoot\Shoot\Twig\Node;

use Twig\Compiler;
use Twig\Node\ModuleNode;
use Twig\Node\Node;

/**
 * This node is added to the top of the display method of a Twig template and is used by Shoot to wrap the method's
 * contents in a callback.
 *
 * @internal
 */
final class DisplayStartNode extends Node
{
    /** @var FindPresentationModelInterface */
    private $findPresentationModel;

    /** @var ModuleNode */
    private $module;

    /**
     * @param ModuleNode                     $module
     * @param FindPresentationModelInterface $findPresentationModel
     */
    public function __construct(ModuleNode $module, FindPresentationModelInterface $findPresentationModel)
    {
        parent::__construct();

        $this->module = $module;
        $this->findPresentationModel = $findPresentationModel;

        $this->setSourceContext($module->getSourceContext());

It seems like $module->getSourceContext() can also be of type null; however, parameter $source of Twig\Node\Node::setSourceContext() does only seem to accept Twig\Source, maybe add an additional type check?

    }

    /**
     * @param Compiler $compiler
     *
     * @return void
     */
    public function compile(Compiler $compiler): void
    {
        if ($this->module->hasAttribute('is_embedded')) {
            return;
        }

        $presentationModel = $this->findPresentationModel->for($this->getSourceContext());

It seems like $this->getSourceContext() can also be of type null; however, parameter $source of Shoot\Shoot\Twig\Node\FindPresentationModelInterface::for() does only seem to accept Twig\Source, maybe add an additional type check?

        $compiler
            ->write("\$presentationModel = new $presentationModel(\$context);\n")
            ->write("\$originalContext = \$context;\n\n")
            ->write("\$callback = function (array \$context) use (\$blocks, \$originalContext, \$macros) {\n")
            ->indent()
            ->write("\$suppressedException = null;\n\n");
    }
}