shomisha / unusual-relationships

src/HasUnusualRelationships.php

<?php

namespace Shomisha\UnusualRelationships;

use Illuminate\Support\Str;
use Illuminate\Database\Eloquent\Model;
use Shomisha\UnusualRelationships\Relationships\BelongsToManyThrough;

trait HasUnusualRelationships
{
    protected function belongsToManyThrough(string $related, string $through, string $foreign = null, string $pivot = null, string $pivotRelatedForeign = null, $pivotThroughForeign = null)
    {
        /** @var \Illuminate\Database\Eloquent\Model $relatedInstance */
        $relatedInstance = new $related;

        /** @var \Illuminate\Database\Eloquent\Model $throughInstance */
        $throughInstance = new $through;

        return new BelongsToManyThrough(
            $relatedInstance->newQuery(),
            $this,

$this of type Shomisha\UnusualRelationships\HasUnusualRelationships is incompatible with the type Illuminate\Database\Eloquent\Model expected by parameter $parent of Shomisha\UnusualRelationships\Relationships\BelongsToManyThrough::__construct().

            $relatedInstance,
            $throughInstance,
            $foreign ?? $this->getForeignKey(),

It seems like getForeignKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $pivot ?? $this->guessPivot($relatedInstance, $throughInstance),
            $pivotRelatedForeign ?? $relatedInstance->getForeignKey(),
            $pivotThroughForeign ?? $throughInstance->getForeignKey()
        );
    }

    /**
     * Guess the pivot table name for the provided Models.
     *
     * @param Model[] ...$models
     * @return string
     */
    protected function guessPivot(...$models)
    {
        return collect($models)->map(function (Model $model) {
            return Str::singular($model->getTable());
        })->sort()->join('_');
    }
}