Issues in AbstractXml.php (master) - Issues in master - shogodev/argilla - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1410)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

protected/models/xml/AbstractXml.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @author Sergey Glagolev <[email protected]>
 * @link https://github.com/shogodev/argilla/
 * @copyright Copyright &copy; 2003-2014 Shogo
 * @license http://argilla.ru/LICENSE
 * @package frontend.models.xml
 */
abstract class AbstractXml extends CComponent
{
  public $templatesAlias = 'frontend.views.xml';

  public $charset = 'windows-1251';

  public $template;

  public $filePath;

  public $dataProviderClass;

  /**
   * @var CDbCriteria
   */
  public $criteria;

  public $cacheDurationInSeconds = 86400;

  /**
   * @var SimpleXMLElement
   */
  protected $xmlDocument;

  protected $dataProvider;

  abstract public function buildXml();

  public function init()
  {
    $this->filePath = $this->getXmlPath();

    if( !$this->loadXml() )
    {
      $this->xmlDocument = new SimpleXMLElement($this->getTemplatePath($this->template), false, true);

      if( isset($this->dataProviderClass) )

      {
        $this->criteria = isset($this->criteria) ? $this->criteria : new CDbCriteria();
        $this->dataProvider = new $this->dataProviderClass($this->criteria);
      }

      $this->buildXml();
      $this->saveXml();
    }
  }

  public function render()
  {
    header('Content-Type: text/xml; charset='.$this->charset);
    echo $this->xmlDocument->asXML();
    Yii::app()->end();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
  }

  /**
   * @return bool
   */
  private function loadXml()
  {
    if( Yii::app()->request->getQuery('force') === 'force' || !file_exists($this->filePath) || ( time() - filemtime($this->filePath) > $this->cacheDurationInSeconds ) )
    {
      set_time_limit(0);
      ignore_user_abort(true);
      return false;
    }
    else
    {
      $this->xmlDocument = simplexml_load_file($this->filePath);
      return true;
    }

    return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
  }

  private function saveXml()

  {
    $dir = pathinfo($this->filePath, PATHINFO_DIRNAME);
    if( !file_exists($dir) )
    {
      mkdir($dir);
      chmod($dir, 0775);
    }

    $this->xmlDocument->saveXML($this->filePath);
    chmod($this->filePath, 0775);
  }

  /**
   * @param string $template
   *
   * @return string $path
   * @throws InvalidArgumentException
   */
  private function getTemplatePath($template)

  {
    if( $template === null )
    {
      $template = str_replace("Xml", "", lcfirst(get_called_class()));
    }

    $path = Yii::getPathOfAlias($this->templatesAlias.'.'.$template).'.php';

    if( !file_exists($path) )
    {
      throw new InvalidArgumentException('Отсутствует файл шаблона '.$path);
    }

    return $path;
  }

  /**
   * @return string $filePath
   */
  private function getXmlPath()

  {
    if( !isset($this->filePath) )
    {
      $class = str_replace('DataProvider', '', $this->dataProviderClass);
      $this->filePath = 'f/xml/'.lcfirst($class).'.xml';
    }

    return $this->filePath;
  }
}

1		<?php
2		/**
3		* @author Sergey Glagolev <[email protected]>
4		* @link https://github.com/shogodev/argilla/
5		* @copyright Copyright © 2003-2014 Shogo
6		* @license http://argilla.ru/LICENSE
7		* @package frontend.models.xml
8		*/
9		abstract class AbstractXml extends CComponent
10		{
11		public $templatesAlias = 'frontend.views.xml';
12
13		public $charset = 'windows-1251';
14
15		public $template;
16
17		public $filePath;
18
19		public $dataProviderClass;
20
21		/**
22		* @var CDbCriteria
23		*/
24		public $criteria;
25
26		public $cacheDurationInSeconds = 86400;
27
28		/**
29		* @var SimpleXMLElement
30		*/
31		protected $xmlDocument;
32
33		protected $dataProvider;
34
35		abstract public function buildXml();
36
37		public function init()
38		{
39		$this->filePath = $this->getXmlPath();
40
41		if( !$this->loadXml() )
42		{
43		$this->xmlDocument = new SimpleXMLElement($this->getTemplatePath($this->template), false, true);
44
45	View Code Duplication	if( isset($this->dataProviderClass) )
		0 ignored issues – show Duplication introduced 2016-03-02 12:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46		{
47		$this->criteria = isset($this->criteria) ? $this->criteria : new CDbCriteria();
48		$this->dataProvider = new $this->dataProviderClass($this->criteria);
49		}
50
51		$this->buildXml();
52		$this->saveXml();
53		}
54		}
55
56		public function render()
57		{
58		header('Content-Type: text/xml; charset='.$this->charset);
59		echo $this->xmlDocument->asXML();
60		Yii::app()->end();
		0 ignored issues – show Bug introduced 2016-08-17 11:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `end` does only exist in `BTestApplication and FTestApplication`, but not in `BApplication and FApplication`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
61		}
62
63		/**
64		* @return bool
65		*/
66		private function loadXml()
67		{
68		if( Yii::app()->request->getQuery('force') === 'force' \|\| !file_exists($this->filePath) \|\| ( time() - filemtime($this->filePath) > $this->cacheDurationInSeconds ) )
69		{
70		set_time_limit(0);
71		ignore_user_abort(true);
72		return false;
73		}
74		else
75		{
76		$this->xmlDocument = simplexml_load_file($this->filePath);
77		return true;
78		}
79
80		return false;
		0 ignored issues – show Unused Code introduced 2015-11-25 11:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this `return false;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
81		}
82
83	View Code Duplication	private function saveXml()
		0 ignored issues – show Duplication introduced 2017-10-20 12:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
84		{
85		$dir = pathinfo($this->filePath, PATHINFO_DIRNAME);
86		if( !file_exists($dir) )
87		{
88		mkdir($dir);
89		chmod($dir, 0775);
90		}
91
92		$this->xmlDocument->saveXML($this->filePath);
93		chmod($this->filePath, 0775);
94		}
95
96		/**
97		* @param string $template
98		*
99		* @return string $path
100		* @throws InvalidArgumentException
101		*/
102	View Code Duplication	private function getTemplatePath($template)
		0 ignored issues – show Duplication introduced 2017-10-20 12:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
103		{
104		if( $template === null )
105		{
106		$template = str_replace("Xml", "", lcfirst(get_called_class()));
107		}
108
109		$path = Yii::getPathOfAlias($this->templatesAlias.'.'.$template).'.php';
110
111		if( !file_exists($path) )
112		{
113		throw new InvalidArgumentException('Отсутствует файл шаблона '.$path);
114		}
115
116		return $path;
117		}
118
119		/**
120		* @return string $filePath
121		*/
122	View Code Duplication	private function getXmlPath()
		0 ignored issues – show Duplication introduced 2017-10-20 12:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
123		{
124		if( !isset($this->filePath) )
125		{
126		$class = str_replace('DataProvider', '', $this->dataProviderClass);
127		$this->filePath = 'f/xml/'.lcfirst($class).'.xml';
128		}
129
130		return $this->filePath;
131		}
132		}

GitHub Access Token became invalid

Issues (1410)

Security Analysis not enabled

protected/models/xml/AbstractXml.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

shogodev / argilla

GitHub Access Token became invalid

Issues (1410)

Security Analysis not enabled

protected/models/xml/AbstractXml.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like