Issues in CompareController.php (master) - Issues in master - shogodev/argilla - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1410)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

protected/controllers/CompareController.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @author Alexey Tatarinov <[email protected]>
 * @link https://github.com/shogodev/argilla/
 * @copyright Copyright &copy; 2003-2014 Shogo
 * @license http://argilla.ru/LICENSE
 * @package frontend.controllers
 */
class CompareController extends FController
{
  public function init()
  {
    parent::init();

    $this->processCompareAction();
  }

  public function actionIndex()
  {
    $this->breadcrumbs = array('Сравнение');

    $data = array();

    if( $selectedSection = $this->getSelectedSection() )
    {
      $productList = $this->compare->getProductListByGroup($selectedSection->id);
      $parametersCompare = $this->getParametersCompare($productList);

      $data = array(
        'selectedSection' => $selectedSection,
        'parametersCompare' => $parametersCompare,
        'productsDataProvider' => $productList->getDataProvider(),
      );
    }

    if( Yii::app()->request->isAjaxRequest )
    {
      $this->renderPartial('_compare_header');
      $this->renderPartial('compare', $data);
    }
    else
      $this->render('compare', $data);
  }

  public function actionAdd()
  {
    $request = Yii::app()->request;
    $data = $request->getPost($this->compare->keyCollection);

    if( !$request->isAjaxRequest && $request->getPost('action') != 'add'  )
      return;

    /**
     * @var Product $product
     */
    $product = Product::model()->findByPk(Arr::get($data, 'id'));

    if( !$product )
      throw new CHttpException(500, 'Ошибка продукт не найден.');

    if( !$this->compare->isInCollection($product) )
      $this->compare->add($data);

    $this->renderPartial('_compare_header');

    Yii::app()->end();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
  }

  protected function processCompareAction()
  {
    $request = Yii::app()->request;

    if( !$request->isAjaxRequest )
      return;

    $data = $request->getPost($this->compare->keyCollection);
    $action = $request->getPost('action');

    if( $data && $action )
    {
      switch($action)
      {
        case 'remove':

          $index = Arr::get($data, 'index');

          if( is_null($index) )
            $index = $this->compare->getIndex($data);

          if( is_null($index) || !$this->compare->exists($index) )
            throw new CHttpException(500, 'Данный продукт уже удален. Обновите страницу.');

          $this->compare->remove($index);
        break;
      }
    }
  }

  /**
   * Возвращает не пустые параметры сравнения
   * @param ProductList $productList
   *
   * @return array;

   */
  protected function getParametersCompare($productList)
  {
    $notEmptyParametersCompare = array();

    foreach($productList->getDataProvider()->getData() as $product)
    {
      foreach($product->getParameters() as $parameter)
      {
        if( !empty($parameter->value) )
          $notEmptyParametersCompare[$parameter->id] = $parameter;
      }
    }

    return $notEmptyParametersCompare;
  }

  protected function getProductsForChange($sectionId)
  {
    $criteria = new CDbCriteria();
    $criteria->compare('a.section_id', $sectionId);
    $criteria->order = 't.name';

    return new ProductList($criteria, null, false);
  }

  /**
   * @return FCollectionElement|ProductSection
   */
  protected function getSelectedSection()
  {
    $data = Yii::app()->request->getParam($this->compare->keyCollection, array());

    $sectionId = Arr::get($data, 'groupId');
    if( !$sectionId )
      $sectionId = Arr::get($data, 'id');

    $selectedSection = null;

    /**
     * @var FCollectionElement|ProductSection $section
     */
    foreach($this->compare->getGroups() as $section)
    {
      if( $section->id == $sectionId  )
      {
        $selectedSection = $section;
        break;
      }
      else if( empty($selectedSection) )
        $selectedSection = $section;
    }

    return $selectedSection;
  }
}

1		<?php
2		/**
3		* @author Alexey Tatarinov <[email protected]>
4		* @link https://github.com/shogodev/argilla/
5		* @copyright Copyright © 2003-2014 Shogo
6		* @license http://argilla.ru/LICENSE
7		* @package frontend.controllers
8		*/
9		class CompareController extends FController
10		{
11		public function init()
12		{
13		parent::init();
14
15		$this->processCompareAction();
16		}
17
18		public function actionIndex()
19		{
20		$this->breadcrumbs = array('Сравнение');
21
22		$data = array();
23
24		if( $selectedSection = $this->getSelectedSection() )
25		{
26		$productList = $this->compare->getProductListByGroup($selectedSection->id);
27		$parametersCompare = $this->getParametersCompare($productList);
28
29		$data = array(
30		'selectedSection' => $selectedSection,
31		'parametersCompare' => $parametersCompare,
32		'productsDataProvider' => $productList->getDataProvider(),
33		);
34		}
35
36		if( Yii::app()->request->isAjaxRequest )
37		{
38		$this->renderPartial('_compare_header');
39		$this->renderPartial('compare', $data);
40		}
41		else
42		$this->render('compare', $data);
43		}
44
45		public function actionAdd()
46		{
47		$request = Yii::app()->request;
48		$data = $request->getPost($this->compare->keyCollection);
49
50		if( !$request->isAjaxRequest && $request->getPost('action') != 'add' )
51		return;
52
53		/**
54		* @var Product $product
55		*/
56		$product = Product::model()->findByPk(Arr::get($data, 'id'));
57
58		if( !$product )
59		throw new CHttpException(500, 'Ошибка продукт не найден.');
60
61		if( !$this->compare->isInCollection($product) )
62		$this->compare->add($data);
63
64		$this->renderPartial('_compare_header');
65
66		Yii::app()->end();
		0 ignored issues – show Bug introduced 2016-08-17 11:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `end` does only exist in `BTestApplication and FTestApplication`, but not in `BApplication and FApplication`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
67		}
68
69		protected function processCompareAction()
70		{
71		$request = Yii::app()->request;
72
73		if( !$request->isAjaxRequest )
74		return;
75
76		$data = $request->getPost($this->compare->keyCollection);
77		$action = $request->getPost('action');
78
79		if( $data && $action )
80		{
81		switch($action)
82		{
83	View Code Duplication	case 'remove':
		0 ignored issues – show Duplication introduced 2015-11-25 11:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
84		$index = Arr::get($data, 'index');
85
86		if( is_null($index) )
87		$index = $this->compare->getIndex($data);
88
89		if( is_null($index) \|\| !$this->compare->exists($index) )
90		throw new CHttpException(500, 'Данный продукт уже удален. Обновите страницу.');
91
92		$this->compare->remove($index);
93		break;
94		}
95		}
96		}
97
98		/**
99		* Возвращает не пустые параметры сравнения
100		* @param ProductList $productList
101		*
102		* @return array;
		0 ignored issues – show Documentation introduced 2015-11-25 11:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this The doc-type `array;` could not be parsed: Expected "\|" or "end of type", but got ";" at position 5. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
103		*/
104		protected function getParametersCompare($productList)
105		{
106		$notEmptyParametersCompare = array();
107
108		foreach($productList->getDataProvider()->getData() as $product)
109		{
110		foreach($product->getParameters() as $parameter)
111		{
112		if( !empty($parameter->value) )
113		$notEmptyParametersCompare[$parameter->id] = $parameter;
114		}
115		}
116
117		return $notEmptyParametersCompare;
118		}
119
120		protected function getProductsForChange($sectionId)
121		{
122		$criteria = new CDbCriteria();
123		$criteria->compare('a.section_id', $sectionId);
124		$criteria->order = 't.name';
125
126		return new ProductList($criteria, null, false);
127		}
128
129		/**
130		* @return FCollectionElement\|ProductSection
131		*/
132		protected function getSelectedSection()
133		{
134		$data = Yii::app()->request->getParam($this->compare->keyCollection, array());
135
136		$sectionId = Arr::get($data, 'groupId');
137		if( !$sectionId )
138		$sectionId = Arr::get($data, 'id');
139
140		$selectedSection = null;
141
142		/**
143		* @var FCollectionElement\|ProductSection $section
144		*/
145		foreach($this->compare->getGroups() as $section)
146		{
147		if( $section->id == $sectionId )
148		{
149		$selectedSection = $section;
150		break;
151		}
152		else if( empty($selectedSection) )
153		$selectedSection = $section;
154		}
155
156		return $selectedSection;
157		}
158		}

GitHub Access Token became invalid

Issues (1410)

Security Analysis not enabled

protected/controllers/CompareController.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

shogodev / argilla

GitHub Access Token became invalid

Issues (1410)

Security Analysis not enabled

protected/controllers/CompareController.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like